From: Damien Le Moal <dlemoal@kernel.org>
To: yangxingui <yangxingui@huawei.com>,
axboe@kernel.dk, John Garry <john.g.garry@oracle.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
James.Bottomley@HansenPartnership.com,
"Martin K. Petersen" <martin.petersen@oracle.com>,
damien.lemoal@opensource.wdc.com
Subject: Re: [bug report] block: Non-NCQ commands will never be executed while fio is continuously running
Date: Tue, 10 Sep 2024 13:45:43 +0900 [thread overview]
Message-ID: <5b4a15be-1cb2-4477-8f17-b808612d10d5@kernel.org> (raw)
In-Reply-To: <129e1e4b-426f-3d5b-b95c-d386c90cfe06@huawei.com>
On 9/10/24 10:09 AM, yangxingui wrote:
>
>
> On 2024/9/9 21:21, Damien Le Moal wrote:
>> On 9/9/24 22:10, yangxingui wrote:
>>> Hello axboe & John,
>>>
>>> After the driver exposes all HW queues to the block layer, non-NCQ
>>> commands will never be executed while fio is continuously running, such
>>> as a smartctl command.
>>>
>>> The cause of the problem is that other hctx used by the NCQ command is
>>> still active and can continue to issue NCQ commands to the sata disk.
>>> And the pio command keeps retrying in its corresponding hctx because
>>> qc_defer() always returns true.
>>>
>>> hctx0: ncq, pio, ncq
>>> hctx1:ncq, ncq, ...
>>> ...
>>> hctxn: ncq, ncq, ...
>>>
>>> Is there any good solution for this?
>>
>> SATA devices are single queue so how can you have multiple queues ?
>> What adapter are you using ?
>
> In the following patch, we expose the host's 16 hardware queues to the block
> layer. And when connecting to a sata disk, 16 hctx are used.
>
> 8d98416a55eb ("scsi: hisi_sas: Switch v3 hw to MQ")
OK, so the HBA is a hisi one, using libsas...
What is the device ? An SSD ? and HDD ?
Do you set a block I/O scheduler for the drive, e.g. mq-deadline. If not, does
setting a scheduler resolve the issue ?
I do not have any hisi HBA. I use a lot of mpt3sas and mpi3mr HBAs which also
have multiple queues with a shared tagset. Never seen the issue you are
reporting though using HDDs with mq-deadline or bfq as the scheduler.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-09-10 4:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 13:10 yangxingui
2024-09-09 13:21 ` Damien Le Moal
2024-09-10 1:09 ` yangxingui
2024-09-10 4:45 ` Damien Le Moal [this message]
2024-09-10 6:34 ` yangxingui
2024-09-10 11:27 ` Niklas Cassel
2024-09-10 22:38 ` Damien Le Moal
2024-09-11 9:41 ` yangxingui
2024-09-19 12:26 ` Yu Kuai
2024-09-19 14:14 ` Damien Le Moal
2024-10-31 14:12 ` Niklas Cassel
2024-11-01 2:17 ` yangxingui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b4a15be-1cb2-4477-8f17-b808612d10d5@kernel.org \
--to=dlemoal@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®