From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C3E1388E4D for ; Mon, 20 Apr 2026 09:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776678693; cv=none; b=KySG5DQP8JB6I28n0VueaStQ50iQN+DZVRLEBM7bfaoeseIBQ+Mq10Ysg/mELYCs4GHufwxvS0j6AMUbVVtzzMrFeJ6VNSqFnmDK1vso5YUr5p6aEvswNJf0F6la0z/jq1KS5u8ZfvW438N1hrGvAXPgF/+RUt9AOQSSrXipc34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776678693; c=relaxed/simple; bh=M3JrCCNYq/LsQQXow9xyNwFjb3Bny+ZEYI9GFCKwa4Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iTQf3mOwgftgV2jIxp+50xA4p58itfNXujtXU5YqgH1T6M+2fN6eA8ZPdmvGV+xGT3Q+PLYszv8MO+TvAop5/AxUj5EsDj1MYs35jJ19wlaHDZLuQ/wY98HFO1FenQmFWs6k8Daeoe0jkRw1s4cslHasvzC/yVXgw1kUsKTdjYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TyCV0cQ0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OvZNrNhl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TyCV0cQ0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OvZNrNhl" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63K97EBn2755820 for ; Mon, 20 Apr 2026 09:51:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2oCc4X5gfbIoFNXE8Bk9ftZY5NhIpmxBruq4adzXl6o=; b=TyCV0cQ0p7JR9Jdm lRMzYXbDDJRO8q51VJtAauzJd32hveMutEZSNQBJtXkYljOVEsJy9RwVV3t8S7+0 awB9nXONzDtSc6PlfRFj/6VP+DbtsCwJKyh5a1+2vuN/xe1kCpH5cuO2gI786nuV +8DqG2AXJxRSKch7f4fKIZBTYZvsj6asRKzAy6ngQkZo/Y5MKfIDZ+HQWfVXoQCA HXXlO/IP/RPQsV66fZs5RSLvbbNhLFZkr/IXIUZoWoRV6ipOLTSvItTRKhyBxVIp /fDAgTroik9LQ/szwnVsmpyHpKa3kP/rdjkVlLrIb3YW5W9IzJ3T3yGc9P9UCWmz +hK3fg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dnh7xg5qh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Apr 2026 09:51:31 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50d8c183c2eso28465021cf.0 for ; Mon, 20 Apr 2026 02:51:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776678690; x=1777283490; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2oCc4X5gfbIoFNXE8Bk9ftZY5NhIpmxBruq4adzXl6o=; b=OvZNrNhlcTQuQaAylnU5He2AR7qa/dEMGWOe3xpm2TjBbXh/UpJtmN3cqV+0fglIbi OPxOvNh2o6I85IExRngrejdzAXXKyON++LjkXk/UduV9Hq/1bOUNvxU8OmcFWdGkv6zz GFc0bwKfUgCV/XQz6DokYW+LS6PBGaKtZtaJv8DtMiU2OrRjlrekHFPY1jvilj+GH2AW dPl3vgU+lyuQtCPNFHoHS4kpRePqJ5XoNLDRx4bVzPf1r6WtdSUEab+EE7CCMdbLt366 IWPk605/brIH3XMRgzOgSkxf4+oNTpNRddUP45fXbCZC+t9immqhU4ise14Pv9wmWBVs Q5bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776678690; x=1777283490; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2oCc4X5gfbIoFNXE8Bk9ftZY5NhIpmxBruq4adzXl6o=; b=CZYF1fZI45AtAzM9mz0vikTrK+0kxbsVXm8CSk/vflT9iXVqbNxeBxzK8yTNFSfeKp XyC0cj1vQuC2WCIfwTedSn8ZYpvqnvnM0Cc3+xDf+WKpDSzVHsPeJLw4nH8iJXaWR1DC 9k/NR59fmQ+AfIZtIRolOjgEBljSDWGCnwE+5kzxdV1EuBmWIesOttK8ufJMlrWvIInc mktF/vuZb1mfNGUX03sDjQEqHlHj2qRl8AAbKYFDZa6skRRCMraDhjeJtq6oBrkAoLoX APTMTsmWerh5Z9e3w3VcC94yqzLORzmxTCnYiSRxgVrNpV8tLTeuxHvAgsTS+41bEamC O4Cw== X-Forwarded-Encrypted: i=1; AFNElJ/oVLDlG0KrOrofao/Nx6OTMj1K0dPfq3XpIQpZc93sST3g9oYlpRbwUpeZxV9nbx2e+0tQ9lARcvnY4nc=@vger.kernel.org X-Gm-Message-State: AOJu0YwS/wgO1lpTMey2+Z5XOktrZcZ8KAYlgR/1xWQ42kQcUAqfUUPg WzS4IsStSCz6MfY2mXyNhzyQJG60palNUmC7SSUjKfBzcGYQyS932+tWV4/95IkpxbQFjzQJKVS KwHok4bjG9HF/1kjt4XP/IWgbWme0E/a/5Nar1xlLtGavyxXDCjtzX2EVsUt5jkwYwDwVI9J9HL 4= X-Gm-Gg: AeBDietzF5izkPwVvAlrobXcunDfPu6xXE2ssrD6752h4dfLWSfaTBZvwSns6c0gW/E k+hyPdzlEiJ4Rm1n6y3GIySEjnDr3XyODifKX3rlHoQ2s2h21V7WAFTNuuGyrHM424tkctRWYd6 QRI7PqtP2vEkNu3PHwSqzRuzyiWFA7UDOl1pn+7AA18zWNEmJnMbQVeJjr8qmw/RfrI+GQJ8/RR qVY0Pj45+UboYNSt3OfPDbWLf3JHnTNNN0+SJAhFFMaoKFE41b2ZO8GH6EvmvQx/0lyW7m7CZa0 /dBZK5M/NZr8Roi+D7rQOxjXuCKB5ErPpMPOV00VxXoU6oM8AOsh2i/9Qk5SwveETIrsR4698u/ ukGqy8UpYKYMLnkz1HhZ5GulzMLGQmMS6L/I6Yt4pQ9AgQHMZH5yj16XpGXOydjiZeW686CrDFe 4o98P4wYyxFL0WQg== X-Received: by 2002:a05:622a:4cce:b0:509:2b5a:808 with SMTP id d75a77b69052e-50e3683910cmr118259521cf.2.1776678690281; Mon, 20 Apr 2026 02:51:30 -0700 (PDT) X-Received: by 2002:a05:622a:4cce:b0:509:2b5a:808 with SMTP id d75a77b69052e-50e3683910cmr118259211cf.2.1776678689761; Mon, 20 Apr 2026 02:51:29 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba451211091sm348953866b.5.2026.04.20.02.51.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 02:51:28 -0700 (PDT) Message-ID: <5b4b68df-593c-41b4-a0af-4a59b10faee0@oss.qualcomm.com> Date: Mon, 20 Apr 2026 11:51:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/7] spi: qcom-qspi: Fix incomplete error handling in runtime PM To: Viken Dadhaniya , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260420-spi-nor-v3-0-7de325a29010@oss.qualcomm.com> <20260420-spi-nor-v3-2-7de325a29010@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260420-spi-nor-v3-2-7de325a29010@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIwMDA5NSBTYWx0ZWRfX+DgEmh8uJCnD xAkUC3i5gzS8zqYy4X8guBZYNvKZHaQtUS2vTHKA0fKbWUJjlNxEduNiDwH9zI7OSrqNjkBpWLc IpqYFFefeTTGykL8Q0/3KcK7vq+JFXiDPVaatnfRnHdHSVW02NXRnCXtXr9oOgp/pTYumIBKBTy B+ZB77rx67LLPcwTZZ2dabzfEIuxWEuWvgijWGQtbG5JCIbzozJMKIigTQHmTQlXHWGxvivjQC9 8Rzc8lJu4dMDA3Ua6z9kC68KPRTEXAh7oel+0D1XnMSMRzVGtwjgUSGN5AAUFygM7YVFLkoEJDA EraUlqgQjuLx5srXDRk6wukbQQSYzoPIs294042QD9bgGAlTPkM7CbSnrZTkyLuOKQzQrJMvAgr u/tYpuuOa+Dk7Hk58PA1BfymzpjjFHYB0Z/uPlOxRQzxs0lQ4oaqMJIShcfB8+DdmoZvz2u7dTG YLOyoKYyXTHdX8jr8yQ== X-Authority-Analysis: v=2.4 cv=BPmDalQG c=1 sm=1 tr=0 ts=69e5f723 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=SDBIUcquJ5ihQ-it0pQA:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=zZCYzV9kfG8A:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: YyeGhuqmSpEX9zH-YQO7mQc2B8cYaEDS X-Proofpoint-GUID: YyeGhuqmSpEX9zH-YQO7mQc2B8cYaEDS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-20_02,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604200095 On 4/20/26 8:12 AM, Viken Dadhaniya wrote: > The runtime PM functions had incomplete error handling that could leave the > system in an inconsistent state. If any operation failed midway through > suspend or resume, some resources would be left in the wrong state while > others were already changed, leading to potential clock/power imbalances. > > Reorder the suspend/resume sequences to avoid brownout risk by ensuring the > performance state is set appropriately before clocks are enabled and clocks > are disabled before dropping the performance state. > > Fix by adding proper error checking for all operations and using goto-based > cleanup to ensure all successfully acquired resources are properly released > on any error. > > Signed-off-by: Viken Dadhaniya > --- Reviewed-by: Konrad Dybcio Konrad