From: James Bottomley <jejb@linux.ibm.com>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Mimi Zohar <zohar@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Jerry Snitselaar <jsnitsel@redhat.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v3 2/2] tpm: use SM3 instead of SM3_256
Date: Thu, 28 Oct 2021 08:56:38 -0400 [thread overview]
Message-ID: <5b4ef3212232836b02920e57014d69300b484f20.camel@linux.ibm.com> (raw)
In-Reply-To: <20211026075626.61975-3-tianjia.zhang@linux.alibaba.com>
On Tue, 2021-10-26 at 15:56 +0800, Tianjia Zhang wrote:
> According to https://tools.ietf.org/id/draft-oscca-cfrg-sm3-01.html,
> SM3 always produces a 256-bit hash value and there are no plans for
> other length development, so there is no ambiguity in the name of
> sm3.
Please just drop this piece.
[...]
> hash= hash algorithm name as a string. For TPM 1.x
> the only
> allowed value is sha1. For TPM 2.x the allowed
> values
> - are sha1, sha256, sha384, sha512 and sm3-256.
> + are sha1, sha256, sha384, sha512 and sm3.
the hash parameter is an external ABI we can't simply change ... as
Jarkko already told you.
The rest are constants defined in the TPM standard, which we shouldn't
change because then it makes everyone wonder why we're deviating.
James
next prev parent reply other threads:[~2021-10-28 12:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 7:56 [PATCH v3 0/2] " Tianjia Zhang
2021-10-26 7:56 ` [PATCH v3 1/2] crypto: " Tianjia Zhang
2021-10-28 6:44 ` Jarkko Sakkinen
2021-10-26 7:56 ` [PATCH v3 2/2] tpm: " Tianjia Zhang
2021-10-28 12:56 ` James Bottomley [this message]
2021-10-26 16:08 ` [PATCH v3 0/2] " Ard Biesheuvel
2021-10-28 13:07 ` James Bottomley
2021-11-29 13:01 ` Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b4ef3212232836b02920e57014d69300b484f20.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=serge@hallyn.com \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®