From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F5DF42E8E4 for ; Mon, 27 Jul 2026 20:31:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184270; cv=none; b=MfbNHX7uigc8EFF7pnbrZE2YNjSN+AHMOGZ17onViJ34XDzUA13F6BMYYJn/+v9UHlL26zN2c0qeGt1KT75bAtJYZWmcOuzDGaUd3j5uByaE2ipSHh8k3bf+RHHG1S1v5ptTBjZtVo2Swv99Cxb5R9cC32R5gpXy0n9bklBhqoE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785184270; c=relaxed/simple; bh=oLkfYs0tq/lckQE0TRTX0GOH7OhXTYuSGY+4lbqd36o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d6/Ou+g28DQkDXJ+kACH2lRtaXnmyH4dl0Dmg5ukKUA3Y5liweVeOwkkLJQyaS6P0yc7ntssVNXZrEg/1Qj2hr0zVQl4BJUHARyMg0XlH72sjn1NaTJbsvmVGmcNvOFmyhRvCf451lIHQOHHTKUj+nCzmkqoC7bBgJkvGoE5QF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jC/u1dux; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jC/u1dux" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cca0c5799eso29753035ad.0 for ; Mon, 27 Jul 2026 13:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785184269; x=1785789069; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=n8T8TWTQyQ+SWBV2PlP1tfSh0YEULzmTov2IR/fRnoA=; b=jC/u1duxGH5mCQ22RDJqTODo/3Lz+pyfXRfHtHYu0u0ipODoaAKPLjWFZyqJevnIw+ m69q9dwuclqZxvEUpYSd3Bu9gqTyfnXXW9mCtVpSxEMlG+4A0CZ/VQ2rANXGXD6sSDXF Na9PxGbho8s9sXQbCThsFRCV6iEXIwMmTcoli3h1VzZ77RQ+R/GhJL8GMPrgG626svrx SOh3Rx0S3gKzXB6aJcWl6aPj9Lcb3S2UFm72nTn50ufwvBpqXhJPEirSGISri2r05Wkc Gmi+vLaN3+pZWcpR6f9+pd38FA9Mbh350vUCnzzdQ9PSoRWQNqPXk8L/lxDqFe/Wv5Jc DpBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785184269; x=1785789069; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=n8T8TWTQyQ+SWBV2PlP1tfSh0YEULzmTov2IR/fRnoA=; b=gFt+0+2uiaOlCBVWdJBfmN2LAQ6dlFvut2QnDb2UsfafXlePJUX0r6VOrW7WwkkcoU N34UUMJLAGGD93WGMjIudFShvvUOiImVb02NufvLVuvVk2Kub4jqYT1LQrwOSK2TGes0 Uv+zSnpcfrRT5h3sTjBRa5r/oBGpdY0PSK0xOJocR0I3J47qECnnWUHexo1HEI+unXJa +MJcaxdRhyzJJBeqN+waaAGGUrUzAAgstm4uhRVS5kPpNgQA4mWbfe2X6iOn7N8RTq6/ xp7HTyfGrs4xKLj/pZktu+YqrdVisi24Hh3IjHRVFp1OrfN3l8yN0nsLGO+vaSUMQFEX CncA== X-Forwarded-Encrypted: i=1; AHgh+RoVmzuHhW1gJsvE5GaE+GePXz03G3ut8LmzGAGTXyX5URIhGURTuaSlNrlMjyYQn7s4gedX+60G6P03CTU=@vger.kernel.org X-Gm-Message-State: AOJu0YwFTVCXLNcLPhuOHnSf6GCKp2kaElvyQlzUngmEm1WAOa2VyzQP gsUAyacYZtEw3y0pDImly5QDWl+96uph+WJVPNsG87ChVMM2t/x1sUAN X-Gm-Gg: AR+sD10nugQLskqx3NtP2BBFVMMmokrq0MPl4IwSgHxZ/rYy+IXPsPQzLoc5CvRKBjI tIObkVI3n67Uf24zPoKATsMDQoecR6rHtjrIQXK2ZilABENO+5NRtL91CXLy+J8x+1aeWf4O0gJ n90CTjiGUSOfsysGCIFNX83uzBZl+9Vt3cZcHVna3w9TQOZQ/2+aMxJvXyX8kPGRJxWaDWv1E78 3Ii4d+3eXpFeLceE5qnH0FK7lVz5x2vrQ2WfTPSJrmtALGRfPf4s2rXwDvM+cG5bYJgr3fOSFNI gGuiQDiiq7qSkkTeF5Ltxa01Cb5Odk87EqS3sHmzjdNNGC2U8ySREDV+uI6pzmCPkJHZ1ICa3Hf mMa6O2rB2O7v0HZAaHFiiIPViCYK1JaosvzvmCEIhkZPXZsmhXZGH/t22qUoh7v+phIolembqzU LLpczyvTGEIOYYMxc= X-Received: by 2002:a17:902:d2d2:b0:2c9:aae1:a61c with SMTP id d9443c01a7336-2cfde7af8b3mr89163145ad.20.1785184268669; Mon, 27 Jul 2026 13:31:08 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fab:e200:3789:64f9:8855:c0af]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde59b768sm41551805ad.4.2026.07.27.13.31.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 13:31:08 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook Subject: [PATCH v2 05/64] dmaengine: ep93xx: hook callbacks via dma_chan BH Date: Mon, 27 Jul 2026 13:28:33 -0700 Message-ID: <5b4f1f6e674bd520c47cb058ba400bc033bd446b.1785183549.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20260108080332.2341725-1-allen.lkml@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the per-channel tasklet with the shared dma_chan BH helper. The handler continues to run in softirq context while dmaengine owns the common scheduling and teardown mechanism. Signed-off-by: Allen Pais --- drivers/dma/ep93xx_dma.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c index 311e55a97ba9..8f5200750fe9 100644 --- a/drivers/dma/ep93xx_dma.c +++ b/drivers/dma/ep93xx_dma.c @@ -167,7 +167,6 @@ struct ep93xx_dma_chan_cfg { * @dma_cfg: channel number, direction * @irq: interrupt number of the channel * @clk: clock used by this channel - * @tasklet: channel specific tasklet used for callbacks * @lock: lock protecting the fields following * @flags: flags for the channel * @buffer: which buffer to use next (0/1) @@ -196,7 +195,6 @@ struct ep93xx_dma_chan { struct ep93xx_dma_chan_cfg dma_cfg; int irq; struct clk *clk; - struct tasklet_struct tasklet; /* protects the fields following */ spinlock_t lock; unsigned long flags; @@ -801,9 +799,9 @@ static void ep93xx_dma_advance_work(struct ep93xx_dma_chan *edmac) spin_unlock_irqrestore(&edmac->lock, flags); } -static void ep93xx_dma_tasklet(struct tasklet_struct *t) +static void ep93xx_dma_tasklet(struct dma_chan *chan) { - struct ep93xx_dma_chan *edmac = from_tasklet(edmac, t, tasklet); + struct ep93xx_dma_chan *edmac = to_ep93xx_dma_chan(chan); struct ep93xx_dma_desc *desc, *d; struct dmaengine_desc_callback cb; LIST_HEAD(list); @@ -858,12 +856,12 @@ static irqreturn_t ep93xx_dma_interrupt(int irq, void *dev_id) switch (edmac->edma->hw_interrupt(edmac)) { case INTERRUPT_DONE: desc->complete = true; - tasklet_schedule(&edmac->tasklet); + dma_chan_schedule_bh(&edmac->chan); break; case INTERRUPT_NEXT_BUFFER: if (test_bit(EP93XX_DMA_IS_CYCLIC, &edmac->flags)) - tasklet_schedule(&edmac->tasklet); + dma_chan_schedule_bh(&edmac->chan); break; default: @@ -1420,7 +1418,7 @@ static struct ep93xx_dma_engine *ep93xx_dma_of_probe(struct platform_device *pde INIT_LIST_HEAD(&edmac->active); INIT_LIST_HEAD(&edmac->queue); INIT_LIST_HEAD(&edmac->free_list); - tasklet_setup(&edmac->tasklet, ep93xx_dma_tasklet); + dma_chan_init_bh(&edmac->chan, ep93xx_dma_tasklet); list_add_tail(&edmac->chan.device_node, &dma_dev->channels); -- 2.43.0