From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754191AbdJIMEF (ORCPT ); Mon, 9 Oct 2017 08:04:05 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:33721 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbdJIMEC (ORCPT ); Mon, 9 Oct 2017 08:04:02 -0400 X-Google-Smtp-Source: AOwi7QCv8Z3ZU8YuGdLxTtr9u/vbvllInpElSb1BUohMjyYPZlNYYkgWXY9AYCNSWIizVbu3K9K2BQ== Subject: Re: [PATCH] tty: n_gsm: pr_err() strings should end with newlines To: Joe Perches , gregkh@linuxfoundation.org, jslaby@suse.com References: <1507550442.3552.2.camel@perches.com> Cc: linux-kernel@vger.kernel.org From: Arvind Yadav Message-ID: <5b51d07b-9ce8-27d6-a1c6-1113961a456a@gmail.com> Date: Mon, 9 Oct 2017 17:32:42 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1507550442.3552.2.camel@perches.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday 09 October 2017 05:30 PM, Joe Perches wrote: > On Mon, 2017-10-09 at 17:14 +0530, Arvind Yadav wrote: >> pr_err() messages should end with a new-line to avoid other messages >> being concatenated. > [] >> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c > [] >> @@ -2788,7 +2788,7 @@ static int gsm_create_network(struct gsm_dlci *dlci, struct gsm_netconfig *nc) >> net = alloc_netdev(sizeof(struct gsm_mux_net), netname, >> NET_NAME_UNKNOWN, gsm_mux_net_init); >> if (!net) { >> - pr_err("alloc_netdev failed"); >> + pr_err("alloc_netdev failed\n"); >> return -ENOMEM; >> } >> net->mtu = dlci->gsm->mtu; > You could just delete the pr_err instead. > > It's an unnecessary message as there would > be a dump_stack() on the kvzalloc() in > alloc_netdev() on any OOM failure. You are right, We can delete. I will send updated patch. > > ~arvind