From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Aradhya Bhatia <a-bhatia1@ti.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Jyri Sarha <jyri.sarha@iki.fi>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: DRI Development List <dri-devel@lists.freedesktop.org>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Dominik Haller <d.haller@phytec.de>,
Sam Ravnborg <sam@ravnborg.org>,
Thierry Reding <treding@nvidia.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Praneeth Bajjuri <praneeth@ti.com>, Udit Kumar <u-kumar1@ti.com>,
Devarsh Thakkar <devarsht@ti.com>,
Jayesh Choudhary <j-choudhary@ti.com>,
Jai Luthra <j-luthra@ti.com>
Subject: Re: [PATCH v4 01/11] drm/bridge: cdns-dsi: Fix OF node pointer
Date: Wed, 26 Jun 2024 13:06:31 +0300 [thread overview]
Message-ID: <5b52e560-1fca-4824-9f80-91526bf25062@ideasonboard.com> (raw)
In-Reply-To: <20240622110929.3115714-2-a-bhatia1@ti.com>
Hi,
On 22/06/2024 14:09, Aradhya Bhatia wrote:
> Fix the OF node pointer passed to the of_drm_find_bridge() call to find
> the next bridge in the display chain.
>
> To find the next bridge in the pipeline, we need to pass "np" - the OF
> node pointer of the next entity in the devicetree chain. Passing
> "of_node" to of_drm_find_bridge will make the function try to fetch the
> bridge for the cdns-dsi which is not what's required.
>
> Fix that.
The code looks fine, but I'd write the subject and desc from a different
perspective. The subject could be something like "Fix connecting to a
sink bridge", and the desc could first say that connecting the sink to a
DSI panel works, but connecting to a bridge fails, as wrong OF node is
passed to of_drm_find_bridge().
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
> Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver")
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
> ---
> drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> index 7457d38622b0..b016f2ba06bb 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> @@ -952,7 +952,7 @@ static int cdns_dsi_attach(struct mipi_dsi_host *host,
> bridge = drm_panel_bridge_add_typed(panel,
> DRM_MODE_CONNECTOR_DSI);
> } else {
> - bridge = of_drm_find_bridge(dev->dev.of_node);
> + bridge = of_drm_find_bridge(np);
> if (!bridge)
> bridge = ERR_PTR(-EINVAL);
> }
next prev parent reply other threads:[~2024-06-26 10:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-22 11:09 [PATCH v4 00/11] drm/bridge: cdns-dsi: Fix the color-shift issue Aradhya Bhatia
2024-06-22 11:09 ` [PATCH v4 01/11] drm/bridge: cdns-dsi: Fix OF node pointer Aradhya Bhatia
2024-06-26 10:06 ` Tomi Valkeinen [this message]
2024-06-22 11:09 ` [PATCH v4 02/11] drm/bridge: cdns-dsi: Move to devm_drm_of_get_bridge() Aradhya Bhatia
2024-06-26 10:10 ` Tomi Valkeinen
2024-06-22 11:09 ` [PATCH v4 03/11] drm/bridge: cdns-dsi: Fix Phy _init() and _exit() Aradhya Bhatia
2024-06-26 10:25 ` Tomi Valkeinen
2024-06-26 13:30 ` Aradhya Bhatia
2024-06-22 11:09 ` [PATCH v4 04/11] drm/bridge: cdns-dsi: Fix the link and phy init order Aradhya Bhatia
2024-06-26 10:28 ` Tomi Valkeinen
2024-06-22 11:09 ` [PATCH v4 05/11] drm/bridge: cdns-dsi: Fix the clock variable for mode_valid() Aradhya Bhatia
2024-06-26 10:47 ` Tomi Valkeinen
2024-06-26 13:56 ` Aradhya Bhatia
2024-06-22 11:09 ` [PATCH v4 06/11] drm/bridge: cdns-dsi: Wait for Clk and Data Lanes to be ready Aradhya Bhatia
2024-06-26 10:52 ` Tomi Valkeinen
2024-06-22 11:09 ` [PATCH v4 07/11] drm/bridge: cdns-dsi: Reset the DCS write FIFO Aradhya Bhatia
2024-06-26 11:03 ` Tomi Valkeinen
2024-07-11 7:30 ` Aradhya Bhatia
2024-06-22 11:09 ` [PATCH v4 08/11] drm/mipi-dsi: Add helper to find input format Aradhya Bhatia
2024-06-26 11:06 ` Tomi Valkeinen
2024-06-22 11:09 ` [PATCH v4 09/11] drm/bridge: cdns-dsi: Support atomic bridge APIs Aradhya Bhatia
2024-06-26 11:09 ` Tomi Valkeinen
2024-06-22 11:09 ` [PATCH v4 10/11] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable Aradhya Bhatia
2024-06-26 11:28 ` Tomi Valkeinen
2024-06-26 13:07 ` Maxime Ripard
2024-07-11 7:32 ` Aradhya Bhatia
2024-12-26 14:14 ` Devarsh Thakkar
2024-06-22 11:09 ` [PATCH v4 11/11] drm/bridge: cdns-dsi: Use pre_enable/post_disable to enable/disable Aradhya Bhatia
2024-06-26 11:39 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b52e560-1fca-4824-9f80-91526bf25062@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a-bhatia1@ti.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=d.haller@phytec.de \
--cc=daniel@ffwll.ch \
--cc=devarsht@ti.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=j-choudhary@ti.com \
--cc=j-luthra@ti.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jyri.sarha@iki.fi \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nm@ti.com \
--cc=praneeth@ti.com \
--cc=rfoss@kernel.org \
--cc=sam@ravnborg.org \
--cc=treding@nvidia.com \
--cc=tzimmermann@suse.de \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®