From: "Paul E. McKenney" <paulmck@kernel.org>
To: Rik van Riel <riel@surriel.com>
Cc: Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] locking/csd-lock: make CSD lock debug tunables writable in /sys
Date: Mon, 9 Dec 2024 09:56:38 -0800 [thread overview]
Message-ID: <5b53408d-80a1-4f33-9a15-12c80f736b76@paulmck-laptop> (raw)
In-Reply-To: <20241209124411.5b588faa@fangorn>
On Mon, Dec 09, 2024 at 12:44:11PM -0500, Rik van Riel wrote:
> Currently the CSD lock tunables can only be set at boot time in the
> kernel commandline, but the way these variables are used means there
> is really no reason not to tune them at runtime through /sys.
>
> Make the CSD lock debug tunables tunable through /sys.
>
> Signed-off-by: Rik van Riel <riel@surriel.com>
Good point, and queued for v6.14 merge window.
Unless someone else would prefer to carry it, in which case:
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
> ---
> kernel/smp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/smp.c b/kernel/smp.c
> index 27dc31a146a3..a33e575f97ab 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -170,9 +170,9 @@ static DEFINE_PER_CPU(smp_call_func_t, cur_csd_func);
> static DEFINE_PER_CPU(void *, cur_csd_info);
>
> static ulong csd_lock_timeout = 5000; /* CSD lock timeout in milliseconds. */
> -module_param(csd_lock_timeout, ulong, 0444);
> +module_param(csd_lock_timeout, ulong, 0644);
> static int panic_on_ipistall; /* CSD panic timeout in milliseconds, 300000 for five minutes. */
> -module_param(panic_on_ipistall, int, 0444);
> +module_param(panic_on_ipistall, int, 0644);
>
> static atomic_t csd_bug_count = ATOMIC_INIT(0);
>
> --
> 2.47.0
>
next prev parent reply other threads:[~2024-12-09 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 17:44 Rik van Riel
2024-12-09 17:56 ` Paul E. McKenney [this message]
2024-12-12 18:58 [PATCH locking/csd-lock] " Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b53408d-80a1-4f33-9a15-12c80f736b76@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neeraj.upadhyay@kernel.org \
--cc=riel@surriel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®