mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Yue Hu <zbestahu@gmail.com>
Cc: linux-erofs@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org>,
	Yue Hu <huyue2@coolpad.com>, Chunhai Guo <guochunhai@vivo.com>
Subject: Re: [PATCH v3] erofs: relaxed temporary buffers allocation on readahead
Date: Fri, 26 Jan 2024 21:30:25 +0800	[thread overview]
Message-ID: <5b5387e8-3251-4750-844e-5c34b36eee87@linux.alibaba.com> (raw)
In-Reply-To: <20240126184656.0000561c.zbestahu@gmail.com>

Hi Yue,

On 2024/1/26 18:46, Yue Hu wrote:
> On Fri, 26 Jan 2024 13:36:16 +0800
> Gao Xiang <hsiangkao@linux.alibaba.com> wrote:
> 

...

>>   	/*
>> @@ -1276,7 +1280,11 @@ static int z_erofs_decompress_pcluster(struct z_erofs_decompress_backend *be,
>>   					.inplace_io = overlapped,
>>   					.partial_decoding = pcl->partial,
>>   					.fillgaps = pcl->multibases,
>> +					.gfp = pcl->besteffort ?
>> +						GFP_KERNEL | __GFP_NOFAIL :
>> +						GFP_NOWAIT | __GFP_NORETRY
>>   				 }, be->pagepool);
>> +	pcl->besteffort = false;
> 
> reposition it following `pcl->multibases = false`?

Good idea! Let me update this.

Thanks,
Gao Xiang

  reply	other threads:[~2024-01-26 13:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <TY2PR06MB3342D2245C5E515028C33FD4BE792@TY2PR06MB3342.apcprd06.prod.outlook.com>
2024-01-26  5:36 ` Gao Xiang
2024-01-26 10:46   ` Yue Hu
2024-01-26 13:30     ` Gao Xiang [this message]
2024-01-26 14:01     ` [PATCH v4] " Gao Xiang
2024-01-27  1:49       ` Yue Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b5387e8-3251-4750-844e-5c34b36eee87@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=guochunhai@vivo.com \
    --cc=huyue2@coolpad.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zbestahu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®