From: Stas Sergeev <stsp@list.ru>
To: Johan Hovold <johan@kernel.org>
Cc: Caylan Van Larson <i@caylan.net>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH] mos7840: fix chars_in_buffer() return value
Date: Fri, 30 Sep 2016 00:00:30 +0300 [thread overview]
Message-ID: <5b55f2bb-8936-55bb-597d-68f073ea8620@list.ru> (raw)
In-Reply-To: <20160929100929.GF5650@localhost>
29.09.2016 13:09, Johan Hovold пишет:
> On Sat, Sep 24, 2016 at 06:00:57PM +0300, Stas Sergeev wrote:
>> The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on
>> a correct behaviour of that.
>> mos7840 implements it wrongly: if you write just one char, TIOCOUTQ
>> will return 32.
>> This patch should fix it by accounting the number of chars actually
>> written.
>> This patch, unfortunately, misses the Tested-by tag.
>> The reporter didn't test it, and I don't have the hardware in question.
> Why do you think the driver returns 32b in chars_in_buffer after writing
> a single character?
Hi Johan, this actually came from this ancient bug report:
https://bugzilla.kernel.org/show_bug.cgi?id=45791
I was trying to add you back then and now, but your e-mail
doesn't seem to be registered in a bug tracker.
The code in question was different when I submitted the
original patch:
https://bugzilla.kernel.org/attachment.cgi?id=77241
Maybe the bug was since fixed.
In that case sorry for the noise.
next prev parent reply other threads:[~2016-09-29 21:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 15:00 Stas Sergeev
2016-09-29 10:09 ` Johan Hovold
2016-09-29 21:00 ` Stas Sergeev [this message]
2016-09-30 11:04 ` Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2016-09-24 13:48 Stas Sergeev
2016-09-24 13:47 Stas Sergeev
2016-09-24 13:57 ` Sergei Shtylyov
2016-09-24 15:00 ` Stas Sergeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b55f2bb-8936-55bb-597d-68f073ea8620@list.ru \
--to=stsp@list.ru \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=i@caylan.net \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®