From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73F791C3C0D for ; Fri, 13 Dec 2024 11:04:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734087861; cv=none; b=IRZiBlkVVOa0OAyEIISuiKJRAu0AHwzsJ1nZi505x5qjoA3bPIgnrx2eDLASiyo71oHGm/P6IPt2Fq9iJVM6Ml4xiNQIj78tTHvKvyGCApTPAwd0v405P1eJDiojacknxOHNcEr5zYFs5yStlFO35zYESKT+PU4fSv/9ysVSoWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734087861; c=relaxed/simple; bh=8feasqDMNRGSqXgnrXNVRMsBVCYovHpwXdrFnhXAPTQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oDudwHu9f2FpnOQO6E86rzvn4H7isYPmYgw5u+RB3/dilmejWaf+V4kTC+HlwIt6azug3NiQ3AOy6qUnF4r0wUba9Z/FStDnxPCgpxSLlQG2FJiaoP1QQ9ECMW7KXJM9WGwHIFyVigS6P8q/x/T9MPdkIuHVX/j/XnXOuudWCd4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T4PpMeEk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T4PpMeEk" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BD7VQjf032414 for ; Fri, 13 Dec 2024 11:04:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Zf5tcpszL0I6CSUFS4CayyJ0mUkMjSZvXwP8wY2d3NI=; b=T4PpMeEkja7PnlT3 +PpeEFsTfsHV/LSfhm2TmHzVGk2uD+sCCourRojmAidHaOKTqfix2KPxdFlYEFBg BGYjkFDMRXoNYxrYBfPbrBJTDZXhlSykITPKSG35qncG2PmOWb8yByzvtS6VXgJF a7SBKri4J37oUvKL4zG+q86fusOdY3KPALdQ81Q/BD48wAX9NpoaTo0Cvs43tiJE qW9W9yRN4t9hIYsVnCAhLU+P8AdlApbz7t2I2Nq7Hk1OLTTysGdn4rhIG8+Pjpeo 9f3EZJgSMNwDKQJn93x2bts4ap4KV95rV9XtLh5VXROM256Ut096IC9YMZ/1JggW dJveUQ== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43f6tffbqq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 13 Dec 2024 11:04:18 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6d887d2f283so4222036d6.0 for ; Fri, 13 Dec 2024 03:04:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734087857; x=1734692657; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zf5tcpszL0I6CSUFS4CayyJ0mUkMjSZvXwP8wY2d3NI=; b=PZgtW7kmus18Ht0SAEpQ5ctNTcWML9YoykGCXX++6NFFH27ukwTs0i+SrtdlIMy+NM 0++wymVB33jyF7ZoGQnZNPXtoJXvijT96SDUJtQ1ALbG/IKC9J+CTrUOwChwSDGyMkIR t5YR4EYHXbd3qlccCqCxMfNHOFAq8v9ShDTLb5NI6uHJh8qzythi/m3HJo90BTtbaPAS 5xs3QNw3qnn9dO69dEmKkN4Tn8avm+c7S+oIM6576sXfIegBLKiN7h1gTpb9SlfaiKp9 kl863JHqtWMvlZkgAocbn5WF2xeGsnANUA3smWMM7djibrgvkw/+SP5ioMO25oj9p6lq h8TA== X-Forwarded-Encrypted: i=1; AJvYcCUtGpsEsa5wF+BOmNuTP1q/2y17X1cPYYXw+asXhsnfrkFhXspS1h0ykJ7suFHeSs4uWvufTTQjmZJZ1N8=@vger.kernel.org X-Gm-Message-State: AOJu0YxAJUSM8kPDFmkuW06o58OgZJW2u+u8SekbCglE6rxxGk35+5Xc 7lPYI4Gi0Ae7Ecxy6m6OaONuvXMSF4UkRgKh6OjUe/2Abt/Li/PJ3S6RB41L58bpVP1D2Ihb2Vs l9XKG5XCyQ+u1+iaLiknTIwguWNPS2So4AhcrFtCMFuAiz92mS/NJzFHLJ28LREc= X-Gm-Gg: ASbGnctDAZig33J4H0mIKWkz+mosIbcEgyJLi9fijgT6PMyf9oTzp7QBkOqtZs17Klc wW0B0QxEdicdSVfSSlEp/8zC8LK1lwmkmJlfgQiLCNAcwrT6VyXxkmPliQTd4losdONNlERukuI kUVTeeauyDVlsejFmbjEoOym3jpvH0a3Gp8mlijJ57YBYllF72tWZRA7SZnhNFMoyegO7cGbsM4 CG98JScwOv8Lc8uXD/jtnwOYSlzbzfw0kG3+ieDTggfPv62OwirIwBhSvYRgWQJzXLCiZx9TGqg e/Ai49dbYjmzOmDl14L8wBEXBbWOMd1fetcv X-Received: by 2002:a05:6214:528d:b0:6d4:1bc2:386c with SMTP id 6a1803df08f44-6dc8ca88c66mr12119886d6.6.1734087857094; Fri, 13 Dec 2024 03:04:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwU07CFAexr1Cwdav3EaM4qqvfC+IfOGzgD65mUO8CZKe+Bc/O5r+o5/bbUyKkdi+zvUmNPA== X-Received: by 2002:a05:6214:528d:b0:6d4:1bc2:386c with SMTP id 6a1803df08f44-6dc8ca88c66mr12119636d6.6.1734087856602; Fri, 13 Dec 2024 03:04:16 -0800 (PST) Received: from [192.168.58.241] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa66f90d5f8sm833016466b.202.2024.12.13.03.04.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Dec 2024 03:04:16 -0800 (PST) Message-ID: <5b5ad9f7-5071-4b4e-940d-aedecf179600@oss.qualcomm.com> Date: Fri, 13 Dec 2024 12:04:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp) To: Pengyu Luo , konrad.dybcio@oss.qualcomm.com, Dmitry Baryshkov Cc: andersson@kernel.org, chenxuecong2009@outlook.com, conor+dt@kernel.org, devicetree@vger.kernel.org, gty0622@gmail.com, johan+linaro@kernel.org, konradybcio@kernel.org, krzk+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org References: <20241213085100.564547-1-mitltlatltl@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241213085100.564547-1-mitltlatltl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: PRsBMyI75Qne1rVAVA8aZqJLkVIepZrF X-Proofpoint-ORIG-GUID: PRsBMyI75Qne1rVAVA8aZqJLkVIepZrF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 phishscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412130076 On 13.12.2024 9:50 AM, Pengyu Luo wrote: > Oh, I sent it by gamil wrongly(forgot cc to), I resend it by git send-email again > > On Fri, Dec 13, 2024 at 1:13 AM Konrad Dybcio wrote: >> On 11.12.2024 4:37 PM, Pengyu Luo wrote: >>> Add an initial devicetree for the Huawei Matebook E Go, which is based on >>> sc8280xp. >>> >>> There are 3 variants, Huawei released first 2 at the same time. >>> Huawei Matebook E Go LTE(sc8180x), codename should be gaokun2. >>> Huawei Matebook E Go(sc8280xp@3.0GHz), codename is gaokun3. >>> Huawei Matebook E Go 2023(sc8280xp@2.69GHz). >>> >>> We add support for the latter two variants. >>> >>> This work started by Tianyu Gao and Xuecong Chen, they made the >>> devicetree based on existing work(i.e. the Lenovo X13s and the >>> Qualcomm CRD), it can boot with framebuffer. >>> >>> Original work: >> https://github.com/matalama80td3l/matebook-e-go-boot-works/blob/main/dts/sc8280xp-huawei-matebook-e-go.dts >>> >>> Later, I got my device, I continue their work. >>> >>> Supported features: >>> - adsp >>> - bluetooth (connect issue) >>> - charge (with a lower power) >>> - framebuffer >>> - gpu >>> - keyboard (via internal USB) >>> - pcie devices (wifi and nvme, no modem) >>> - speakers and microphones >>> - tablet mode switch >>> - touchscreen >>> - usb >>> - volume key and power key >>> >>> Some key features not supported yet: >>> - battery and charger information report (EC driver required) >>> - built-in display (cannot enable backlight yet) >>> - charging thresholds control (EC driver required) >>> - camera >>> - LID switch detection (EC driver required) >>> - USB Type-C altmode (EC driver required) >>> - USB Type-C PD (EC driver required) >> >> Does qcom_battmgr / pmic_glink not work? >> > > Unfortunately, different from many sc8280xp devices, device(PMGK) _STA is > Zero, > this device is quiet strange, also, it has no PM8008, > nor PMIC Battery Miniclass(PMBM), etc. So it's not used on windows.. but have you tried checking if it's still provided by the firwmare? [...] >> >>> + chosen { >>> + #address-cells =3D <2>; >>> + #size-cells =3D <2>; >>> + ranges; >>> + >>> + framebuffer0: framebuffer@c6200000 { >>> + compatible =3D "simple-framebuffer"; >>> + reg =3D <0x0 0xC6200000 0x0 0x02400000>; >>> + width =3D <1600>; >>> + height =3D <2560>; >>> + stride =3D <(1600 * 4)>; >>> + format =3D "a8r8g8b8"; >>> + }; >>> + }; >> >> This should be redundant, as you should have efifb >> > > I think no, it won't boot up without it(stuck at EFI stub: Booting Linux > Kernel) Do you have CONFIG_EFI and CONFIG_FB_EFI enabled? (also, your email client does something funny and posts 0x3d, which is ASCII for '=' after that symbol) > > [...] > >> >>> + >>> + wcd938x: audio-codec { >>> + compatible =3D "qcom,wcd9380-codec"; >>> + >>> + pinctrl-names =3D "default"; >>> + pinctrl-0 =3D <&wcd_default>; >> >> Please follow this order throughout the file: >> >> property-n >> property-names >> > > Do you mean I should arragne as following? If so, I actually keep > reference devicetree untouched. x13s and crd are written like this. Yeah, we try to unify the style as we progress and we still haven't gotten around to cleaning up files that have been in the tree for years.. > > pinctrl-0 =3D <&wcd_default>>; > pinctrl-names =3D "default"; Yes please [...] >>> + gpio-keys { >>> + compatible =3D "gpio-keys"; >>> + >>> + pinctrl-names =3D "default"; >>> + pinctrl-0 =3D <&mode_pin_active>, <&vol_up_n>; >>> + >>> + switch-mode { >>> + gpios =3D <&tlmm 26 GPIO_ACTIVE_HIGH>; >> >> This could use a label too - "Tablet Mode Switch", perhaps? >> > > This part I follow Lenovo Yoga C630 one (see [1]), it doesn't use it, > and this node is not referenced. So "label" could mean label: node-name@unit-address { property = "value"; }; when talking about DT nodes, but here I'm speaking of the "label" property (which you set to "Volume Up" in the node below). That is read by Linux and provides a nice human-readable name to the userspace. >> >>> + >>> + /* /lib/firmware/ath11k/WCN6855/hw2.1/board-2.bin >>> + * there is no calibrate data for huawei, >>> + * but they have the same subsystem-device id >>> + */ >>> + qcom,ath11k-calibration-variant =3D "LE_X13S"; >> >> Oh, this can be taken care of! See [2], [3]. >> > > I have a glance, now I know we should extract something or it won't be > there. > Question is how can I extract them? I have a quick search, got no luck. > As for windows drivers, in the folder > > bdwlan.e02 > bdwlan.e07 > bdwlan.e1d > bdwlan.e1e > bdwlan.e23 > bdwlan.e26 > bdwlan.e32 > bdwlan.e47 > bdwlan.e81 > bdwlan.e84 > bdwlan.e85 > bdwlan.e8c > bdwlan.e8e > bdwlan.e9f > bdwlan.ea3 > bdwlan.eb8 > bdwlan.elf > bdwlan.elf.g > bdwlang.e8b > bdwlang.e9f > bdwlang.ea3 > bdwlang.eb8 > bdwlang.elf > Data20.msc > Data.msc > m320.bin > m3.bin > qcwlan8280.cat > qcwlan8280.inf > qcwlan8280.sys > regdb.bin > wlanfw20.mbn > wlanfw.mbn Adding Dmitry who has gone through this multiple times and may be able to help Konrad