From: Raju P L S S S N <rplsssn@codeaurora.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>,
Evan Green <evgreen@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Lina Iyer <ilina@codeaurora.org>
Subject: Re: [PATCH] arm64: dts: sdm845: Add PSCI cpuidle low power states
Date: Tue, 30 Oct 2018 21:53:55 +0530 [thread overview]
Message-ID: <5b62572d-9f45-c0ee-776e-1486a9d40862@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=XB9diR_n1TB4+wUjVaRf0VAmCMgkSbtuOSNO5pkrQ8zg@mail.gmail.com>
On 10/24/2018 12:06 AM, Doug Anderson wrote:
> Hi,
>
> On Mon, Oct 15, 2018 at 10:02 AM Raju P.L.S.S.S.N
> <rplsssn@codeaurora.org> wrote:
>> + idle-states {
>> + entry-method = "psci";
>> +
>> + C0_CPU_SPC: c0_spc {
>
> nit: all these nodes should have dashes instead of spaces in the node
> names (labels can still have spaces). AKA:
>
> C0_CPU_SPC: c0-spc {
Sure. I will change this. (However, from device tree specification v0.2,
I see that Table 2.1 mentions underscore as valid character for node.
Please correct me if I'm missing something)
>
>
>> + compatible = "arm,idle-state";
>> + arm,psci-suspend-param = <0x40000003>;
>> + entry-latency-us = <350>;
>> + exit-latency-us = <461>;
>> + min-residency-us = <1890>;
>> + local-timer-stop;
>> + idle-state-name = "pc";
>
> It seems weird that the idle state with the node name "spc" has the
> name "pc" and the idle state with the node name "pc" has the name
> "rail pc". Can this be more consistent or is there a reason why they
> need to be mismatched?
Agree. They are confusing. Will change this.
>
> Also: AAHTUFSWDKWTM (acronyms are hard to understand for someone who
> doesn't know what they mean). If you really need to use an the
> acronyms "PC" and "SPC" please document them somewhere. In the very
> least the commit message, but having a comment in the file is good
> too. ...or (even better) don't use the acronym and spell out what
> you're talking about. Please correct me if I'm wrong, but I don't
> think it's obvious what the "PC" and "SPC" idle states mean.
Sure. Will change this.
Thanks for feedback Doug.
>
>
> -Doug
>
next prev parent reply other threads:[~2018-10-30 16:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 17:02 Raju P.L.S.S.S.N
2018-10-19 19:48 ` Lina Iyer
2018-10-22 18:34 ` Evan Green
2018-10-23 18:36 ` Doug Anderson
2018-10-30 16:23 ` Raju P L S S S N [this message]
2018-10-30 16:52 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b62572d-9f45-c0ee-776e-1486a9d40862@codeaurora.org \
--to=rplsssn@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome