From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE66B284689 for ; Mon, 26 Jan 2026 16:20:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769444427; cv=none; b=uzG7ykpzouZKU5nN5noaJqtslxSkirWGJ5tZy5GAS9soXcOZlHwGulWIibsxlVIHlGxa3ENvCQF4f+X7gy+8AWXk3AwTyLwp+BVYwUP/75mKEmJp0E5CBa18CSU9iQQIqlkrTaO52fyGrqA4Skc6jj1oktiRkwekNSlLC287dSQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769444427; c=relaxed/simple; bh=/smmK47PbQdFJDsC3KMabDwT9Chn1G7CNVgPaLL8ero=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RNcV/dguDIvh9Fk4SW8IXVIv0Q58J1P/2DL1YhfeIJEfQIf8uGREfhM2661bIkaZ5YbXWDHsj57cqKYkfuIeN2jUdShQ3fXBoR7VbhxqwqOSD4NxDqP60kqO/1C/N4TzTw3ayDjXzTTpwBRW7Id7dKKTLaf4cf1js2YW4s/1PxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UqPBRpPW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Tu0Bdt9E; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UqPBRpPW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Tu0Bdt9E" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60QE0iQe1361590 for ; Mon, 26 Jan 2026 16:20:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= R9oU0cU0iS8ibF/AIo3DwOSofwYBcrbGsmjI9pc38KA=; b=UqPBRpPW8XGQt49x 4nIs/1BBmM+U2ngGKmcePq9aSkKRk7VPXclXdEol5IVW+gvLlx7uXFBOHS8wyBTR QZ+2qCboj50YCXLxLzfxnlEGQO03jeO+x5cNC5FAIcPmdMcX5/kASXmXwL337y2h FxjsxU83dNqB9bskqKoBLHHrn85AwjhZlDzGCXRHCXaX58afrKwnY3GjUUZXfmN/ uNBbukNw4AqOhU6wpyVE9PjXgJudtHmWPUnotKyu6yZGYxjMGUHMZMITdCQtdtJD Q6lwAxgCLfcIhZR88iM7qx578wcGtkW4SC8tzI7KYnEs0tMPLU1WL8U2s/8WFH3h 9buUSg== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bx0v31syx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 26 Jan 2026 16:20:25 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2b704019c98so4709606eec.0 for ; Mon, 26 Jan 2026 08:20:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769444424; x=1770049224; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R9oU0cU0iS8ibF/AIo3DwOSofwYBcrbGsmjI9pc38KA=; b=Tu0Bdt9E6yKeT87v5arFoTDV9+E8bKKJIfsOf5FAIycu01MqXyvgtq/6LyweYkQTH9 TO/ysLkdliNEslpSxbJN0G/RDyhVpq5A8baQEOfMlJWU644+Id597YFIHGWhENkXrjxv GU9GGEKbsMKjfc33I8cs+TwgUwWb01kXbYkog8MduhA3VX5RdlcEIODdIQoQn1sb+qfA fGIvCETeMXhGU6E/ymqgk8KTwAfbkVBS7OsV/I6Ugo85ZeJOqJWBMRApBD+Q5nknoOJP bL3pBCto7Kq/kAimllYnQdWgOTBcZKczGaUGRRU3x3crbpgxmd2ZVw97jBhxxbg+0/1M 4Mvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769444424; x=1770049224; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R9oU0cU0iS8ibF/AIo3DwOSofwYBcrbGsmjI9pc38KA=; b=rX7dkxfOccCr2k81oBkSLSW7+GQwJf2SO/NhzKklA8WOlosRuAt9I2rItC7f2F7swt nURuuHkWpXtw09IONgsPFY9UIeYgLsEYFU12M1ztvs7kKP8SG8l1+fO9k/WQqcCmpIUD 1OhgXU6dagc9lmmr+Z1fiSjob0iA2VWb7pXWrgmvr6hIPcyGUWKWcmqzlCyUeAjQISf3 r8VPY8w2Z5WtoS11nQeMcKtjUnazxC8Jei0XFAHBLHp1VNF1Eo5NuUSa4lCsBJ80WcQb PKSXPO1xmBhEiJ12H6latjO36zMMEcEdIGOp7izzrsbXNJOfyYnTUE98SxT4Kq5c69Yd 2cuw== X-Forwarded-Encrypted: i=1; AJvYcCU3xMySJ3uhE65/eCOVjxDD66MpREE2mzP3u9z3wRGENn4Je/sOaVoaKOakyIaEWtsxGWiCvh2e8iDqLb4=@vger.kernel.org X-Gm-Message-State: AOJu0YzogJzuiliMT2JrMKbtQMREIHyWzqZFm0NQlQd1zFYg1lqu6ovS 8d96M3Eu078h1QOqu0RwnbzanZEWG0RGHrwv+pkoVAtHYvdTBWDEgnWyhaJREQNUd4ZA4uBqhK/ hTmFpfR7HlIWGmw/O3Fm3ByOK0zZ+BfpKCbtr2tQ7CbjGprXlk7ZuFC6LLKnqh2sJi18= X-Gm-Gg: AZuq6aJRpPAoL9NYWBdQLNRSygSoUaAi+RHk7RWWe3cHOtIGVMRH2oE/QsovF3v/hZJ 9g3Mvk4oE+p+6QeQWGFZuMlpLVFXlUJw27WzYwY6y+fa1EmkGqYSNuvaSPOcdUkc6fch3DWAdaV zYi4bn85X7SA3QXaFPqBWviH71FybqhI9f5TASD/mqYYYyqq6BtP7+d617KGLJeP3NHYmanUYff l4su0wpUgoOzSuxzkv//6NicKgGiBJyxREK6UbO9jZUrq98+RgjvCBdHOJd8UCYpcZaV7VJeQ0+ ODY0oNXc1I/shNaKyJRF2NnP3p4VVED8G2hLJcmnAj7LobQEiGCGdFMyfc5CL4A8XZ/0lL964qX I+vVk39ZvyUb2p0kIVM1MN8FFa4BpW9YaPL90mC7ZbhcxhXpmd267cJl9p5ckUhU= X-Received: by 2002:a05:7301:3d0a:b0:2ae:55f0:f2be with SMTP id 5a478bee46e88-2b764525c08mr2618049eec.31.1769444424180; Mon, 26 Jan 2026 08:20:24 -0800 (PST) X-Received: by 2002:a05:7301:3d0a:b0:2ae:55f0:f2be with SMTP id 5a478bee46e88-2b764525c08mr2618024eec.31.1769444423478; Mon, 26 Jan 2026 08:20:23 -0800 (PST) Received: from [10.110.37.82] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b73aa08964sm13801267eec.28.2026.01.26.08.20.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 08:20:22 -0800 (PST) Message-ID: <5b62b672-d6fe-42e1-bf31-15ec16ed7d3d@oss.qualcomm.com> Date: Tue, 27 Jan 2026 00:20:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] Bluetooth: hci_qca: Refactor HFP hardware offload capability handling To: Dmitry Baryshkov Cc: Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, shuai.zhang@oss.qualcomm.com, cheng.jiang@oss.qualcomm.com, chezhou@qti.qualcomm.com, wei.deng@oss.qualcomm.com, yiboz@qti.qualcomm.com References: <20260123055243.2634107-1-mengshi.wu@oss.qualcomm.com> <20260123055243.2634107-2-mengshi.wu@oss.qualcomm.com> Content-Language: en-US From: Mengshi Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI2MDEzNiBTYWx0ZWRfX+jw2Gz1RBdP/ CVGrSdaRxJOt59N7bdmMw3nJZjTnkrqbHbAZuj1raCnV5MRRuuht1p16jaR1nOdQKm9vJrAFZmf ykbM7OK+Ecb/63JrlZtpMmGXS23Mj9UwguC8aEwVA7Hy5R9wKW125MWDYpF1QyP6tfhMFEWig4M Plahjjxkcp4okSGgKryzGSpoSUzvFMF3T9y+RshCXlqdWkrJ7tuW8P1g5v2QJ2aCQe13NV98zye elnYTQWe92NTE6Bzki1/W/iY179pa0SILXbKl7w8jw8KbYORNVh3LJ6x1MF/3JQnyWM9G6KDNOy 6Vv/LmLsYf757hI3F314zruezw541yATB2rtIDbOcM/xPBkJhpesKYyLeIzD9SOYnBWtznnnSoJ ISIrFmkyE6tMKM40L74nSY2ZlpMu/Uc2w9jGBBzuJECoU4rSJVt0iY4UY87jex6nsg8SEyH5AUT wbfR/rW+dqA/XMdx9pA== X-Proofpoint-GUID: cy1s5EF8679iCnh8UAHf7YBu98DKWlEw X-Proofpoint-ORIG-GUID: cy1s5EF8679iCnh8UAHf7YBu98DKWlEw X-Authority-Analysis: v=2.4 cv=JYyxbEKV c=1 sm=1 tr=0 ts=69779449 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=lmeFXj1VSAwbam4jTmcA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-26_03,2026-01-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601260136 Hi, On 1/24/2026 3:26 AM, Dmitry Baryshkov wrote: > On Fri, Jan 23, 2026 at 01:52:42PM +0800, Mengshi Wu wrote: >> Replace SoC-specific check with capability-based approach for HFP >> hardware offload configuration. Add QCA_CAP_HFP_HW_OFFLOAD capability >> flag and support_hfp_hw_offload field to qca_serdev structure. >> >> Signed-off-by: Mengshi Wu >> --- >> drivers/bluetooth/hci_qca.c | 10 +++++++--- >> 1 file changed, 7 insertions(+), 3 deletions(-) >> >> @@ -2033,7 +2034,7 @@ static int qca_setup(struct hci_uart *hu) >> else >> hu->hdev->set_bdaddr = qca_set_bdaddr; >> >> - if (soc_type == QCA_QCA2066) >> + if (qcadev->support_hfp_hw_offload) > > At this point QCA2066 becomes broken until the next commit. This is not > a proper way to do things. At the very least, squash the first chunk of > your next commit into this patch. Thanks for comments. I will fix this. > >> qca_configure_hfp_offload(hdev); >> >> qca->fw_version = le16_to_cpu(ver.patch_ver); >> @@ -2502,6 +2503,9 @@ static int qca_serdev_probe(struct serdev_device *serdev) >> >> if (!(data->capabilities & QCA_CAP_VALID_LE_STATES)) >> hci_set_quirk(hdev, HCI_QUIRK_BROKEN_LE_STATES); >> + >> + if (data->capabilities & QCA_CAP_HFP_HW_OFFLOAD) >> + qcadev->support_hfp_hw_offload = true; >> } >> >> return 0; >> -- >> 2.34.1 >> > -- Best regards, Mengshi Wu