From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "yilun.xu@linux.intel.com" <yilun.xu@linux.intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"kas@kernel.org" <kas@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Xu, Yilun" <yilun.xu@intel.com>,
"tony.lindgren@linux.intel.com" <tony.lindgren@linux.intel.com>,
"artem.bityutskiy@linux.intel.com"
<artem.bityutskiy@linux.intel.com>,
"nik.borisov@suse.com" <nik.borisov@suse.com>,
"Mehta, Sohil" <sohil.mehta@intel.com>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
"Gao, Chao" <chao.gao@intel.com>,
"Fang, Peter" <peter.fang@intel.com>,
"Maloor, Kishen" <kishen.maloor@intel.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v2 3/5] x86/virt/tdx: Detect if the extensions initialization is required
Date: Tue, 29 Sep 2026 16:33:42 +0000 [thread overview]
Message-ID: <5b64c44c06a416d1f38e33639923d1b09f14d561.camel@intel.com> (raw)
In-Reply-To: <aruEyEetjbruotXB@yilunxu-OptiPlex-7050>
On Tue, 2026-09-29 at 17:28 +0800, Xu Yilun wrote:
> Another thing is about the addon_features0 argument for TDH.SYS.UPDATE.
> In v1 -> v2, in order to meet the goal of "just restore everything that
> was configured during boot", this bitmap argument is removed. I think
> this argument removal is orthogonal to the TDH.EXT.INIT discussion and
> still has merit.
>
> TDH.SYS.UPDATE(v0): TDX module reconfigures same features as specified by
> TDH.SYS.CONFIG, Linux would use this SEAMCALL version.
>
> TDH.SYS.UPDATE(v1, addon_featues0): VMM can configure new features specified
> by addon_features0 argument. For other
> VMM.
>
> Then we can just add one patch based on v2 series:
Yea that seems like a good way to do this.
Some of the nuance that was extracted was that there is a difference between
update and changing configuration. For example TDH.QUOTE.INIT was considered
reconfiguration because it generates a new key. Similarly, changing which add-
ons are enabled seems like reconfiguration. So it could be a separate knob.
Let's follow up internally with the TDX folks to clarify that we don't want to
pass addon bits into update. And see if anyone yells. I'm not sure the previous
discussion covered this case.
next prev parent reply other threads:[~2026-09-29 16:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 10:26 [PATCH v2 0/5] Enable TDX module extensions Xu Yilun
2026-09-15 10:26 ` [PATCH v2 1/5] x86/virt/tdx: Move TDH.SYS.CONFIG operations into a wrapper Xu Yilun
2026-09-15 20:45 ` Edgecombe, Rick P
2026-09-18 9:54 ` Xu Yilun
2026-09-22 7:09 ` Tony Lindgren
2026-09-15 10:26 ` [PATCH v2 2/5] x86/virt/tdx: Configure add-on features on TDX module init Xu Yilun
2026-09-15 20:54 ` Edgecombe, Rick P
2026-09-21 11:42 ` Xu Yilun
2026-09-22 14:48 ` Edgecombe, Rick P
2026-09-24 1:51 ` Xu Yilun
2026-09-16 3:23 ` Chao Gao
2026-09-18 9:56 ` Xu Yilun
2026-09-22 7:13 ` Tony Lindgren
2026-09-23 7:30 ` Xu Yilun
2026-09-23 7:59 ` Tony Lindgren
2026-09-24 1:33 ` Xu Yilun
2026-09-24 6:22 ` Tony Lindgren
2026-09-25 14:12 ` Nikolay Borisov
2026-09-15 10:26 ` [PATCH v2 3/5] x86/virt/tdx: Detect if the extensions initialization is required Xu Yilun
2026-09-15 21:14 ` Edgecombe, Rick P
2026-09-18 9:58 ` Xu Yilun
2026-09-28 21:06 ` Edgecombe, Rick P
2026-09-29 9:28 ` Xu Yilun
2026-09-29 16:33 ` Edgecombe, Rick P [this message]
2026-09-29 17:26 ` Nikolay Borisov
2026-09-15 10:26 ` [PATCH v2 4/5] x86/virt/tdx: Add extra memory to TDX module for the extensions Xu Yilun
2026-09-15 21:19 ` Edgecombe, Rick P
2026-09-16 7:40 ` Chao Gao
2026-09-18 10:06 ` Xu Yilun
2026-09-22 7:25 ` Tony Lindgren
2026-09-15 10:26 ` [PATCH v2 5/5] x86/virt/tdx: Make TDX module initialize " Xu Yilun
2026-09-15 22:09 ` [PATCH v2 0/5] Enable TDX module extensions Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b64c44c06a416d1f38e33639923d1b09f14d561.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=adrian.hunter@intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=kas@kernel.org \
--cc=kishen.maloor@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=peter.fang@intel.com \
--cc=sohil.mehta@intel.com \
--cc=tony.lindgren@linux.intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®