From: Pavel Begunkov <asml.silence@gmail.com>
To: Junyuan Feng <a@lollipopkit.com>, axboe@kernel.dk
Cc: dw@davidwei.uk, io-uring@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] io_uring/zcrx: requeue multishot receives stopped by a local resource
Date: Sun, 27 Sep 2026 20:03:34 +0100 [thread overview]
Message-ID: <5b65f83b-d30b-414c-bb71-197f72feb367@gmail.com> (raw)
In-Reply-To: <010001a0cd914529-23df2f94-bbe0-49cd-ae5d-05922356fa12-000000@email.amazonses.com>
On 9/23/26 10:20, Junyuan Feng wrote:
> A multishot RECV_ZC can go idle with unread TCP data when a receiver-local
> resource runs out. An empty copy-fallback niov freelist returns -ENOMEM;
> a full CQ returns -ENOSPC. After partial progress the stop reason is
> lost: io_zcrx_copy_chunk() and io_zcrx_recv_skb() report the copied
> bytes, and tcp_read_sock() drops an error from a later call once earlier
> data was consumed. The edge-triggered request is then not requeued, so
> it cannot consume the remaining data until another socket event arrives.
>
> Record in io_zcrx_recv_skb() when a walk stops before consuming the
> length it was offered, and requeue if the pass still returned data. The
> failed chunk is first on the next pass. The resource is usually still
> exhausted by then, so that pass fails at once and ends the request with
> an error CQE, which the application must handle by re-arming. The
> request does not spin, and the stall becomes a visible error. Keep the
> existing skb limit and SOCK_DONE handling.
Looks good
Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>
--
Pavel Begunkov
next prev parent reply other threads:[~2026-09-27 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 9:20 Junyuan Feng
2026-09-27 19:03 ` Pavel Begunkov [this message]
2026-09-28 14:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b65f83b-d30b-414c-bb71-197f72feb367@gmail.com \
--to=asml.silence@gmail.com \
--cc=a@lollipopkit.com \
--cc=axboe@kernel.dk \
--cc=dw@davidwei.uk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®