From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 793C0C433F5 for ; Sat, 7 May 2022 13:09:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385121AbiEGNNR (ORCPT ); Sat, 7 May 2022 09:13:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234881AbiEGNNO (ORCPT ); Sat, 7 May 2022 09:13:14 -0400 Received: from mail-m17669.qiye.163.com (mail-m17669.qiye.163.com [59.111.176.69]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE83913CE8 for ; Sat, 7 May 2022 06:09:27 -0700 (PDT) Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m17669.qiye.163.com (Hmail) with ESMTPA id 826EC46006D; Sat, 7 May 2022 21:09:25 +0800 (CST) Message-ID: <5b697caa-c8ff-9f10-baa0-4d3e1a644a5f@rock-chips.com> Date: Sat, 7 May 2022 21:09:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 -next] drm/rockchip: Fix Kconfig dependencies Content-Language: en-US To: Ren Zhijie , hjc@rock-chips.com, heiko@sntech.de, airlied@linux.ie, daniel@ffwll.ch, lyude@redhat.com, tzimmermann@suse.de Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220507100910.93705-1-renzhijie2@huawei.com> From: Andy Yan In-Reply-To: <20220507100910.93705-1-renzhijie2@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRkaT0pWSkxNTB0eHk tPGUJKVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Ni46Njo5SD0xPg0zH0IsSR0q ShkaFE9VSlVKTU5KQklDQk1NS01LVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBSEJDTjcG X-HM-Tid: 0a809ea3a29cda59kuws826ec46006d Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Zhijie: On 5/7/22 18:09, Ren Zhijie wrote: > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_connector_mode_valid': > cdn-dp-core.c:(.text+0x1e1): undefined reference to `drm_dp_bw_code_to_link_rate' > cdn-dp-core.c:(.text+0x1f4): undefined reference to `drm_dp_bw_code_to_link_rate' > drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_pd_event_work': > cdn-dp-core.c:(.text+0x138e): undefined reference to `drm_dp_channel_eq_ok' > drivers/gpu/drm/rockchip/cdn-dp-reg.o: In function `cdn_dp_train_link': > cdn-dp-reg.c:(.text+0xd5a): undefined reference to `drm_dp_bw_code_to_link_rate' > > The DP-helper module has been replaced by the display-helper module. > So the driver have to select it. > > Reported-by: Hulk Robot > Fixes: 1e0f66420b13("drm/display: Introduce a DRM display-helper module") > Signed-off-by: Ren Zhijie Thanks. Reviewed-by: Andy Yan > --- > v2: remove "select DRM_DISPLAY_HELPER if ROCKCHIP_ANALOGIX_DP" under DRM_ROCKCHIP at the head, > and separately add the select for ROCKCHIP_ANALOGIX_DP and ROCKCHIP_CDN_DP, which Andy suggested. > --- > --- > drivers/gpu/drm/rockchip/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > index 5afab49dc4f2..53c2d9980d48 100644 > --- a/drivers/gpu/drm/rockchip/Kconfig > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -2,7 +2,6 @@ > config DRM_ROCKCHIP > tristate "DRM Support for Rockchip" > depends on DRM && ROCKCHIP_IOMMU > - select DRM_DISPLAY_HELPER if ROCKCHIP_ANALOGIX_DP > select DRM_GEM_CMA_HELPER > select DRM_KMS_HELPER > select DRM_PANEL > @@ -38,6 +37,7 @@ config ROCKCHIP_VOP2 > config ROCKCHIP_ANALOGIX_DP > bool "Rockchip specific extensions for Analogix DP driver" > depends on ROCKCHIP_VOP > + select DRM_DISPLAY_HELPER > select DRM_DISPLAY_DP_HELPER > help > This selects support for Rockchip SoC specific extensions > @@ -47,6 +47,8 @@ config ROCKCHIP_ANALOGIX_DP > config ROCKCHIP_CDN_DP > bool "Rockchip cdn DP" > depends on EXTCON=y || (EXTCON=m && DRM_ROCKCHIP=m) > + select DRM_DISPLAY_HELPER > + select DRM_DISPLAY_DP_HELPER > help > This selects support for Rockchip SoC specific extensions > for the cdn DP driver. If you want to enable Dp on