From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751981AbdKVQsa (ORCPT ); Wed, 22 Nov 2017 11:48:30 -0500 Received: from mout.web.de ([212.227.17.12]:55520 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbdKVQs2 (ORCPT ); Wed, 22 Nov 2017 11:48:28 -0500 To: alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] ALSA: gus: Delete an error message for a failed memory allocation in snd_gf1_dma_transfer_block() Message-ID: <5b6cc700-01d2-92ea-c9b4-75e8a93a05bf@users.sourceforge.net> Date: Wed, 22 Nov 2017 17:47:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:lURGERZ/DyCLgFmU2SO4cP/OmuX9enmOyIVXi6oNnmJpBLL2lYX I10LcHNgFRNXi7RHBgzdQqtNyB3TSm9n6hSo31LCy6J9mG4iVACGfF/OMz+nMlu6xhMfvDj 8hcztSymw1Ha6JF/iT6xeiLxamwDyBdnDvOkTR0OlPbAubV0QseJCSMhZYcs3rveu3Ga8+b 7+JZzoStUexsMvkrMkgCg== X-UI-Out-Filterresults: notjunk:1;V01:K0:JpVnqU4grys=:J6dTvW0Ec4L0hRUMJJ2saM 3AwVCzyiJ48svKX+UIJG5g7yieU1XxrsvEZiIdEcnBzKcApRNep8mz5tkLRo2cAXITB0stXbN 8QAE1muICRbSskN5s1kTcSSd88dGhrK92mTcMUuCVTP/CAXmCIbJPUZXxlnMI0r60TtDh32hj vWquvPpwuuyWZNpCkpl4oYXVF1s2fgTHdROAWsdtnUm1cJnnhoZaB/MgCrGom/DCstMhz5pav vVrs3yFProverHhbwWXdirqorcewYX9ccsMkUPdU3F6AGprz/V6OzRI6Yb01kHUtOAJwzd5wa SKIIIACdzPzaESrEt3XFU+QllIcABrdDro/2glk3KLOZL4V7Q0X4oIDgU2gFcd2aAS33Dov4t PuK15IIvDZyeYOvOuSDvHtBnKXUQGmj2MiNDyUfeiaE233qep100ShPQFu2a5gt59LFOStX8B 0U+AydKfnmUnelrOqYpgiOD/Gj9qRaLpDI778PiM6w5ALdr7IDRfJZwoqdpXJUqNSXMQl3tOO nKrtyTO64FI0SMN0gc/aDyB1rEFkr/XDr2/PJAz8bQ+xdO/l5qkq6axoxKtzfpqc0y3mtwVGz mTtECSSq2qlW+7zQHK0fiwgBiYwKWH7s+byBwxXyAX90jwRX/uFllK+9SGPxqC0qIHSVcqZTp ya7DJ7rsVXXJaJQjGOtvUfxP+nLQt71UvRFEiUHvUBtgrgmn5HcWVLVXRKZlq+EvRuuTCtSD1 lZsuJtT85kOS0BdkgHWjLHswa1XEJf+2p1YRMblTscuwlD1NV+n3Cozc66QhxRSHa3Hoht76M FA23y+lPAq8TRkKFRzKb0nS4XnG/3sen+qVVMx0+4WaqHmIIFc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 22 Nov 2017 17:43:25 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/isa/gus/gus_dma.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/isa/gus/gus_dma.c b/sound/isa/gus/gus_dma.c index 36c27c832360..7f95f452f106 100644 --- a/sound/isa/gus/gus_dma.c +++ b/sound/isa/gus/gus_dma.c @@ -201,10 +201,9 @@ int snd_gf1_dma_transfer_block(struct snd_gus_card * gus, struct snd_gf1_dma_block *block; block = kmalloc(sizeof(*block), atomic ? GFP_ATOMIC : GFP_KERNEL); - if (block == NULL) { - snd_printk(KERN_ERR "gf1: DMA transfer failure; not enough memory\n"); + if (!block) return -ENOMEM; - } + *block = *__block; block->next = NULL; -- 2.15.0