From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794491880; b=h/zmsqVq3hqfscBsaAkn1+cxNW9OtQ3iokHXTikwvNvpo28N9rUGJyyJWF1a4HWCveCg 3fkwapT2h2A/IMUZ9tY1n9cBlS4+CnbPKDTdJIHgmJuS5+E2qeoY8SWFhfIDBJysQYgxz /W3ESpvxl/d84T7fcvVRmIOz94+G0cxmjH72FxmkILcf7TvqNT1zdfshYAlpq4ogrLIZ6 Ids4LfqarCHHC5Zu3E1Mbfx33o6ooA554L5Glji4kChsjW3IBEetmCDv74EFpN64OtRui 1bKARqnMSqYUXGP7YsamoRFmqpuQqKJFD84OEWPoDKei6YBJx8rUyqtQkLf1XPMbu6Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794491880; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=yak9hGU29D54icS2qtu7SQxombPVl0L5uftxiR+otEE=; b=Swg2pH4NLZJXoJT/eeAwm58J5ja2hslchwiJYxVloYCqj/h0EWOcE80Y2Nz1L2fmLKd4 pVxkoQ4Caa+1Ewx9zqA4iR7Lkd8k/30GPZxgJE8KHIzGZdxanz/QkD34JiJLbi6UNja+j phPLjCm8XXQcSDTNZDRLnjcCfGWeI7uaYe0lDlhPKjae/b+jtguVA86COi/6rza9Yhjq5 18dw0zwWC9vnNYR7oh0tcjJMeFcB/VQQseK/Jtg8xhViAxMCBTzzIlQ61wlPPqJuYORHm ysmU1q9FXX6Lqbs4yfWF0DB9WFyZUHrS/x1GmCavwgwC/542PlYUGuIcMMEPyDVpwNg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=K6w2bhD8; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64300606A897; Thu, 12 Nov 2026 13:58:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=K6w2bhD8 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 270BA1F00A05; Thu, 12 Nov 2026 13:57:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794491880; bh=yak9hGU29D54icS2qtu7SQxombPVl0L5uftxiR+otEE=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=K6w2bhD8xXtgzzjdd2Yv+audpf4dLMI2LcBq9u9MjnIbT/qUxM/Bt/906Udu8/1EI qmxqaqx1+0O1Fr11iWgQUiRoJjz5fYWFyhfzwJcyo6CCuqNhjYKQ+hHO4IcqfOo+HX 3QU4ywZzBBfGirVygm+Gfe7v082M5pWI/rY66mT+gyVmJbWLCq56aVs14MON0k1bvj v41Ct4kk54keks/DcYKG7JLt1uuMP9FSxJ+ebeXuR56dyhUnfTNaVx+pywXPJqFmAp 8ZQMVPh53+4i20j4pvLHzn8M24f8tX8K46Iv/85o1ZZwHXxZjuq3y3WzPmv3dWx1sg lcgloJVdnCjYw== Message-ID: <5b6e4031-4c52-4b67-82c2-0033d13b15d6@kernel.org> Date: Thu, 12 Nov 2026 14:57:53 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] dt-bindings: dma: qcom-gpi: Add QSPI protocol identifier To: Jyothi Kumar Seerapu Cc: Mark Brown , Vinod Koul , Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org References: <20261106-qspi_upstream_series-v1-0-21f43042dd60@oss.qualcomm.com> <20261106-qspi_upstream_series-v1-2-21f43042dd60@oss.qualcomm.com> <20261109-wandering-miraculous-mamba-0cf21a@quoll> <2fc8f7ea-651e-466e-9346-c47e0a38c5bb@oss.qualcomm.com> <20261111-daring-salamander-from-tartarus-4c72bd@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/11/2026 14:47, Jyothi Kumar Seerapu wrote: > > > On 11/11/2026 6:07 PM, Krzysztof Kozlowski wrote: >> On Mon, Nov 09, 2026 at 08:03:29PM +0530, Jyothi Kumar Seerapu wrote: >>> >>> >>> On 11/9/2026 7:12 PM, Krzysztof Kozlowski wrote: >>>> On Fri, Nov 06, 2026 at 08:31:20PM +0530, Jyothi Kumar Seerapu wrote: >>>>> Add QCOM_GPI_QSPI to identify QSPI (Quad SPI) channels in GPI DMA >>>>> specifiers. Its value, 9, matches the GENI serial engine firmware >>>>> protocol ID for QSPI. >>>> >>>> What is GENI serial engine firmware? How does the Linux rely on it that >>>> we add bindings for it? >>> >>> Hi Krzysztof, >>> GENI firmware runs on the serial engine’s programmable sequencers and >>> implements protocols such as SPI and QSPI. Linux configures the engine and >>> submits transfers to it. >>> The existing GPI DMA specifier includes a client protocol ID. Linux programs >>> this ID into the DMA channel and selects the corresponding descriptor >>> format. QCOM_GPI_QSPI adds the QSPI protocol encoding 9 to that interface. >>> I will clarify this in the commit description in V2. >> >> Does not really answer. I see no reason why GENI firmware needs ABI for >> Linux. >> > This extends the existing GPI DMA binding, not a GENI firmware ABI. OK, so it is not ABI for the firmware. Period. Let's stop discussing this. > > The third argument of the DMA specifier in the dmas property selects > the peripheral protocol. The GPI driver programs this value into the Yes, so the third argument can be value of 6 because it has no meaning for the firmware. Again, follow standard DT bindings ABI rules, you don't get an exception. Best regards, Krzysztof