From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, cocci@systeme.lip6.fr
Cc: Wen Yang <wen.yang99@zte.com.cn>,
linux-kernel@vger.kernel.org, Yi Wang <wang.yi59@zte.com.cn>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <michal.lkml@markovi.net>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [v2] coccinelle: semantic code search for missing of_node_put
Date: Sat, 29 Jun 2019 10:35:56 +0200 [thread overview]
Message-ID: <5b75be65-a205-ecd6-8424-e0b3384b21b1@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1906290947470.2579@hadrien>
>>>> +if (x == NULL || ...) S
>>>> +... when != e = (T)x
>>>> + when != true x == NULL
…
> I assume that it was added because it was found to be useful.
We can get different software development opinions also on
this implementation detail.
> Please actually try things out before declaring them to be useless.
Further clarification of desirable software behaviour will help.
I dare to express doubts around the SmPL functionality “when != true x == NULL”.
Would any more contributors like to share additional insights for the safer
application of the semantic patch language?
Is a reassignment of such local variable an usual precondition for
the discussed programming concern?
Regards,
Markus
next prev parent reply other threads:[~2019-06-29 8:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 2:58 [PATCH v2] " Wen Yang
2019-06-28 9:38 ` Markus Elfring
2019-06-28 11:07 ` Julia Lawall
2019-06-28 14:16 ` [v2] " Markus Elfring
2019-06-28 14:16 ` Markus Elfring
2019-06-29 7:40 ` Markus Elfring
2019-06-29 7:49 ` Julia Lawall
2019-06-29 8:35 ` Markus Elfring [this message]
2019-06-29 19:30 ` [v2] Coccinelle: Testing SmPL constraints Markus Elfring
[not found] <201907041041053843118@zte.com.cn>
2019-07-04 5:40 ` [v2] coccinelle: semantic code search for missing of_node_put Markus Elfring
[not found] <201907041103003504524@zte.com.cn>
2019-07-04 6:28 ` Markus Elfring
[not found] <201907051357245235750@zte.com.cn>
2019-07-05 6:17 ` [PATCH v2] coccinelle: semantic code search formissingof_node_put Julia Lawall
2019-07-05 6:45 ` [v2] coccinelle: semantic code search for missing of_node_put Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b75be65-a205-ecd6-8424-e0b3384b21b1@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®