From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B94883AEF34 for ; Thu, 19 Mar 2026 09:10:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773911441; cv=none; b=dp5vOdGsfZjMrodEArYmC/hQMKwsNV/1myRQ/F27gclCfdFsiRo4l12P1m6wz8EZEyDDKT9ThrKpCtGoikiwVtIj5rX24M0cogClTVc5v4p6uiN02do3smaGfQvk58afONTyY74RrelMqCF+//bSbypjPZfWQ/eKlnLcjlfIAsE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773911441; c=relaxed/simple; bh=TGIvxDbx64exSryIThvzyeyDY3ngkqlmOHfg/gwGrrk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F5DfH8f6dp91mtldmr3Cs16Sfxuq0U3N3I75I8SeROLCSR+C8wUVwXWu+x5diRUyw3ySOYYLubCj7k8ena19m82hBtJaB/PtgI/T+N6bFWwLQyHD55YB2VNakot000RxLev3/QZKDbh9h9QpkQ0gW8BWZVCmw7Qy1lVkW0HYdio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oygSXYnp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Pua3/46f; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oygSXYnp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Pua3/46f" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62J74AQC3369825 for ; Thu, 19 Mar 2026 09:10:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= v7m7aQiw0qBzZckwF8h4HRoLRfPXlziXjLV1T22Cnm0=; b=oygSXYnpCeueZHt+ YaVoHrFxkpgCVElTMpxIHPSKo+u4BrA/3PvRSMnrydNd9sZkLD9LzT6mNqdBEGLh tnB3Y3MHeeq7bYAVm+RAilMQ3l5X/yKWKCXp7JWtt8Xc+hRyuMV05LnZTopveuxh frgnSkIRQdl8lQfh48wgKL0J68ysTgpFScV8/XPvvYtkv7Q/u5vsDDSFpW/Yc982 0YYl2r0iEBLTp4ZKwKAwbiC3WejXTz5L2DE4/dlaw22YqrWwIwVGdrh+vTjOS5Td npYOVXKVZ1BhPltK7TwFMEPbJ4d2FUc3PPKL5cooQMvschDEK8FJxomsx2ULwwru Ik0spA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d00f9jhq6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 09:10:37 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-89c6717b74dso6216116d6.0 for ; Thu, 19 Mar 2026 02:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773911437; x=1774516237; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v7m7aQiw0qBzZckwF8h4HRoLRfPXlziXjLV1T22Cnm0=; b=Pua3/46fzaX/Fm1MZXLtx6SECWt7RnHMLIcglxbBtSZ/BNpptrnC1VEir1j5X4G/B+ A8oiYcLCkTiz17m4BUmt0RQfhil/Bdj1ffVwXejbXH3WrxjLCmV/UDCBakfrqorEDWSD 8FcagT/pYfIKCEkJu86yMGSlchiM29J5ooOHurwSGu+1K0hiQKDhY3Louz+MhjK71pYs CWBMB2JH0zN4Tv3LmqwjxRvgAFvWD+XcoaeThqaKILRzKzNx0RHsHIN9ljVvSg2vCz3z IW5nQPvCOYPDJ9pfw+6JoN1px4WGfwiNF3fHRoDlfoOUClZzqyIOoZ9lMsmV1/f9sZ68 5fBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773911437; x=1774516237; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v7m7aQiw0qBzZckwF8h4HRoLRfPXlziXjLV1T22Cnm0=; b=koYmhwb24Uz49o7CabS/RmY3u1bGMPkHwl+6IW/pXl3pwuuFyelo5bGCbPHCoGlWmG Qnx+gi8MGHrmFuG1Dcm8t/wWyjLK8cMKMtZlDUdVThJwXd1V4XNR0DJaRtG7id1H1fE8 Jj4yhVU+2XBPfGMnE9ndXMUctWzvv7OygQK2Wu5pe2CK7ZY/4O+4R8IP156gsD+drUj9 Ek4RmQnOw0THmBNLgoR1L4rTus1NytSE4wxZmkIJbhcxc1qud82UnftmM9h6WpOAGqtV SYIs2kGXAvcW/OZpJ75SPCxgTNJwpnCLK6XyonMAHn3mNRt57LMVksu6stoFrIskPRgI lGrA== X-Forwarded-Encrypted: i=1; AJvYcCXyXLuWs6DXmWkK5PWQDYoB8/UA2pIg34QdDr00t6uRsB/fr9JLeLmp+N618U8Nxh1LJRWR0AvPFBe2vz0=@vger.kernel.org X-Gm-Message-State: AOJu0YzG/MqRuXe4+YMvl2v/ImR9k3Q7dHqfJzjEk6kY9DUrFQ84uMRg K6ZGU7eBfAaF6IWxu+IsLRo0vXHPe3R6enNIk9FcvMqaXBcOMXd7feo3DDpAC82Yk91RkSYUO/Q 30WDsxtgmHOCHqz6FIEnJmYSUrNP3vTuG6QHR6+DRScF5wOVSgOTRfaB8pRwTsfhZY9A= X-Gm-Gg: ATEYQzxLQdrgAkdhQ9kl5wzb+V44QV5dgvvJnAttIfOZDU95LFh4p66+dvd9Rqelnpw Z4hAiVfQlA8SDoe1BVjJtcZ2WRp/WZ73s3LdldV2GSZIXFYvMKuAgbPAUuPyuRefgha3mNHHnem e4yuHF+ZuoODRBVFBU1cROY1Zpu6y871oHgpPq/D0/8zhlFkCpDkjnQTRAX1KjULqu4pKtkLI8O hQM/+MEJH1en9r6RFZPBGlRwRGmelM9t4GKIhV5RqnBivNyj32IMCKqEfdUg5qdbpeA+HV3hKzd 5fIoKnBNXnNpIOSzi145PjK+UR25C4+SpBuZY0YQ/yMf4Ec76phCo9dCvQ0EusGG5OjGZ+YzdkF K5lUebMg5AWAlvWKKxlI7gTG1VT4uJJMW2wwiG6RdJ0jZXyutKyxuLZ+Rpq/oZZ4AklIEnGQHas 6GnHs= X-Received: by 2002:a05:6214:21e9:b0:89c:40b3:1093 with SMTP id 6a1803df08f44-89c6b5624bdmr69955146d6.3.1773911436972; Thu, 19 Mar 2026 02:10:36 -0700 (PDT) X-Received: by 2002:a05:6214:21e9:b0:89c:40b3:1093 with SMTP id 6a1803df08f44-89c6b5624bdmr69954876d6.3.1773911436409; Thu, 19 Mar 2026 02:10:36 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f17036a0sm409705366b.49.2026.03.19.02.10.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 02:10:35 -0700 (PDT) Message-ID: <5b79ccbd-5c75-454b-8b3f-812a6c59157b@oss.qualcomm.com> Date: Thu, 19 Mar 2026 10:10:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] drm/msm/dsi: Add support for RGB101010 pixel format To: Alexander Koskovich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20260318-dsi-rgb101010-support-v2-0-698b7612eaeb@pm.me> <20260318-dsi-rgb101010-support-v2-2-698b7612eaeb@pm.me> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260318-dsi-rgb101010-support-v2-2-698b7612eaeb@pm.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDA3MiBTYWx0ZWRfX5Z8Q2THxOObY aH2AY6r5ysHh4cqg8dy9C1q3gOBfu1dbBZVcpCujmXXfl6qJNYV29bzclXgvHudRcL+WUiBwuqv 1P1VhQBDf1AO3Mkb4cbbFTLcvGSHZV7ODbCmstQ21rvCTfhXMktUr1VBR7X34LI0VJ0UVLG84rg pHVcn2spvDqnqaWDYz+OdrsM+n5AepwGigM/rLl2FsTUqKpCxCMviSsuFAsGcseWfqPbPIQ5RQo TKD4eZUzUo/RQTZgtI02h1pkW1HhJJapRPxG/mLm0yR1FAxdmqWXVMow8RIzMPLmnKg6o+728UZ BEVMS1HxvRUdfBG4r/cv84oCVdXAQLc7z6oJQcnsu397rOpUUfXLhUUU+McbM0cHWOxK7XsceF2 zhZ3k68D3imtfD50CHqBR5IfqerCisZk8Xm6AOfzbJEyb54kwInRExnitIQMP8fQegX5OpED4Ux FcG4rBqYyJJbJWzly+A== X-Proofpoint-GUID: 2Bqcl_aVTjCIe8QR3yZYSS-dqpwL78td X-Proofpoint-ORIG-GUID: 2Bqcl_aVTjCIe8QR3yZYSS-dqpwL78td X-Authority-Analysis: v=2.4 cv=MJttWcZl c=1 sm=1 tr=0 ts=69bbbd8d cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=bo00AjUxo_B6Js9JdCAA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-19_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 malwarescore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190072 On 3/19/26 5:00 AM, Alexander Koskovich wrote: > Add video and command mode destination format mappings for RGB101010, > and extend the VID_CFG0 DST_FORMAT bitfield to 3 bits to accommodate > the new format value. > > Make sure this is guarded behind MSM_DSI_6G_VER >= V2.1.0 as anything > older does not support this. > > Required for 10 bit panels such as the BOE BF068MWM-TD0. > > Signed-off-by: Alexander Koskovich > --- > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 8 ++++++++ > drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + > drivers/gpu/drm/msm/dsi/dsi_host.c | 9 +++++++++ > drivers/gpu/drm/msm/registers/display/dsi.xml | 5 ++++- > 4 files changed, 22 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > index bd3c51c350e7..6a7ea2183a3b 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > @@ -133,6 +133,7 @@ static const struct msm_dsi_config msm8998_dsi_cfg = { > .io_start = { > { 0xc994000, 0xc996000 }, > }, > + .has_rgb30 = true, I wrote a patch to determine this at runtime, and only after I was done, I noticed that we can already achieve this: bool msm_dsi_host_is_wide_bus_enabled(struct mipi_dsi_host *host) { struct msm_dsi_host *msm_host = to_msm_dsi_host(host); return msm_host->dsc && (msm_host->cfg_hnd->major == MSM_DSI_VER_MAJOR_6G && msm_host->cfg_hnd->minor >= MSM_DSI_6G_VER_MINOR_V2_5_0); } let's perhaps extract this to a msm_dsi_host_version_is_gt(u32 major, u32 minor) or similar and your assumption about >=v2.1 is corroborated by a doc I have Konrad