From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756522AbdLVS6v (ORCPT ); Fri, 22 Dec 2017 13:58:51 -0500 Received: from mail-sn1nam02on0057.outbound.protection.outlook.com ([104.47.36.57]:55936 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750864AbdLVS6q (ORCPT ); Fri, 22 Dec 2017 13:58:46 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm/ttm: fix double lock on glob->lru_lock To: Colin King , Roger He , David Airlie , dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171222180336.4250-1-colin.king@canonical.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <5b7a1a11-2cb0-e8e2-0b84-336981340eb6@amd.com> Date: Fri, 22 Dec 2017 19:58:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171222180336.4250-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [2a02:908:1251:7981:f4cf:5450:ae74:ecab] X-ClientProxiedBy: VI1PR0102CA0031.eurprd01.prod.exchangelabs.com (10.170.224.44) To BN6PR12MB1300.namprd12.prod.outlook.com (10.168.227.150) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ca3db511-7c9c-4346-641f-08d5496e05a1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060);SRVR:BN6PR12MB1300; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1300;3:BYB4avezmFeNlTpgSbU8FgqA9y+bKS9NLZdraYB/6alb67k1aOEIf5Bw1Tlzku2ehVbbrla1EEEjVqldOQcJ+EQsKePZm5vL1nu07xsqLSROP+ZrOEI+0TPjT4wXK0iH0OM/9fbFnqpQZiCo+FSp3/yc6GRvSPjFHL5fYqrHxSjYfOQe8dLCacGlPfQm+p1w54eU7sSHSyYBWyyCobgnNUzW91m6NfMtZ2Z4AMUZgCnAZDJyGjNurHuLaDhO71wy;25:ThjwkTa2eV3Gd6GGvOrIFd1//xXF7f+STPdBkFY22zL05PO4k1OYJihWYe80WLC07slTC6S+bCUzu9lt7UCgPvp+XbAI70Ai76y10FDGNJuE97OrqyF2K0wG9d1dnFOr1BmAZu4Ocx2rMlg6lWSr2I8bcCzT1+bqakQvA3pAGrB5yLvO+gAKv2QJ9VP+ujvscrH7JvpjM67/NI6/VSCQrrmM8ucChvuF+1DCkbBwqL/9dNoLknhnKPWN25m5ExxHrlqKZ1zd/Pccx4hayVAeJ+iyem4xotibHqmIFZugoeaE1mlYjACHh9ngeHWPuehL4+rQ1qNCxpalyjaMF4CO8A==;31:CY2X5JUvuFE2KMPg/UCF3mzsi896iixzi5UWIiVYQljd1Rx/RYT8ABi8CQsgOQakO+VrAAhH+pYNQEL4WnhAlAfBjdDfEaGYIN9NXHrJb/Vxk/2NTeNhUB7pOxcZFlLPk2aOBVnWwu6el1QkljW/JQLQdOEg7rhXvnmRNG26jgNF+PJi1fDN7x5g9jsrvRUxqoRCWgqZxblNe1HGcZ80SiXjRCyH8EnyLJJQMW/ed2Y= X-MS-TrafficTypeDiagnostic: BN6PR12MB1300: X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1300;20:QHQxlbD6vWxo+sp9vJQRi6O7TV3FqPUE/+fBdIic4nz5z+QrvIpDwahQRI+H3iVT5LI8e5GZVlBiQLmQk9SoWT++xW4qClV/kBk5Q9rXa4xynG3rdS2oiEVUQOdVZnYNPKKCeTvmILZq3Imu/rooYXWVzf/+nfVmONkUF4rD8Ft/ri5xeW17T8EO+YGFGDbejBiJKCYwKa+aTstKqVoHlo49upNvbb11pMxHGDwaoVkJdu4oA1svi8zFlY+NGwTmdYHvvDRf7IgKR4u6Ebhvze07Rqai6FTS8fxxSwOQ0/z+wdKst8fsQZHdPYDHJ0lU8cSle9YvfDexrLNgNees2vy2FfNND3fprB1zfCd6Tsp2SWvwcfVDSYQCZ303IbIe8wbPvyZqLV79MMrPHEWA2JzwxLXU0PP8NSF6NNwqnV7dYzN8XXuUkb+QD1G54D2dQ1rU9VIFZTN+Nc7ULecH2O5xPTAvAAkp5+UvAIbPulb1z8hMR5AS66Z0+A121LN7;4:u7M8s3rt/9NB/KVMcNYNfufgI5ttiXX3WvZdIXvnb/1JLF3ATvk52vRutGlconVHURyWH9q+y9LsnZ7/C39/wUhZTes+5qcru/8ZTnFWC1TdM1BTWPgXnNn3d4Kl+p+YqhIU0sAB94eJnDK5Zm33LZc/XJPiiXiErvgA1WGV98NEcYGvsEj3cT7TR1aDUQkDtWYrRWjEvVkiPwuwLA9WwgR2Ye8WurVIE6ZMe/bq234F4j+NDTsi0+n5q1Vo44BADBWFfDjDNTyJL2AqQey3WMlYkjBmRO0PDQnwmzUBhrdqRPjCi//8/aPaQNHC8ruU X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(198206253151910); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(3231023)(944501047)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041268)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011);SRVR:BN6PR12MB1300;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BN6PR12MB1300; X-Forefront-PRVS: 05299D545B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(346002)(376002)(39380400002)(39860400002)(396003)(366004)(199004)(189003)(25786009)(72206003)(6246003)(7736002)(31696002)(97736004)(110136005)(65826007)(316002)(86362001)(58126008)(4326008)(305945005)(52146003)(52116002)(2486003)(59450400001)(229853002)(83506002)(105586002)(47776003)(386003)(76176011)(52396003)(67846002)(50466002)(2950100002)(23676004)(106356001)(64126003)(6486002)(8676002)(2906002)(31686004)(65956001)(53936002)(478600001)(8936002)(68736007)(2870700001)(81156014)(81166006)(6116002)(5660300001)(1706002)(65806001)(36756003)(6666003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1300;H:[IPv6:2a02:908:1251:7981:f4cf:5450:ae74:ecab];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxMzAwOzIzOmkyeVlGeFlyblhVSldVdnFHVHFKNkNhUmxD?= =?utf-8?B?TTZNazR5aE5FaSsrUXEvZWNwU1ArVUlod0lKL1QwWVgvQllFQ3pJN0xYWG0r?= =?utf-8?B?MTF3NXc1Z2pqNVkwMENEWXNRV0dqZGxzNVQ0Y25ESmtIeWQvNXJZWVp3RFph?= =?utf-8?B?dXRweE5PVEVHNWxIT3BHMFU0NVJ3cENOMTRjZE5FWXRsTDhJeDBqNkRUb1FQ?= =?utf-8?B?Y3lUd2s0eEVPaFBuMDlrU0NOeTRyOGpqMm9qOVNHZVVnNjJhMFJzM3hqczlE?= =?utf-8?B?aE9mVXVkaVE1WVhybUNJcmRPU1hpYW5kcVptV1B0QURoZXVjaXdPenFEbjlt?= =?utf-8?B?bnBJaFJObDRua1Z5OTIwWXN4ci9YVVliZ3pHN0hBaDM2eUh1a3A4V3BYN25a?= =?utf-8?B?c2lyemVPK2N4alluL3JNVGJ5OVF4eWZUK3gxOTM1ZHh1YXA4WWJzMTRtOVlI?= =?utf-8?B?Ym53WVNFZGRMYzVaSURtYzR6NnJwTVhORVZNQXF4SFNvdUZxeDZ1UlpEeW5a?= =?utf-8?B?eUxmTGhueWJnQVl5eUJITHZ0TFZtS3lNeXovak9Ld2Vyd1pWK2hrR0ZLei9s?= =?utf-8?B?NXZIbHVGZ200aEJ6Y0NONWFkM242VHZ0Z3luUFR4Q3NPMEJiVDJpU1o5SE94?= =?utf-8?B?M3JuMEFxT2tYWmU4ZzdWUndIdG9JRHQ4UFRiV3FpRHdLT3NkcUwvRGFPRWk3?= =?utf-8?B?ZVRReEd1cDJiYW8xTlJzMlBCQUVuVlFQaEJwTkpQSklyOXc1dmR4R0FUR3JV?= =?utf-8?B?Nlgrc2tKWUFHSDZjT0kvdmlSZks4WDBLWWVJNWU3Q1hlQjRsZXpZMEhTQmlu?= =?utf-8?B?UmFpTldrb2JjSTFuOW9MakxBYmVxMG9MdVlwSUIyQjBUeXFDNkZsTVIxbG5t?= =?utf-8?B?U0ZRU3pzOHpGU2VqQWdFaUVheXkvV09pb3B4WmFJR1hKRGdKTG54OGdEVjRy?= =?utf-8?B?NFFwVFJDVmovbTlQU2NXRWZYZ3JwSThZem9vcU1SaGJsTmJaaTNRN1dsQVB6?= =?utf-8?B?RFUwWTQ5bXJkYUNDbENqVk9Jc2xmRjBFOExqeG1ZcElUeS9mQVJzaDFuWXpT?= =?utf-8?B?b3R4QmFCd2ViU1MvdnVkTDRuRzFlaFlicm9peFFuRytzdklxRUJ4bTdIRkx2?= =?utf-8?B?Y2U3dGQ0S2kwOVAvNjYvSktwRUFkUDdTc0JUbnpNdEdlSlBMU1lUKzl2MWNx?= =?utf-8?B?c0ZUWjg2ZkhDb3hIRVQ3NFo4NWlIaFJRb2Q0aDlYbTZkU25BdVpLa1ZaTnlG?= =?utf-8?B?R2F0OXBvY0JiZlZhZVJhK0NBMWlKcjdQUFYrMlB1ckcyVUhMK1B1dUNRREpN?= =?utf-8?B?TE9CdStjZEV4Uk42RWRSUURYQ1RBUDY2TkUxaklCcWdJdHV6NHF2OWFxVSsy?= =?utf-8?B?OUlOelJHRmpkaitPYlZnbFlSZkZOZGpmVUFNQmdYUTNCV2x1SUdPZHVRMk9S?= =?utf-8?B?ZlhnbEJJY1NQaU5KR1RVOUoxUjJkSGJaOU1NUDBzb2FNSXRQZXlDWUZ2eGMw?= =?utf-8?B?MWNYT0FKeEl5K2NTSzNLYS9UOUxHQWVLNFJQcmtQSGIwQ1FHNVdISk5XeXV2?= =?utf-8?B?eE5oRDF4Y05GdXBmV2x1Z2IyK2h2N0wrMDlUUTdJTjNoMUV2clZGcU5yRFVl?= =?utf-8?B?T1l3QnNLZERMd0RmSUxpODdwbEJ3Vmd6UWRiZ2dxaVF1c3lUZ01tMUlsZktu?= =?utf-8?B?SFFqNU9OVUxKcEc4Z0NzQ3dGT1YwZlhQL2V4b3hMcWpEYWRTRWlwdCtLYVdw?= =?utf-8?B?M3E5d0ZsME9BVEFQeHFxdz09?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1300;6:Nntm0b7WvvlLGzk/lPvkkoYASz3W4+Q6rtiKCDd+OTGqqvIlFNT1T9O4RQJfarSW9Fo10/e5FDajz20vEs0zc6vakyABQ1aQ6aQhr3n4gwks4LBhmdgWGmiMwua+ag+PZnrAHryQjX8KM6tLihT5h+eSS6WORZKEsde4I4/G9OA5oJRH+LmyeekpW5lJXXeHrWNqTL/n2sP0CTyF4n16TbrL1w0RA6VYzzRYu6UtbFW8UM18qNi8C+86lPAuoftZyPc7Cq63XyeXQfVIvG8CapILh6q/jUR3Zde96WnCYoWnAfH00yCL0gepk042HUQJ45bgyGSRjCuxI0iwLKokJrAFEWgrWf8NRa2Uya9mfko=;5:FoKYNxvunIfU2KMbrSFZ/+Kc+nQ3XaMOQ942kp7Dx+k+desKnT1gQWBZSkgDAMYQNLR8TYWAhjihosYN6MLFiE9mTJWVCE+d+pXiCpL3YpUMm00qXlUAEushU4rGm4uAsseHOSpxsSpKbNMDdL6PZyTpCKqWNVIziaOrqBHh8ko=;24:8eERGJt/5yTmqBF4kqYLxQru0QM4fdt81fLfXSqMdSYDemqXcyHi20B8xqxgeNOxgbHT4w/aSOvwxeA9l9HQB3krZh9IJmIN119KoC86Flw=;7:rNhpnfHfEs0/IvM6SAw+T011Mf/bghlH6s/DAd0SQ79Qw0HjCuhRkQM0kP7KVLBTJmI31tfIktrTVCVeKhbx/uAavguta6h8zFQmDB+mrtvQCKf0hzxUou47lCXflV38N1g63nx11D/QHNqSE0247PyNSHXFTYD3dlnvVwjYKR0jPjj8s7onmoelK87qUL17M4Jg023/KAkd8RGWCjooZy5e3YTgc2torZlPjzUstGZUNdX1LhyNpGv5R4pKY5nK SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1300;20:FwDj2T2jzAw6W9iDu30+ZsKQigP6HddVsb0YWy2b6bM83HrRi+rgTLZU39LVaG9P9XNdmx9VbSDJbZNVbG0HJiAYTu86yuqSFKfNn0JWju/4kD2ubvma1mk6Y6CEjwe0ptlAixRPYBYszokrICb7JJouFNVX1stEkQb9mhIUiHRHGPRmo98KvcS4cizrdNNsrnh+qYU2g38DbSTKmJd1jzRp/s1CnLobR+NxKyb5HkBZXUOWRtPcF0NEH7XhvzNR X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2017 18:58:42.0767 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca3db511-7c9c-4346-641f-08d5496e05a1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1300 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NAK,  ttm_bo_cleanup_refs() is dropping the lock. Your backtrace is cause by an issue I've fixed this morning on amd-staging-drm-next. Regards, Christian. Am 22.12.2017 um 19:03 schrieb Colin King: > From: Colin Ian King > > Lock glob->lru_lock is locked before the while loop and also > locked again at the end of the while loop; it appears that the > lock at the end of the while loop is a double lock that should > be removed. CoverityScan picked this up with the introduction > of the referenced commit inthe Fixes tag, however, it may have > existed before this. I've not been able to test this, but it > does look incorrect to me. > > Detected by CoverityScan, CID#1268846 ("Double lock") > > Fixes: 827ed2b06b05 ("drm/ttm: use try_lock in ttm_bo_delayed_delete again") > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/ttm/ttm_bo.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c > index 60bb5c12b568..fb8d13a4bc94 100644 > --- a/drivers/gpu/drm/ttm/ttm_bo.c > +++ b/drivers/gpu/drm/ttm/ttm_bo.c > @@ -595,7 +595,6 @@ static bool ttm_bo_delayed_delete(struct ttm_bo_device *bdev, bool remove_all) > } > > kref_put(&bo->list_kref, ttm_bo_release_list); > - spin_lock(&glob->lru_lock); > } > list_splice_tail(&removed, &bdev->ddestroy); > empty = list_empty(&bdev->ddestroy);