Re: [PATCH v3 5/9] ARM: dts: stm32: add Hardware debug port (HDP) on stm32mp13

[Krzysztof Kozlowski <krzk@kernel.org>]

On 23/05/2025 14:38, Clément Le Goffic wrote:
> Add the hdp devicetree node for stm32mp13 SoC family
> 
> Signed-off-by: Clément Le Goffic <clement.legoffic@foss.st.com>
> ---
>  arch/arm/boot/dts/st/stm32mp131.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/st/stm32mp131.dtsi b/arch/arm/boot/dts/st/stm32mp131.dtsi
> index 8512a6e46b33..b0537bcdb9d5 100644
> --- a/arch/arm/boot/dts/st/stm32mp131.dtsi
> +++ b/arch/arm/boot/dts/st/stm32mp131.dtsi
> @@ -951,6 +951,12 @@ dts: thermal@50028000 {
>  			clocks = <&rcc DTS>;
>  			clock-names = "pclk";
>  			#thermal-sensor-cells = <0>;

Why are you enabling it? Commit msg should explain this and this should
be sparate patch.

> +		};
> +
> +		hdp: pinctrl@5002a000 {
> +			compatible = "st,stm32mp131-hdp";
> +			reg = <0x5002a000 0x400>;
> +			clocks = <&rcc HDP>;
>  			status = "disabled";

Why are you disabling it? What is missing?

>  		};
>  
> 


Best regards,
Krzysztof