From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD213C43461 for ; Thu, 17 Sep 2020 01:51:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 794D12076D for ; Thu, 17 Sep 2020 01:51:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726183AbgIQBvG (ORCPT ); Wed, 16 Sep 2020 21:51:06 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:42354 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726072AbgIQBvF (ORCPT ); Wed, 16 Sep 2020 21:51:05 -0400 X-Greylist: delayed 950 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Sep 2020 21:51:04 EDT Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id CAED83E5D1A9CAA3CECC; Thu, 17 Sep 2020 09:35:11 +0800 (CST) Received: from [10.174.179.108] (10.174.179.108) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Thu, 17 Sep 2020 09:35:07 +0800 Subject: Re: [PATCH -next] net/sched: Remove unused function qdisc_queue_drop_head() To: , References: <20200916141611.43524-1-yuehaibing@huawei.com> CC: , From: Yuehaibing Message-ID: <5b7b6ff1-19ea-33b6-87b7-2cee6db8157d@huawei.com> Date: Thu, 17 Sep 2020 09:35:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20200916141611.43524-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.108] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pls drop this duplicate. On 2020/9/16 22:16, YueHaibing wrote: > It is not used since commit a09ceb0e0814 ("sched: remove qdisc->drop") > > Signed-off-by: YueHaibing > --- > include/net/sch_generic.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h > index d60e7c39d60c..6c762457122f 100644 > --- a/include/net/sch_generic.h > +++ b/include/net/sch_generic.h > @@ -1047,12 +1047,6 @@ static inline unsigned int __qdisc_queue_drop_head(struct Qdisc *sch, > return 0; > } > > -static inline unsigned int qdisc_queue_drop_head(struct Qdisc *sch, > - struct sk_buff **to_free) > -{ > - return __qdisc_queue_drop_head(sch, &sch->q, to_free); > -} > - > static inline struct sk_buff *qdisc_peek_head(struct Qdisc *sch) > { > const struct qdisc_skb_head *qh = &sch->q; >