From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0BBD25F964 for ; Mon, 14 Apr 2025 13:07:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744636056; cv=none; b=EJqDSBSpQFM3Giu+NLmyTO4F6H76bNEwkEwzLU36X0YVcMYMFBtPmXILmlS+Iq71x3evyr8ldVxa5CV1zxdyI9Dqcs+OZ17FYnbQDrGVz04tDaTPPb5DfWTZ7ox6fK8b/Tj96Ct4ueCJBfw29rprNGSo13NUL7dMRH9AKXECsGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744636056; c=relaxed/simple; bh=ywQmHD/mf4H2fFyhuuMIat+d5W+cHZvnrGUn9kTOw6w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LFQ5/NTRZvAzmm0sVUIS1wdUfsaDm6tclbNYbAmcpTCNOMs9pHTnO33PJrjRXyOlEVm/7NZJ/3jsPTZl9p70mXH5KrrKA8Qk8o3Q02ZYrDJnZ7SI7rWrx27qmaM0s/ftQQHPDksnpE6/17rKSIH4YkI83VZx0HbMcQSei5Frq2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VcSosi47; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VcSosi47" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53E99qE1002934 for ; Mon, 14 Apr 2025 13:07:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2lDMoGbLTkfpV9XPmY4UE7cjKyAc0EvO1VXR+z/uwKo=; b=VcSosi47HmKEE9fd TAKwP7IleGAq85XwKdpf7SEqMk3nFF3HRFKNZYb0zOx7D7scBTCM4+O0Gqu7CPs6 LVgDK/quX6mxxfrOOhzc+MUxlx/HtZtGwCrsHfdKA+7xNZOtaWk9LIqtl628skQL jzFxNYtKCoNlV8MFHYaXknULyKRfE6CQKUhynqsdTdVkv28y+EIbJOcCibXbEoB9 lBWQUOMAeMmBXyruLjYrGg6fEM5qIF1M7uFopExABEcUi0qkC6QHnWxICluET0y4 lOeDTJin7+Y0WNdcS64OE2Wt/XRiLzbrNPNbmmVPrv8mJNq6Cdoy3l3GWY7AWrnD aBgxCQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45yhbpmfb0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 14 Apr 2025 13:07:33 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c54be4b03aso86210885a.3 for ; Mon, 14 Apr 2025 06:07:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744636052; x=1745240852; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2lDMoGbLTkfpV9XPmY4UE7cjKyAc0EvO1VXR+z/uwKo=; b=T9pD244XjwdhLr0PIQ8BO4zKpCqaQenxUiaBluMMbKHQ8MJp9c9Unei+zc4tOWTr7E IrHFvqoEEkJk2KAuiBAsZYvTodFgNjSvpDqgxit+Ps1nZBay4QYnDEzjNrQdVFEy/SVS sevRh/t86THSpss8Za8+x+uargk9R8dxGZYA/1qHiQvBt8Unb4xJpDVXGnkLk3JqjU3P O6gOoigX3f5a0Vh+tWpjbWA2wo+sP22Mky+4fRNsHwD+9xSGQUH48VSWsFhqOpeGZ3Pm mOt3/84BJKDWS3ArOn34rLV7o9NuO/jWnpbix6sbyTEn25eZqi7dfPeq9eI2xjrUB6e7 xQaA== X-Forwarded-Encrypted: i=1; AJvYcCVP5zkREU6MgQjDcjaSsWRtIer4qYzaN3qNCp5BJz4W7/nKOcgHGKGU+3Mq5+dYJm6Szzy00zljtVvD9ZY=@vger.kernel.org X-Gm-Message-State: AOJu0YzgJ3l8yY+ZAs2rS4ytDHw47uSDxJUZWEpH8U6fRp1R+Ygem+YF SGGLG0eK0Yg9aDEDYejgu2A7V5CzylU5eC6KLEQ/KXk5/GXhxO8STdF/JvDLTnEqdK/Mi68TIsm Or8SXwE+qZW9eaeD6vEdf7vvoR69U5yIY6m1RvOQ0wd8XL+SSKaA7jOFuroAgT4Q= X-Gm-Gg: ASbGncuvXkXujmOTmdxrHlIWqwjU0wf+3XPUdBrJ2xsq7bw59ctgl2zMHT9KXO8Ipg+ MyqIa0gb5eWLovMNoOyQjSz/djmV/+8wSG52qKi+0UZ5UNSJ1IeTnRhg19j6/wURDNO+nE04yrb 63JWMRskKwISCt76yXnIX3KJStHZol8abRvCVcxIc89Z69cYA9lYwj7CbM+NfkynneCaLB5VMxs ktZTKIB8BagQhWtRwOKEUFzTGOA3cDW0YbDqUG0pK0qLRrAp4w/GS3qcAkPc4l/9dFkqA2wmRDs ahU/xevs2musTLgDU7MhRgPtXTmjmsMPt792wSXbHzMZls7H1vAejBKkw9+nCPYwIw== X-Received: by 2002:a05:620a:c55:b0:7c3:d752:f256 with SMTP id af79cd13be357-7c7b19a73d9mr526925985a.7.1744636052503; Mon, 14 Apr 2025 06:07:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkjyPRb5zjVxNYkQFuXETFI2mifPtUz3VVZ8CZhW5cBCjg9CtZG+TWolnSrPbDxliiMbxdEQ== X-Received: by 2002:a05:620a:c55:b0:7c3:d752:f256 with SMTP id af79cd13be357-7c7b19a73d9mr526922685a.7.1744636051876; Mon, 14 Apr 2025 06:07:31 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5f459a32596sm302607a12.65.2025.04.14.06.07.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 06:07:31 -0700 (PDT) Message-ID: <5b7bd3a6-532d-416c-aa64-8523c54d87b6@oss.qualcomm.com> Date: Mon, 14 Apr 2025 15:07:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/10] arm64: dts: qcom: sar2130p: add display nodes To: Dmitry Baryshkov , Konrad Dybcio Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kuogee Hsieh , Krishna Manikandan , Jonathan Marek , Bjorn Andersson , Neil Armstrong , Will Deacon , Robin Murphy , Joerg Roedel , Konrad Dybcio , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Dmitry Baryshkov References: <20250314-sar2130p-display-v2-0-31fa4502a850@oss.qualcomm.com> <20250314-sar2130p-display-v2-10-31fa4502a850@oss.qualcomm.com> <8fe8c0f8-71d5-4a85-96e5-17cb4773820d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: GpmoO9aPOE82gKZyNNm8YdNqQFELtupS X-Proofpoint-GUID: GpmoO9aPOE82gKZyNNm8YdNqQFELtupS X-Authority-Analysis: v=2.4 cv=I+plRMgg c=1 sm=1 tr=0 ts=67fd0895 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=KKAkSRfTAAAA:8 a=ivjB2eyK2o-HjyQSxY8A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-14_04,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=719 clxscore=1015 impostorscore=0 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504140096 On 4/14/25 2:14 PM, Dmitry Baryshkov wrote: > On Mon, Apr 14, 2025 at 01:39:56PM +0200, Konrad Dybcio wrote: >> On 4/14/25 1:37 PM, Dmitry Baryshkov wrote: >>> On Mon, Apr 14, 2025 at 01:13:28PM +0200, Konrad Dybcio wrote: >>>> On 3/14/25 7:09 AM, Dmitry Baryshkov wrote: >>>>> From: Dmitry Baryshkov >>>>> >>>>> Add display controller, two DSI hosts, two DSI PHYs and a single DP >>>>> controller. Link DP to the QMP Combo PHY. >>>>> >>>>> Signed-off-by: Dmitry Baryshkov >>>>> --- >>>> >>>> [...] >>>> >>>>> + mdss_mdp: display-controller@ae01000 { >>>>> + compatible = "qcom,sar2130p-dpu"; >>>>> + reg = <0x0 0x0ae01000 0x0 0x8f000>, >>>>> + <0x0 0x0aeb0000 0x0 0x2008>; >>>> >>>> size = 0x3000 >>> >>> Existing platforms (including SM8650) use 0x2008 here. Would you like to >>> change all the platforms and why? >> >> The last register is base+0x2004 but the region is 0x3000-sized on 2130 > > As I wrote, this still applies to other existing platforms. I think up > to now we were using a mixture of 'last actual register' and 'documented > space size' with VBIF using the former one. Should we switch all > platforms to use the latter one for this region? In such a case I'll > update this one and all other platforms. Otherwise I'd prefer uniformity > and still use 0x2008 here like other platforms do. Let's stick to allocated region sizes (i.e. 0x3000 here) Konrad