From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 039513DEAEC for ; Thu, 2 Apr 2026 10:10:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775124616; cv=none; b=RYeskrBZveIRPP91MvGKTkqGeIYCaoAkF3pOKH3c7PEcGZSposw3jVrqFtb7+5ubO1oVobjR8griWx7LUqYBnpItMx8GJqfjSW3aoB0/HeSsL8wopEZ+L3ljkUclK1EwF091y92LtpLwVWkhnxX8O9T0xqE2A8kJ/7KP5zjmdag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775124616; c=relaxed/simple; bh=zHFrCPHhU82trU3T1Txy7LHnZJ2znMMSxro8pRXdEog=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Bj3WEq3IHhxxfrcZoa2NRG0QOGgtT5c+Eknsi+DquVa0JOaeFkl9BNNI5NebJbVJXaDhXEzJ1fdhhMe71Ql7iLufwtMYE2Hq/mNJ666LoJcg8Dex9DMlV50a6OmA23El8O9rqOBSgWd9Vh+sA3As5ndVverGhQTumEdGH03pAeY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Fn5RhOQW; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=VYRQfAoC; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Fn5RhOQW"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="VYRQfAoC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775124614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vI34ad9TZ0aROIv3z6J1CAQ0jr+pvjoqHVYmg8tKBOs=; b=Fn5RhOQWYFKdDSAHY6i+BgliUfNONbgeAsmFXRwfe096b2QyO6EZoJ3cdnLFHrdtyD+e6r 5EcHyBMXVo7BlcVWQif2ZG7Bja26mZ2iBs26PWkew6J41agw9xiD4ZwrFRbkpSUac6nraT mRTEIluRBD0/+RS/djyyh5K7FcHGhKU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-139-wbRUrH-6OTeI0iWbXNczoA-1; Thu, 02 Apr 2026 06:10:12 -0400 X-MC-Unique: wbRUrH-6OTeI0iWbXNczoA-1 X-Mimecast-MFC-AGG-ID: wbRUrH-6OTeI0iWbXNczoA_1775124611 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43d1dea12aaso529578f8f.1 for ; Thu, 02 Apr 2026 03:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775124611; x=1775729411; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vI34ad9TZ0aROIv3z6J1CAQ0jr+pvjoqHVYmg8tKBOs=; b=VYRQfAoCsihuW+YgM7G+OmieWlW7QcB3oYTaylUkuB1qterNJYwfZAjthBBQwsUz4Q TllXpn40O/5msTcgCh4mHA8zCSdYmN4O1pQY2xZku/NCbZxt/YaLdoZ1T+MV6ivNVo3z mSafhlg1pM185Ainhqj248TyPiNLuYZ1LmNnKUz4f9pM0+4fHQkApWF/lAx55022CP4L nXnebY0DU18AKAMC0WWmkYF8eYoMl2OI8Nev8CX582riMHI7QqXwJi+RvuZcAa9wv3ZZ Otydikw6yEEJuilWijZhu0w0zbZGG2gokdXAkRWoIe5f0r0+hS/hMvZOm9S1B3w0o/9q ooRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775124611; x=1775729411; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vI34ad9TZ0aROIv3z6J1CAQ0jr+pvjoqHVYmg8tKBOs=; b=IFt4Vnfzj3EMGI9sy2W1aJTJu0uYft0j9ENNu9aWsxo+G0g0J9nsJ4SHFu1Vs06Xr+ 4sGbS7wSSc2iwOQvFafSA4LAgAxvH7Cbj1yAOnnU+vCPcDD6IwW9qPxsYcLMDpFbkLOe /CCyDGeOMuJlzgOGva7DtiTzJ3XvBiexdnGCyEvbakPA6F119u5dXvvunAZm0CaMMmwZ D+zbf6qxs5qL2QB3IG4OG1qTHzYyYjCLQyDb8KbkHC3Kk91vuTxVIvnoABYImpbjhRRv iyKYlqxOwzZr/X2lx9Ro+D0CzF7VMA0FdOvP0x2odPZHeyIAYgbyn8q26aF+jZliPo14 3N7A== X-Forwarded-Encrypted: i=1; AJvYcCWYzZfqaCpRgnASqZDIpZBkrSXpMAAxxYX96a4UFUW21W8FCzIwZAsOcYVghETa8L86KU1I0+dxk2aNDfw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8K22JGZWy8bCQDyziMiv24pE+/UnypYkPU3LiFXyIvPb+ooMx yKDmGM/1Gm3H+6q+/2dgYXInW2Ttxr8lBoIjx8z9f+1LogXYRVJkxP/+WVB2mIt+y4o0ewFhTNr oqeEh2CUQQI2c67nan6ESn2/kwPxNzK9pAk/4tbqMONdHG5FJyCGH6XrOdQ3KueLKjw== X-Gm-Gg: ATEYQzxr8drdVMe5Z1MPgAFEegqOuR9yk4utxZQ+NiRh809w/b/nVOIVgu33SgLJi5f xcjTujzqfmPT3Sa++0K/yEwIfCMpvqVmJdmf1TphY6jMkBTYdCF36XwsKt73mlIu5U2vs2A7EMM kka78rvjUgT6g83PY3sVCyM5a/kcmzg9/6bJmmFtGf2oF7zFMYZHZjGCAFvkXJ2UNvxmNKfKDKz wjSxX3IPV2LY3Z7IzpQ5NrikSzx2FaDlm8IoCMwsF3YY2vfKtwcBetnydU9k208qcsWnXwOcrjo 1dvKIjO2vnyyw94SEVeRu7F81mC+y0M1Flx0ecRTNxlVsOz49bd/e6NQYHSRfSfeKQJITl7OuiU fR5FbwNUkfMfmL32bx6oLb4xJ0eV79dZzSC85lcIQwQgMLWlR3Dpg4OEmJQ== X-Received: by 2002:a05:6000:288c:b0:439:ddf9:a205 with SMTP id ffacd0b85a97d-43d1f1c0348mr4685306f8f.10.1775124611420; Thu, 02 Apr 2026 03:10:11 -0700 (PDT) X-Received: by 2002:a05:6000:288c:b0:439:ddf9:a205 with SMTP id ffacd0b85a97d-43d1f1c0348mr4685243f8f.10.1775124610926; Thu, 02 Apr 2026 03:10:10 -0700 (PDT) Received: from [192.168.88.32] ([212.105.153.248]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e1fe0b0sm6286938f8f.0.2026.04.02.03.10.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 03:10:10 -0700 (PDT) Message-ID: <5b7faeab-77b5-4a3c-a717-5a80f5e76a31@redhat.com> Date: Thu, 2 Apr 2026 12:10:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 7/9] selftests: drivers: hw: move to KTAP output To: Ioana Ciornei , netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , linux-kernel@vger.kernel.org, petrm@nvidia.com, willemb@google.com, linux-kselftest@vger.kernel.org References: <20260330152933.2195885-1-ioana.ciornei@nxp.com> <20260330152933.2195885-8-ioana.ciornei@nxp.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260330152933.2195885-8-ioana.ciornei@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/30/26 5:29 PM, Ioana Ciornei wrote: > diff --git a/tools/testing/selftests/drivers/net/hw/ethtool_rmon.sh b/tools/testing/selftests/drivers/net/hw/ethtool_rmon.sh > index f290ce1832f1..ed81bdc33536 100755 > --- a/tools/testing/selftests/drivers/net/hw/ethtool_rmon.sh > +++ b/tools/testing/selftests/drivers/net/hw/ethtool_rmon.sh > @@ -11,10 +11,12 @@ ALL_TESTS=" > NUM_NETIFS=2 > lib_dir=$(dirname "$0") > source "$lib_dir"/../../../net/forwarding/lib.sh > +source "$lib_dir"/../../../kselftest/ktap_helpers.sh AI review noted: --- Will this test work correctly after installation? The test sources ktap_helpers.sh but the file doesn't appear to be included in the Makefile's TEST_INCLUDES variable. Looking at tools/testing/selftests/drivers/net/hw/Makefile, when 'make install' is run, only files listed in TEST_PROGS, TEST_FILES, and TEST_INCLUDES are copied to the installation directory. Files referenced via 'source' need to be in TEST_INCLUDES to be available at runtime. Without adding '../../../kselftest/ktap_helpers.sh' to TEST_INCLUDES, the test will fail with 'No such file or directory' when run from an installed location. --- IMHO this is better handled with a follow-up as opposed to a repost. While at that, please also take care of Petr's comment on 2/9. Thanks, Paolo