From: Tianchen Ding <dtcccc@linux.alibaba.com>
To: Abel Wu <wuyun.abel@bytedance.com>, linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>
Subject: Re: [PATCH 1/2] sched/eevdf: Always update V if se->on_rq when reweighting
Date: Tue, 5 Mar 2024 10:13:59 +0800 [thread overview]
Message-ID: <5b863dfe-bb97-4bc9-a117-153b1ba087f0@linux.alibaba.com> (raw)
In-Reply-To: <ad801d18-6243-47c5-8e37-ce712ca5d0c5@bytedance.com>
On 2024/3/4 20:06, Abel Wu wrote:
> On 3/4/24 11:00 AM, Tianchen Ding Wrote:
>> reweight_eevdf() needs the latest V to do accurate calculation for new
>> ve and vd. So update V unconditionally when se is runnable.
>
> As this should come along with commit eab03c23c2a1, I think it would
> be better add a Fixes tag?
>
I'm not sure. In fact avg_vruntime_sub() in reweight_entity() was first
introduced by af4cf40470c2, and at that time the algorithm about reweight was
not completed...
next prev parent reply other threads:[~2024-03-05 2:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 3:00 [PATCH 0/2] sched/eevdf: Minor fixes for reweight_entity() Tianchen Ding
2024-03-04 3:00 ` [PATCH 1/2] sched/eevdf: Always update V if se->on_rq when reweighting Tianchen Ding
2024-03-04 12:06 ` Abel Wu
2024-03-05 2:13 ` Tianchen Ding [this message]
2024-03-05 3:15 ` Abel Wu
2024-03-04 3:00 ` [PATCH 2/2] sched/eevdf: Fix miscalculation in reweight_entity() when se is not curr Tianchen Ding
2024-03-04 12:06 ` Abel Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b863dfe-bb97-4bc9-a117-153b1ba087f0@linux.alibaba.com \
--to=dtcccc@linux.alibaba.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wuyun.abel@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®