From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF9A04252A7 for ; Thu, 9 Jul 2026 15:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612453; cv=none; b=ty59E/0pw5cOJ7jFbksXM5CXmWkwvyRZHAY7t8fOFgKhGFxbdSTHSgtl6+5UhP5Mq0xyn6f7+P5tuza56rjMcpTk8DA4d1V3t5+yvCGBE9KrcGEns7zA5/esfnI3qjAjfx+KIIAwhqe2qUqEgSnfX44GXbuHCtnBgQcN/8V9idc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612453; c=relaxed/simple; bh=E7xh6evd46JlapDcP1wu59TPdEBuTy/YptxJBkiz3T8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QqNgyeowOmjniI2qtEArbZApS102ZQvEYffOn5ZbPALRJyQNDynUqNA//d+CmXgfW0AttbDilIOSncVMjNI8H/c2ASnq6YmOTVLGz6WzhC1roMxFu+B2bQyqv5j1Y0/2TWO2umVSaGKwQWzA/4VCGp59eH1mZU4Szb8+YHiOojo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CAhydAe+; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CAhydAe+" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ccf2360620so17503715ad.3 for ; Thu, 09 Jul 2026 08:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783612451; x=1784217251; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iyiC5ezPowkdRB/jC99TZVbd/6jva1/e2ioHJ+vpJlU=; b=CAhydAe+OhkxBPdygMWMa98stHEw/YsRduHEum3lnZ9PBWL6Qfbuc/Ejfs7VGCi8oj ZuuessoqrKGRMWQSNnBMiBFJkRc08UOfASEIEWl+o3lDzF5qj6OdKecR1fP3mDwtJe8M 29a/uqvBok7bYqahsDYPvFSjgh62w9n2I1tsVwMoci7cj7Mpcvi1XX4+3axOzFnkok80 PEbjc/KFGoWagNG1O8Qjm28K57SwFUiJ42uotEG8A76sZOJ7STPEu2noJcwnEoEwWOcv 3sION70qAfk+4vvN3mArxF7hMjX/x/mBdgdLDL5Dxnt1ZFPjbjvC3aESJo6a6JDgT6sy 9m3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783612451; x=1784217251; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iyiC5ezPowkdRB/jC99TZVbd/6jva1/e2ioHJ+vpJlU=; b=mSQiEH3W6/pdY4cM9WYaitDkWsCkX76cvWZ3fwbnHbOX7E3tiH2LBKAr92ekt+cdNf dEI9ruxKMqotKEnnqG5k3mu6Bctw2BMKw6s6j5nHyLUBarqlKHyrUW8jJ/wUa25Vu9I/ l8CU4lA8YGHF0wgP56teVM5+mMQxhxf2MtJKx11ZcaAk/XehH7IP25L04W5PttjCfz3J x5lRWNsKzLDHvo/eZeH2MUpVDWu8UOTV0+A+8Ni+iW5++gIu1YH1JaqcYCTaU0Dol0ob zpzKaMrx3zkpMZ4gxX8W/6DRAc6dSAZdUOecZbT1mB2QWKsP4/YPhw/ZZK8fUU6AlXAF 7W/w== X-Forwarded-Encrypted: i=1; AHgh+RrAMOSAffFbEFYuIpqC3gxRXojuhGxqqS5YwxmqkUtRP4aYM7HJmRWjwRak5i01agHVyfojybqT2qAQuUU=@vger.kernel.org X-Gm-Message-State: AOJu0YzPr3h0iObdy+S5kDFmmu9UjiuJ5tk3F+LNBOsXbi9Ie4grXk8F N4Jh7DKu2WHqwu+UO1VlrI5oz8tc0IoaceOsNkgFMRppF1wYhji0mxeW X-Gm-Gg: AfdE7cm+qnmBN2QFvzYWGwfxFI39mg97wW51L5jqwv0Gb7AWWPSVrpAgPLOmpqxBb1U NXIuLOTIHRTkcI3PIGVIE//BdepVyN/hQaoRYQpEnH+oK7DoF9SZMgizZ9z0f1smPI5lwj9r1j3 67RjUsYUXdt7a814RyvrAC4xzONo3aE6V2KJKwWkBMci+VVK6JSwUR2HbfmdBOPPFT0jdX5wnyY P5xi61qoUHXE9MmUkuTj4NAMGT64DhBXFusZ3arAavyQrwvbvuwQMm3NqB/2I1GIO5+736WcbWj 9yU5/u0x9fxPUX0ArafSxe5yZAijXVAbBZl+8VnaD8Zxy+q23EmE9fK4fGaV8iw8xOblF69VyoJ bx1+uHFUFonJv201TgBqtzzoeY8lAizVhL6nkavE4164zgWlPaglVm+nkeXQIVG66CfeVlIaQ19 V3caJ4lYCeQqGSWxfd2j+cbYCCvw== X-Received: by 2002:a17:903:2990:b0:2cc:f4d4:29a7 with SMTP id d9443c01a7336-2ccf4d46bd1mr64154525ad.24.1783612451048; Thu, 09 Jul 2026 08:54:11 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d1edb0sm46019575ad.53.2026.07.09.08.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 08:54:10 -0700 (PDT) Sender: Guenter Roeck Date: Thu, 9 Jul 2026 08:54:09 -0700 From: Guenter Roeck To: Nuno =?iso-8859-1?Q?S=E1?= Cc: Fred Chen , "Torreno, Alexis Czezar" , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Shuah Khan , Jonathan Cameron , Wensheng Wang , Frank Li , Brian Chiang , Cosmo Chou , Dixit Parmar , Eddie James , Antoni Pokusinski , Thorsten Blum , Ashish Yadav , Syed Arif , ChiShih Tsai , Abdurrahman Hussain , "Paller, Kim Seer" , Colin Huang , Yuxi Wang , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hwmon@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH 2/2] hwmon: (pmbus) Add driver for Analog Devices MAX20912 and MAX20916 Message-ID: <5b865eed-ae58-47fc-8d80-e14a76a93050@roeck-us.net> References: <20260707122701.751878-1-fredchen.openbmc@gmail.com> <20260707122701.751878-3-fredchen.openbmc@gmail.com> <20260708-true-carp-of-champagne-a0dcca@quoll> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Jul 09, 2026 at 09:54:22AM +0100, Nuno Sá wrote: > > > > Based on the MAX20912/16 specs on my hand, these chips do not support > > PMBUS_PHASE (0x04). Furthermore, the spec only indicates support for VID mode > > and does not provide m/b/r. Therefore, some of the features you mentioned might > > be specific to the MAX20826 series. > > I see, phases are not supported using standard PMBUS. > As mentioned in my other e-mail, it can still be supported by the driver. That is what the chip drivers are for, after all. > > > > Regarding enabling VOUT via GPIO, our platform handles this via the CPLD as > > part of the hardware power sequencing. Managing this pin through the driver is > > not a requirement for our system. > > But we cannot assume all systems will behave like the above. But now i > do wonder about controlling the GPIOs in the driver. In your system you > clearly did not need to do it. In mine (testing with a rpi) I had to > use a GPIO (well I could have used hogs or pinctrl). But if you control the pin > you do gain the ability to turn off the regulator. If you don't it's always on > (which might be indeed the bulk of the real usecases for these systems). > Agreed. I don't really like it, but if the chip and some specific hardware mandate it, it should be supported. However, that code also needs to be tested - an untested implementation would be worse than no implementation. Note to anyone from Analog listening: It is really unfortunate that I, as subsystem maintainer, do not have access to datasheets. That means I have to rely on assumptions and can not really provide actionable feedback other than guesswork based on the PMBus standard. That feedback may and likely will miss essential details. Thanks, Guenter