From: Guenter Roeck <linux@roeck-us.net>
To: Osama Muhammad <osmtendev@gmail.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] adm1266.c: Drop error checking for debugfs_create_dir
Date: Thu, 25 May 2023 11:17:17 -0700 [thread overview]
Message-ID: <5b8700fb-d455-469e-a34d-62cb6f68d324@roeck-us.net> (raw)
In-Reply-To: <20230525160827.15285-1-osmtendev@gmail.com>
On Thu, May 25, 2023 at 09:08:27PM +0500, Osama Muhammad wrote:
> This patch fixes the error checking in adm1266.c.
> The DebugFS kernel API is developed in
> a way that the caller can safely ignore the errors that
> occur during the creation of DebugFS nodes.
>
> Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
Confusing. Is this v3 of the patch ?
Guenter
> ---
> drivers/hwmon/pmbus/adm1266.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
> index 1ac2b2f4c570..184d75269d2b 100644
> --- a/drivers/hwmon/pmbus/adm1266.c
> +++ b/drivers/hwmon/pmbus/adm1266.c
> @@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
> return;
>
> data->debugfs_dir = debugfs_create_dir(data->client->name, root);
> - if (!data->debugfs_dir)
> - return;
>
> debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
> adm1266_state_read);
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-05-25 18:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 16:08 Osama Muhammad
2023-05-25 18:17 ` Guenter Roeck [this message]
2023-05-25 18:22 ` Osama Muhammad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b8700fb-d455-469e-a34d-62cb6f68d324@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osmtendev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®