From: Markus Elfring <Markus.Elfring@web.de>
To: Qiujun Huang <hqjagain@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Michael Ellerman <mpe@ellerman.id.au>,
Oliver O'Halloran <oohall@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v5 1/2] powerpc/powernv: Return directly after a failed of_property_read_u64_array() in opal_add_one_export()
Date: Mon, 6 Apr 2020 16:56:34 +0200 [thread overview]
Message-ID: <5b8b22bb-8236-1c88-5335-a0444aed79a4@web.de> (raw)
In-Reply-To: <20200406125242.4973-2-hqjagain@gmail.com>
> We don't need to go to the labal of out …
Please avoid a typo for this change description.
> fails, as there is nothing to do. Just return.
I suggest to reconsider also this wording.
Return directly after a call of the function “of_property_read_u64_array”
failed at the beginning.
> And we can …
Do such words indicate that even this patch approach should be split
into further update steps?
Regards,
Markus
next prev parent reply other threads:[~2020-04-06 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 12:52 [PATCH v5 0/2] Fix opal_add_one_export Qiujun Huang
2020-04-06 12:52 ` [PATCH v5 1/2] powerpc/powernv: Remove redundant assignments to attr and name Qiujun Huang
2020-04-06 13:40 ` [PATCH v5 1/2] powerpc/powernv: Remove two unnecessary variable initialisations in opal_add_one_export() Markus Elfring
2020-04-06 14:56 ` Markus Elfring [this message]
2020-04-06 12:52 ` [PATCH v5 2/2] powerpc/powernv: Add NULL check after kzalloc in opal_add_one_export Qiujun Huang
2020-04-06 14:00 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b8b22bb-8236-1c88-5335-a0444aed79a4@web.de \
--to=markus.elfring@web.de \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=hqjagain@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®