From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A07E03EF0CB for ; Thu, 5 Feb 2026 14:44:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770302694; cv=none; b=VU4mEPrasW0zjoxqmm2A9iZu1NMxVfIteKNekDCAAZA13k3aQZu2cenng4eLsCIbNPwiNWB8oPwz/rY1lhA5BpjJOF1j1eu/nHolra1bntP76v30ZYIsaRTmtElWH3AkE5PUlNjUSDpYgW0aoPL1Svzl5/5bbNrOm+9NYGCiBm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770302694; c=relaxed/simple; bh=Ip8egWymmNIZRQpL/yLSLzyJGyXIDWQvB7EnInDwlQw=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=nJRRLXaa+hqraxf9Ah6jnlD1qAT/pcX0yUA8CvUjKJjEc7dTNJ7Q23m5VyFop9+j6SD0unXiRH0h0DrL0xAr4VNFXmE7ebjPNO3XrLSw2ZMGnirEKbPT9FZY7v4sK2kMZ0L442qCq+DaHkCgA5L61Y1yXkBtRACED5O9gMk1ooY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com; spf=pass smtp.mailfrom=cogentembedded.com; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b=2vEPCYcK; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b="2vEPCYcK" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b8e9c8ada38so148975466b.0 for ; Thu, 05 Feb 2026 06:44:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20230601.gappssmtp.com; s=20230601; t=1770302692; x=1770907492; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=yGuGV1Rjxy0b39caRNbzTsFTwfMEJia85m6jesueSeQ=; b=2vEPCYcK1Py+VhyJltVRdjpNoH0RgQmPypEbfBTnBITFsspwaG5RCzqwoUR1gCLGF5 I+jqr7fcYUQP8KC74QnbKGD5d6FTHwyzYq29a1QZzVwHamlaW93gwxbwDnzXQmMhsE4c LUcp9HauZjUz9C/uvoBxIOVVh3L7MNIqNjLchouV5+7N1VxYiOB56GfMRXZpXlQSarDh FbGfzjx5ROLLd1smPaxH1eBontPSHsOLhOVNfe/IKnGdfUpfqp9OO9UQhBj3G3CDjxfU OC/D8q2sNS6Hbfbshydj+0w/jeWJZx3sT21qiyh1g1GphK+KCFww6lkdMPTbR/YlGvr6 Y/zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770302692; x=1770907492; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yGuGV1Rjxy0b39caRNbzTsFTwfMEJia85m6jesueSeQ=; b=DMDIdt78uwHuZrzZzLy2w7GcrXdtQ+JW03w2ikoxtfXERgXtMl6zHIdExD8Hn9bbGz th9FY2dK0YBeXHqM9cQ2yalEtxyeSYvPgnU/FFDFDqYtZQtzAUHP3qGSjT61RjJHnXoe IaOGa0KbSiy9vCicsSIwShmZVc0Xofmer6DlKqxbywHWg7caWq4/y3hA9/fZCyfrtAuJ /vgbnozbxpQiIXC5sC/0dBmHw+zw1wmEI0MhsHUcf0Qsn38hZwfCyaZyXE7vEJD2J+7j QlpQC7AEcaMShQQeNBoTyYIQkFT7T/KPGezKSb/KXYFgGQmSiHl5jN542LF9LIpw7UTC GZFA== X-Forwarded-Encrypted: i=1; AJvYcCU45y+b93GhoAbFImZvbsNMsDa94Af9z3lXsZUJGjOFjnworoyOggeUw9tYAhkqktYxy/KszEQYzt8fTVo=@vger.kernel.org X-Gm-Message-State: AOJu0YzMu/AMdkzh/Oidb1yUOdAGIj8nzZOW/HfLTZWjIg5auGsA8Exy AcMOXmUlhjaBD1Se4tiY6umS2FYZzeBz+bphnlG2Nz5svqvOSK6mfg4xcWGJqbboNfk= X-Gm-Gg: AZuq6aLQZgdddBH7nkbLJoB9iQv7sR+XqfT8+x6BasC2ha4THLtrRqNZIAANVzniI2z /n2fOZgJPX4NglgtAPuGMDWFV6zPo7rk7ucyhBBOZcNX7OJB2jX0dT/zulo8f3epRkqsNGbQ+SW cjK4xGQ+Ve9NGpsB/iTS5goG4qXFl2iCKtCQFGD5U9J6O1cwqeFfqmU5EzONLEnMccmy/QLCSpU GiMB0gOvhzOIjQx4EkgmLUSi5PMblfJTBHvVev5RLIP0V3XtzpVoVzt+HpeIcjMg34WGQ/Revm+ nGgenkCiJL8rn2WYQAFMCfRNUi59q6RYSy1mfWNy6hVS0MmHoRNBixaMfhaQ9fTMn6Pg57W49/b 7KFnvFLyKJBXX7svzW8nTvtdqefoj2Rc/uOYPGCWZRKVMiBO+X2UxKABUtqEzWdJ2e+AMrDDT4i 0f5ubY0wfkgCzsRyHrM7I5dAjcNyQZL6wsMzwg X-Received: by 2002:a17:907:928e:b0:b86:f194:9eec with SMTP id a640c23a62f3a-b8e9f063ademr467878766b.18.1770302691747; Thu, 05 Feb 2026 06:44:51 -0800 (PST) Received: from ?IPV6:2a02:810a:b98:a000::159a? ([2a02:810a:b98:a000::159a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8ea00455adsm236432166b.60.2026.02.05.06.44.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Feb 2026 06:44:51 -0800 (PST) Message-ID: <5b8bcf37-5cd0-4c32-b0ba-3386142b7795@cogentembedded.com> Date: Thu, 5 Feb 2026 15:44:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: renesas: rswitch: fix forwarding offload statemachine From: Nikita Yushchenko To: Michael Dege , Yoshihiro Shimoda , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: "netdev@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20260205-fix-offloading-statemachine-v1-1-640224a531d0@renesas.com> <3b1405cd-6c7f-4883-95fb-151cab223a68@cogentembedded.com> <25ff0841-545b-433a-8e88-6e463ea718e7@cogentembedded.com> <237bee8b-a7cf-4c14-9946-8bf72dbddde5@cogentembedded.com> Content-Language: en-US, ru-RU In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit WBR, Nikita Yushchenko, System Software Engineer @ Cogent Embedded 05.02.2026 15:41, Nikita Yushchenko wrote: >>> The driver was originally designed to enable hardware forwarding when not less than two ports are in >>> forwarding state. When only one port has hw forwarding, there is no destination to forward. >>> >>> Nikita >>> >> >> The current driver allows Linux to use the bridge port as local port to the bridge. The offloading >> Also supports switching traffic to Linux through the bridge port. Therefore, the offloading shouldn't >> Be dropped if only one external port is up on the bridge. > > "Offloading" means - forward a frame from one hw port to other hw port without inserting it into CPU > queue. Offloaded frame is never visible to software bridge. > > There is code that allows offload only if the linux bridge device used to connect rswitch ports does not > have anything else.  If it has something else, offloading is disabled (because there is no way to know > when a frame can be processed within rswitch hw without sending it to cpu). A frame being received by bridge device itself is not a subject for offload, ever.