From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753315AbcHWQnW (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 Aug 2016 12:43:22 -0400
Received: from mail-pa0-f53.google.com ([209.85.220.53]:36808 "EHLO
        mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752824AbcHWQnT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 Aug 2016 12:43:19 -0400
Subject: Re: [PATCH -next] ARM: pxa: remove duplicated include from spitz.c
To: Robert Jarzmik <robert.jarzmik@free.fr>
References: <1471965498-7824-1-git-send-email-weiyj.lk@gmail.com>
 <87y43npi5l.fsf@belgarion.home>
Cc: Daniel Mack <daniel@zonque.org>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
From: Wei Yongjun <weiyj.lk@gmail.com>
Message-ID: <5b9111f3-1c9d-f551-af06-566adceaef38@gmail.com>
Date: Wed, 24 Aug 2016 00:43:07 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <87y43npi5l.fsf@belgarion.home>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Robert,
 

On 08/24/2016 12:24 AM, Robert Jarzmik wrote:
> Wei Yongjun <weiyj.lk@gmail.com> writes:
>
>> Remove duplicated include.
> How so duplicated ? Can you elaborate please ?
>
> Moreover, how do you do think symbol_get() can stay in spitz.c without having
> this include ?

file linux/module.h included twice as following:

#include <linux/kernel.h>
#include <linux/module.h>       /* symbol_get ; symbol_put */
...
#include <linux/module.h>

So I think we can remove the dup include.

Regards,
Wei Yongjun