From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Bo Liu <liubo03@inspur.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mst@redhat.com" <mst@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [PATCH] vhost-scsi: convert sysfs snprintf and sprintf to sysfs_emit
Date: Tue, 31 Jan 2023 07:00:24 +0000 [thread overview]
Message-ID: <5b9bb698-dbb9-60af-10ee-767d9fad83d2@nvidia.com> (raw)
In-Reply-To: <Y9gbe+Pr5AcGbcta@fedora>
On 1/30/23 11:33, Stefan Hajnoczi wrote:
> On Sun, Jan 29, 2023 at 04:11:45AM -0500, Bo Liu wrote:
>> Follow the advice of the Documentation/filesystems/sysfs.rst
>> and show() should only use sysfs_emit() or sysfs_emit_at()
>> when formatting the value to be returned to user space.
>>
>> Signed-off-by: Bo Liu <liubo03@inspur.com>
>> ---
>> drivers/vhost/scsi.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
prev parent reply other threads:[~2023-01-31 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 9:11 Bo Liu
2023-01-29 10:32 ` Simon Horman
2023-01-30 19:33 ` Stefan Hajnoczi
2023-01-31 7:00 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b9bb698-dbb9-60af-10ee-767d9fad83d2@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubo03@inspur.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®