From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D7392F9D83 for ; Thu, 19 Mar 2026 09:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773912281; cv=none; b=Ps0Lel/+mjoxeBG2f1PqhWFML9umOxV2WkDAIkGm/a5SNU2zHTWnUGCGGp0jK/M77Uh59IXtMyYL4KhccQu2FcGOb6g7QZAMaUrgLiEbcFHI/TmisgUJX/wvvFjuwIxXQfa6mQzKnny7XV9OjUMNLQXNxDpSD0cn35KwE6X5iwg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773912281; c=relaxed/simple; bh=GxsiZ67ycv/oHYv3HInSJ9NnmjuYatXtX4GD7yA/JwU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Fevp1alByabmvzjOiJiMj7PqgEjzMCDba5I6fdZoXcJSFafLcPONHIZIlGOOamoFqiWXcpLU1mOKSsFiauy8CB0jEpy340cspoALiFXn3VvUK8URKXt0iDjBOOeARaoSAfKsCwQdFeMM8RfDu5nDkdcYNeWBFTuW4GVsH1TK07I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HzXlmTWc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=epgXVxU1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HzXlmTWc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="epgXVxU1" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62J73xs41567106 for ; Thu, 19 Mar 2026 09:24:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TckbxMyJi7AhkdcEUyt8X0pVJFCrYNyjJm/tTCzLAwo=; b=HzXlmTWc1wDkOb5/ pkuFMz9+J40TgGDM/f58I4EfyeKayoD8ImOTEiyGFcD4774Owcrfvdfu4IcdlYaF 9xnfhXTnhcpFNF64Fm8wfIdEikCP34A07rkHXhgJgNXe4QB5FCwd/L4YUAgiFQRv Mpl8qTblT4u1kRAIXqIyTNNXvOw11udGgBecU6ok6E8b6NSGVjolJseQysTRx/Mq 2eO44CSBXmHwS0OF2psSt2bgm7A6IOc6bl3jDofZSgQMhiaY1gYcbeRGC7wfsS1C bECX0PVTwNwX+sTme3MPhxR1fuh/CxPg9S7IjeL5cJEATIndxgoeluCWHcRLoq6R /F5OpA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d0akxgswk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 09:24:38 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb456d53a5so63425385a.2 for ; Thu, 19 Mar 2026 02:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773912277; x=1774517077; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TckbxMyJi7AhkdcEUyt8X0pVJFCrYNyjJm/tTCzLAwo=; b=epgXVxU1OHIjFlvm213+FpDFsMIRz0J+1gunxb0jNe83zF5rz5Rqm3jBScQdCVlDYM fYFpI6H4FxEF5/AO39lvRf9h+CQf21YzwfXWRw1+sbrZd7p+zmKvAv+RG0IdKw6K1P6i MKh5UN9qs8E8KBmTkrLwjcYcH+XwFGPPK515kr1B5mtAlvaEXXaA/W7e0JSSwz6kNFmq yAItEe9sX6Zkk+Mr0KufuaQHefUiIWeUkNY1Dd77kkjvWlyIG9Ykt85YE9mC7LwLkGV3 OarysFut93toflKK+Iy6/SPwtcBE1zwSdly1E34DO6BlnmjJHyLzW/5puhzg9jVHTIq0 atmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773912277; x=1774517077; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TckbxMyJi7AhkdcEUyt8X0pVJFCrYNyjJm/tTCzLAwo=; b=WzGKRJU+o/yoWjNCsNCI8M47uePPImtr7JJdSU8XDyQtRvbgHD/+oc62KDjR+d2UoC A0RxF67Xrfy6+mkv+F1zWZwJRsyq+c2CZ4WIDyihmqlQMtw9UQYRMsv1Hb22AOf/h0vD m8irvfOjHb4hmCCJx7F63nZZJJahnp9C0rOI5cBTyLPknBZFhmVa0tF3tB7Tph1iH6Xh gZpAAyBv8IdcbE/lFTHCGoHrWkFpsInxthD9/6nScZ4unj46HNN7HPiy/QrTKiExiPte jDccZIpF+CV6IEAMuTSBdsCg7R8eVHTjjOOY5q7nQeYaVletTgt4kUv4YnpVG3un+wmi gSTQ== X-Forwarded-Encrypted: i=1; AJvYcCWqGyu6J7RkFd/c/RgtDyghEWbYKujXomu2RayP8aKf01MPuR/Aq5pLkDYOg9O9a9ZiunTCbhzIcfjADGY=@vger.kernel.org X-Gm-Message-State: AOJu0YwoeWVmYuu8xZ0hSHh1wl4zVD9gfMgHZQ18wU4ReyXVLKyOZDqC VhRDV6Ri01DH4HuOnFMDWVOqrH/2Qjp66f5aVZLRTXl/ljh6NK7/FtcXwjt0uPwjJ7or/1da7tw +CTy+qdapu9yYEByyF0e83P0KXpbZi8QerC/4+Z1WaA8doklWHFjVhXuQvPa8hah3yAE= X-Gm-Gg: ATEYQzyBHf3DH5PhhNZRL2B2Kv1Ud6awV+L2GKr5lEOjdTxgL5SR2Quy95Ft2Ocxzeo Y3h3sZmUFWZ4zzQVYfbBX+8lc1yeQozmuP5LHCwtr5aXsb921oPxMDxtGvUrehxC1u/OmUUjQ/q G0dvWuZvbVSFKWalpUDEJRbfX1DMNsBqO3Ozih72tnf4PynP7ctK3EhIUeWG+TEeRCM0Aqj8DgS uwsF52BZEz4Fk5AVBsneIOnyL7Kv1qxq3IlaFpDS6PbxJQDd5Nm22rQm5eHV91xTNoQNLVOGd3x ztmTAVGgXJOKhDGeNXJU7Thpgu4QlxmPjHGwoER2QYlQJ6c6S7NSaw0/nzOKCQ3XPGxhEpfeN8L sZQB4xVowY+Oyvg4yFJSqb4xfr5yYnzJ0pqNwM3UpfaFoYyIzZlX3QNORf4FcqHi5VTnRF/ZpIQ KVPr4= X-Received: by 2002:ad4:5e8d:0:b0:89a:4741:2147 with SMTP id 6a1803df08f44-89c6b728303mr74824516d6.8.1773912277431; Thu, 19 Mar 2026 02:24:37 -0700 (PDT) X-Received: by 2002:ad4:5e8d:0:b0:89a:4741:2147 with SMTP id 6a1803df08f44-89c6b728303mr74824206d6.8.1773912276858; Thu, 19 Mar 2026 02:24:36 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f13ed066sm410962166b.4.2026.03.19.02.24.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 02:24:36 -0700 (PDT) Message-ID: <5b9ce996-5cdd-40da-9851-2e7c8a40abae@oss.qualcomm.com> Date: Thu, 19 Mar 2026 10:24:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/4] phy: qualcomm: add MSM8974 HDMI PHY support To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Vinod Koul , Neil Armstrong , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-phy@lists.infradead.org, Dmitry Baryshkov References: <20260314-fd-hdmi-phy-v5-0-58122ae96d3b@oss.qualcomm.com> <20260314-fd-hdmi-phy-v5-4-58122ae96d3b@oss.qualcomm.com> <5a464fca-7be5-44a6-b124-7b80ea859a9e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDA3NCBTYWx0ZWRfX+GQ8tIpN+8Px MQ235XS35LcSpSLVESGC1uBHpkUQk0V0L1ro1BgWm70p4IqIBqR5iMo/x143GxJjRV0cRgkuJke kQjNqhEjCi42RsILkc34f0VjvYgePKbKDRzBBhBQ2x5RErVUKz5qOlGTsMwO2BYBCsCkQvX6/V9 r4QVbE4PhDeG0nTA9bth9OEzXPaJbrc0bICeEZ9PVjLEwqU9TXNud6YcsIuVOVyXE/tSm7DgzyO PeREw6YKvZGrXXj4XKWvF/d3FyslRhmUp6zzUNjKzMZG5WoKkUzTzyXu2sRRC2oIldBTI+eMwvu 4QNeoKqb+TudVACsYHJIZkLuUmtAaNogpvt6BToXVwPxpZM5OXjqJFezKSRCs1djq0kQK5akkZ7 ZU8k6dx5IyNdB8CPOrBKxbyeGNJR3S5yNjGV6/xFFZ6xXxRpyikir7zgB67dLkXqyLrURO1vKUb YChZlsLdqsjHF5nCa+w== X-Proofpoint-GUID: VsAHQwhTluxWF0xvhmnCLQioQglCPcZw X-Authority-Analysis: v=2.4 cv=ZeMQ98VA c=1 sm=1 tr=0 ts=69bbc0d6 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=NujWGTqPcDVEmWsEH4UA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: VsAHQwhTluxWF0xvhmnCLQioQglCPcZw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-19_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190074 On 3/18/26 6:15 PM, Dmitry Baryshkov wrote: > On Wed, Mar 18, 2026 at 10:22:08AM +0100, Konrad Dybcio wrote: >> On 3/14/26 6:06 AM, Dmitry Baryshkov wrote: >>> From: Dmitry Baryshkov >>> >>> Add support for HDMI PHY on Qualcomm MSM8974 / APQ8074 platforms. >>> >>> Signed-off-by: Dmitry Baryshkov >>> Signed-off-by: Dmitry Baryshkov >>> --- [...] >> I don't know if it's a good direction, but maybe: >> >> const unsigned long max_rate = HDMI_8974_VCO_MAX_FREQ / HDMI_8974_COMMON_DIV; >> >> clamp(req->rate, max_rate / 6, max_rate) > > Note, it is clamp (min_rate / 6, max_rate) see, indeed confusing ;) But I suppose we don't have a better way of specifying that so whatevs Konrad