From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751259AbdBBJrh (ORCPT ); Thu, 2 Feb 2017 04:47:37 -0500 Received: from exsmtp01.microchip.com ([198.175.253.37]:30869 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751153AbdBBJrd (ORCPT ); Thu, 2 Feb 2017 04:47:33 -0500 Subject: Re: [PATCH] mtd: spi-nor: cqspi: remove redundant dead code on error return check To: Colin King , Marek Vasut , David Woodhouse , Brian Norris , Boris Brezillon , Richard Weinberger , References: <20170131155317.20106-1-colin.king@canonical.com> CC: , From: Cyrille Pitchen Message-ID: <5b9ebe65-d572-0162-3984-8e7a7800148d@atmel.com> Date: Thu, 2 Feb 2017 10:47:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170131155317.20106-1-colin.king@canonical.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: =?utf-8?B?SDRzSUFBQUFBQUFBQytOZ0ZuckNLc1dSV2xHU1dwU1htS1BFeHNYQ3hlWERv?= =?utf-8?B?cXZQTURuQzRQL0hoWGZZTFE2OFdNaGk4WHQxTDV2RmtRdHJtUzBtcnB6TWJM?= =?utf-8?B?SDFsclRGNVYxejJDeDJOeTFqdHppNjV4Nnp4ZVNkYnhnZE9EMW1OZlN5ZVR6?= =?utf-8?B?WmRKSFJZK2VzdSt3ZW0xZG9lV3hlVXU5eGMxNmh4K2ROY2dIc1VheVplVW41?= =?utf-8?B?RlFtc0dXYys3Mk11dU1kWmNXaW1md1BqZmZZdVJpNE9JWUZsakJJdk5oNW42?= =?utf-8?B?V0xrNUJBV2lKSG9uanVCQ1NRaElyQ1lTZUpBWXhzclNFSkl3RmJpY2VjQlJo?= =?utf-8?B?Q2JXY0JSWXZLVEY4d2dOcHVBb2NUYkIwZkJhbmdGYkNRZXIyOW5BN0ZaQkZR?= =?utf-8?B?a25oemF4dzVpaXdwRVNNeC91b29Kb2taUTR1VE1KMkRMT0FYc0pMYmZ2d2pV?= =?utf-8?B?eXdFMFUxTmkvUzU5aVBIeUVzMWJaek5EckZXVFdOaXlBc3lXRUFpVTZQajhp?= =?utf-8?B?dzNDZHBKNGVmUWxsRzBuY1hqNlJYWUkyMTdpN0pyTjdEQTFQM2Z0WUlXd3RT?= =?utf-8?B?VzJ2OW9IWmV0SWJEdll6d0poMjByc21UR1JDY0oybDNqd2FEbVU3U3N4NjJF?= =?utf-8?B?RFZFMlVSTU9DRTB3VEdDVm5JZmxnRnNMVnM1QmN2WUNSZVJXanRMT0huMjV3?= =?utf-8?B?bUs1cmhMT0hnYUZlYm5KR2dXNXVZbWFlWG5KKzdpWkdTSHlyN21DODlTLzhF?= =?utf-8?B?S01rQjVPU0tPK1puWk1paFBpUzhsTXFNeEtMTStLTFNuTlNpdzh4eW5Cd0tF?= =?utf-8?B?bncydndEeWdrV3BhYW5WcVJsNWdBVERVeWFpWVB6RUtNRUI0K1NDRzhVU0Ex?= =?utf-8?B?dmNVRmlibkZtT2tUK0ZLT2tsRGh2OGwrZ2hBQklJcU0wRDY3M0VxT29sREJ2?= =?utf-8?B?eDIrZ0hFOUJhbEZ1WmdsRS9CYWpHTWRESm83SFRFSXNlZmw1cVZKQXB6SUFn?= =?utf-8?B?UUhqSzBaeERrWWxZZDQwa0QwOG1Ya2xjR3RlQVYzQUJIVEJ6OGRnRjVRa0lx?= =?utf-8?B?U2tHaGk1QmJqdDVyN3ZYbmRMYy9LRkhHdjI5bWNydVpuWEhWblJxQ05oMHJz?= =?utf-8?B?OHFyYSs4ZjNib2dlRzlrdXZhLzkrTHhucjkrWnhqZFZsdHZUVlI5WThxcEdm?= =?utf-8?B?OGlybmVkKzB2NmFHWWUxWnVZK2VSVDZ6ZlJCN3RNOUE1cGZDWTlrajZ4NW56?= =?utf-8?B?ekgwZi96L21wVjdQNmV2OCtYay9na1BKbkp1WDNFaDE3VXRkNFViNTBxMjZQ?= =?utf-8?Q?U33zsosRRnJBpqMRcVJwIAwyCEPncDAAA=3D?= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 31/01/2017 à 16:53, Colin King a écrit : > From: Colin Ian King > > Checking for ret < 0 is redundant because a previous check on ret > being non-zero already handles the ret < 0 case. Remove the redundant > code. Found by CoverityScan, CID#1398863, CID#1398864 > > Signed-off-by: Colin Ian King Applied to the github spi-nor tree. Thanks! > --- > drivers/mtd/spi-nor/cadence-quadspi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c > index 3fb7be8..9f8102d 100644 > --- a/drivers/mtd/spi-nor/cadence-quadspi.c > +++ b/drivers/mtd/spi-nor/cadence-quadspi.c > @@ -893,7 +893,7 @@ static ssize_t cqspi_write(struct spi_nor *nor, loff_t to, > if (ret) > return ret; > > - return (ret < 0) ? ret : len; > + return len; > } > > static ssize_t cqspi_read(struct spi_nor *nor, loff_t from, > @@ -913,7 +913,7 @@ static ssize_t cqspi_read(struct spi_nor *nor, loff_t from, > if (ret) > return ret; > > - return (ret < 0) ? ret : len; > + return len; > } > > static int cqspi_erase(struct spi_nor *nor, loff_t offs) >