From: "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] rds: ib: force endiannes annotation
Date: Mon, 29 Apr 2019 21:25:15 -0700 [thread overview]
Message-ID: <5ba055e9-5221-bff2-fdd2-d4b837c95ce1@oracle.com> (raw)
In-Reply-To: <1556593977-15828-1-git-send-email-hofrat@osadl.org>
On 4/29/19 8:12 PM, Nicholas Mc Guire wrote:
> While the endiannes is being handled correctly as indicated by the comment
> above the offending line - sparse was unhappy with the missing annotation
> as be64_to_cpu() expects a __be64 argument. To mitigate this annotation
> all involved variables are changed to a consistent __le64 and the
> conversion to uint64_t delayed to the call to rds_cong_map_updated().
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
>
> Problem located by an experimental coccinelle script to locate
> patters that make sparse unhappy (false positives):
> net/rds/ib_recv.c:827:23: warning: cast to restricted __le64
>
> V2: Edward Cree <ecree@solarflare.com> rejected the need for using __force
> here - instead solve the sparse issue by updating all of the involved
> variables - which results in an identical binary as well without using
> the __force "solution" to the sparse warning. Thanks !
>
> Patch was compile-tested with: x86_64_defconfig + INFINIBAND=m, RDS_RDMA=m
>
> Patch was verified not to change the binary by diffing the
> generated object code before and after applying the patch.
>
Thanks. I was worried about this macro magic o.w
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
next prev parent reply other threads:[~2019-04-30 4:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 3:12 Nicholas Mc Guire
2019-04-30 4:25 ` santosh.shilimkar [this message]
2019-04-30 11:43 ` Christoph Hellwig
2019-04-30 12:54 ` Nicholas Mc Guire
2019-05-01 21:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ba055e9-5221-bff2-fdd2-d4b837c95ce1@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=davem@davemloft.net \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®