From: Andrew Lunn <andrew@lunn.ch>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Xu Liang <lxu@maxlinear.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: phy: mxl-gpy: add MxL862xx support
Date: Tue, 18 Nov 2025 17:44:17 +0100 [thread overview]
Message-ID: <5ba651a4-4d66-4ab9-b253-95995e8a42bd@lunn.ch> (raw)
In-Reply-To: <aRvdaxBjIOzspkCa@makrotopia.org>
On Tue, Nov 18, 2025 at 02:43:55AM +0000, Daniel Golle wrote:
> On Tue, Nov 11, 2025 at 02:32:38AM +0100, Andrew Lunn wrote:
> > On Mon, Nov 10, 2025 at 10:35:00PM +0000, Daniel Golle wrote:
> > > Add PHY driver support for Maxlinear 86252 and 86282 switches.
> > > The PHYs built-into those switches are just like any other GPY 2.5G PHYs
> > > with the exception of the temperature sensor data being encoded in a
> > > different way.
> >
> > Is there a temperature sensor per PHY, or just one for the whole
> > package?
> >
> > Marvell did something similar for there SoHo switches. The temperature
> > sensor is mapped to each of internal PHYs register space, but in fact
> > there is a single sensor, not one per PHY.
>
> It very much looks like it is also done in the way your are describing.
> The temperature reading on all 8 PHYs is almost exactly the same, even
> if eg. port 1 and 2 are connected to 2.5G link partners and doing some
> traffic and all other ports are disconnected the temperature stays the
> same value for all of them.
>
> Should this hence be implemented as a single sensor of the phy package?
If you have a PHY packages, why not.
For the Marvell PHYs, so such thing existed. All we see is individual
PHYs. And the registers are the same for discrete devices. So it was
simpler to just export what is effectively the same senor multiple
times.
Andrew
next prev parent reply other threads:[~2025-11-18 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 22:33 [PATCH net-next 1/2] net: phy: mxl-gpy: add support for MXL86211C Daniel Golle
2025-11-10 22:35 ` [PATCH net-next 2/2] net: phy: mxl-gpy: add MxL862xx support Daniel Golle
2025-11-11 1:32 ` Andrew Lunn
2025-11-18 2:43 ` Daniel Golle
2025-11-18 16:44 ` Andrew Lunn [this message]
2025-11-11 16:33 ` [PATCH net-next 1/2] net: phy: mxl-gpy: add support for MXL86211C kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ba651a4-4d66-4ab9-b253-95995e8a42bd@lunn.ch \
--to=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®