From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Aaron Tomlin <atomlin@atomlin.com>, <mingo@redhat.com>,
<peterz@infradead.org>, <juri.lelli@redhat.com>,
<vincent.guittot@linaro.org>
Cc: <paulmck@kernel.org>, <dietmar.eggemann@arm.com>,
<rostedt@goodmis.org>, <bsegall@google.com>, <mgorman@suse.de>,
<vschneid@redhat.com>, <zhanxusheng1024@gmail.com>,
<neelx@suse.com>, <chjohnst@mail.com>, <mproche@mail.com>,
<sean@ashe.io>, <steve@abita.co>, <rishil1999@outlook.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 tip/sched/core 6/6] sched/debug: Introduce per-CPU debugfs files
Date: Fri, 30 Oct 2026 11:35:03 +0530 [thread overview]
Message-ID: <5ba8f652-6f82-4384-9343-1ff093880c39@amd.com> (raw)
In-Reply-To: <20261030013817.753804-7-atomlin@atomlin.com>
Hello Aaron,
On 10/30/2026 7:08 AM, Aaron Tomlin wrote:
> +static __init void debugfs_cpu_init(void)
> +{
> + struct dentry *d_cpu_dir;
> + unsigned long cpu;
> + char buf[16];
> +
> + d_cpu_dir = debugfs_create_dir("cpu", debugfs_sched);
Missing an error handling here in case this fails?
> +
> + for_each_possible_cpu(cpu) {
> + struct dentry *d_cpu;
> +
> + snprintf(buf, sizeof(buf), "cpu%lu", cpu);
> + d_cpu = debugfs_create_dir(buf, d_cpu_dir);
> +
> + debugfs_create_file("debug", 0444, d_cpu, (void *) cpu, &sched_debug_cpu_fops);
> + }
> +}
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2026-10-30 6:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 1:38 [PATCH v10 tip/sched/core 0/6] " Aaron Tomlin
2026-10-30 1:38 ` [PATCH v10 tip/sched/core 1/6] sched: Annotate rq->rd with __rcu and update lockless readers Aaron Tomlin
2026-10-30 4:41 ` K Prateek Nayak
2026-10-30 13:51 ` Aaron Tomlin
2026-10-30 1:38 ` [PATCH v10 tip/sched/core 2/6] sched/debug: Protect lockless rq->rd access in print_dl_rq() Aaron Tomlin
2026-10-30 1:38 ` [PATCH v10 tip/sched/core 3/6] sched/debug: Protect lockless rq->curr access in print_cpu() Aaron Tomlin
2026-10-30 1:38 ` [PATCH v10 tip/sched/core 4/6] sched/debug: Protect p->mm access in sched_show_numa() Aaron Tomlin
2026-10-30 1:38 ` [PATCH v10 tip/sched/core 5/6] sched/fair: Use list_for_each_entry_rcu() in print_cfs_stats() Aaron Tomlin
2026-10-30 1:38 ` [PATCH v10 tip/sched/core 6/6] sched/debug: Introduce per-CPU debugfs files Aaron Tomlin
2026-10-30 6:05 ` K Prateek Nayak [this message]
2026-10-30 13:07 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ba8f652-6f82-4384-9343-1ff093880c39@amd.com \
--to=kprateek.nayak@amd.com \
--cc=atomlin@atomlin.com \
--cc=bsegall@google.com \
--cc=chjohnst@mail.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mproche@mail.com \
--cc=neelx@suse.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rishil1999@outlook.com \
--cc=rostedt@goodmis.org \
--cc=sean@ashe.io \
--cc=steve@abita.co \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zhanxusheng1024@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®