From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 025F02FB09B for ; Thu, 18 Sep 2025 10:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758190866; cv=none; b=WHqP7O7kq/e/1NETaEeeqDoC4tB0SO9Vb6FjOscYPbhM57arpDQSW9zm8Q5OG6wwGTPc5iJM2OvDFZ/Ph78Su+Oh2qEFRX4kVp8E1N91Ohbfk9Jvy7dQPqWJnlSrgYCT5hxiq+ctKKh+Hlx9A5o2GucvWMY1/KeOxeBhyPxLznM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758190866; c=relaxed/simple; bh=lcbZuTlRYeYw/+6+qtA8Zj+ABLvsvhjoXWyh7W0PIeA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qJd8Gf2vgtXC6fcx71WBVlY098sdXzELWFAvr3kTnUOT4M8QxP/Dn6ojtsynfpTtL6BM1ynfXSoab+xnEPKdTnJAAZEmacQ4tQgSDc9GfD0RjNCtd5mTdlo1brO8J84OlUaoTJ6OXWjIkbwz881Qt75GHzwCW8D3Z2qpCN1xnDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=gP9HAlIz; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="gP9HAlIz" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-62f5bfd0502so1217694a12.0 for ; Thu, 18 Sep 2025 03:21:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1758190860; x=1758795660; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=QRDX73CGJx/uFk65r/M++y1ESGZoLC/18154y9sBkyQ=; b=gP9HAlIzZ0O+NFXtxQ4IpfNNIVQIVKkryhTQcuFybJgWqgykNlPduGpqteJPzkYleb zyj8gwG2TEITgKMitfGgdFg2bsYVyfzS8DiCQ2UNF7Pi6tK/aAnFLaIVPnbT/je66//8 KhxTsD9BDCmSlzY+t+V8gcpiLJQu+mmS5b47jGt2qRRhizEeKLwP9cbj9OFYFsM0jhUq 0SLMWMdhJu4lddfKrcXToILlz1OTIL5RuundElWq65LzDCnLSnr9WrUjyXQicUtlfyY3 t3dgOOpzwM/WG6IrPaWf0GVkykcW51NN1B4IeDJqh2OtZbgXEVFLb0kEB7MF6zdPU7Bj /xHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758190860; x=1758795660; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QRDX73CGJx/uFk65r/M++y1ESGZoLC/18154y9sBkyQ=; b=Oo1qvsuG4A2z35ZBymKXAiH5T5xuhXHG5AgPYTnnFTSTDntB4tOvjPyiC/dDGACHHz 41SoXzVVy2oWMFwAGnCZz+t5GBXwv/4yDgj13T2Ut2Aw1fYdM+JpFIXipJjjlesN5K61 Q68fLE/MZFhS17C6SuJnnz6oe8Tkc9rZHY6NDcqxOte2Ab/OcQdEL7csAWdznyayOGmm 4TdHZ9wZq84pLsBJndfRemrZ+HsDkCynrsSyghk7ALlLQoA8vqKE8FiFU69638Ut29ni cqnNYVnvqrqGLWZ0yqxZfXg9HyaScn7vJjfTcNOQeNy0C24BJ/9XvPo177bGuXANrtN4 tKmA== X-Forwarded-Encrypted: i=1; AJvYcCW+kDQJqSEwb43q8E8CKZsFKgFhZd+kEFu4YWs7ywHCd/nIWmnz0a/uSQEuKhyd+tFTUpR2H6eFuvWQNsI=@vger.kernel.org X-Gm-Message-State: AOJu0YwZKZdf02Dyqk2wM+JzSi1CHChg8ddM8H2NWVME7+oT1/p8IXFO I6WF6Z9qdl6B1ngVZdC++GJ86fS7zs3M4PETVYuhJi5vEn9ks/fhH+w9Y1h5cFueiA0= X-Gm-Gg: ASbGncsFzBKfRAnbiLhA7/wKxkIvZxMka6PIvYHFoTMnhN7AlrlWZgbMPqVzZEW38k5 vTIzUahzAonYkp650ONDvpH3O3UF36LpeUDP54j0SFMqSGwp+gRMEh4eZE9ALUgSQ+JmTcOwb6Y zqRzcbOP0qwjTsx2SVQHODwf17ZlmN5eLfzHz8ERDtnvixkNr/KI3sS3b/kydwU5eKBuKlXETmk 2LkwXE0asBscoCAzH/KcqawtQvniiOTmQT3QuPnhSSazxGHZTjbnoYn4yjUcxR72s/JgNs9CWm/ Ax9UFC8gIz+PotxlCzynrz7WckYIv+TykyCWfMPmV1uwng7catYFCeqxU20X15OCp5218n0vhpX YEPA3UsVmKyTT/xehjKBIWBCIq+ACCg18Fzxyps0J7Q7KZUpKx3t94GopzP9F0ipm7byH09HosE CZWA== X-Google-Smtp-Source: AGHT+IHZMQ2x56m1ACsAJOzzucWoM9GC1r3aRL6fpTCvD4pffVAwszK8RFTaPLUkaniu91C/lt6qfQ== X-Received: by 2002:a17:907:7ea8:b0:afc:a190:848a with SMTP id a640c23a62f3a-b1bc27793b9mr605349566b.60.1758190860179; Thu, 18 Sep 2025 03:21:00 -0700 (PDT) Received: from [192.168.0.20] (nborisov.ddns.nbis.net. [85.187.216.218]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b1fd14d5f56sm166369466b.74.2025.09.18.03.20.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Sep 2025 03:20:59 -0700 (PDT) Message-ID: <5ba955fe-2b96-429e-b2e8-5e1bf19d8e8e@suse.com> Date: Thu, 18 Sep 2025 13:20:58 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: spurious mce Hardware Error messages in next-20250912 To: Yazen Ghannam , Bert Karwatzki Cc: Borislav Petkov , Tony Luck , linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, linux-edac@vger.kernel.org, linux-acpi@vger.kernel.org, x86@kernel.org, rafael@kernel.org, qiuxu.zhuo@intel.com, Smita.KoralahalliChannabasappa@amd.com References: <20250915010010.3547-1-spasswolf@web.de> <20250915175531.GB869676@yaz-khff2.amd.com> <45d4081d93bbd50e1a23a112e3caca86ce979217.camel@web.de> <426097525d5f9e88a3f7e96ce93f24ca27459f90.camel@web.de> <20250916091055.GAaMkpn72GrFnsueCF@fat_crate.local> <20250916140744.GA1054485@yaz-khff2.amd.com> <9488e4bf935aa1e50179019419dfee93d306ded9.camel@web.de> <20250917144148.GA1313380@yaz-khff2.amd.com> <6e1eda7dd55f6fa30405edf7b0f75695cf55b237.camel@web.de> <20250917192652.GA1610597@yaz-khff2.amd.com> From: Nikolay Borisov Content-Language: en-US Autocrypt: addr=nik.borisov@suse.com; keydata= xsFNBGcrpvIBEAD5cAR5+qu30GnmPrK9veWX5RVzzbgtkk9C/EESHy9Yz0+HWgCVRoNyRQsZ 7DW7vE1KhioDLXjDmeu8/0A8u5nFMqv6d1Gt1lb7XzSAYw7uSWXLPEjFBtz9+fBJJLgbYU7G OpTKy6gRr6GaItZze+r04PGWjeyVUuHZuncTO7B2huxcwIk9tFtRX21gVSOOC96HcxSVVA7X N/LLM2EOL7kg4/yDWEhAdLQDChswhmdpHkp5g6ytj9TM8bNlq9I41hl/3cBEeAkxtb/eS5YR 88LBb/2FkcGnhxkGJPNB+4Siku7K8Mk2Y6elnkOctJcDvk29DajYbQnnW4nhfelZuLNupb1O M0912EvzOVI0dIVgR+xtosp66bYTOpX4Xb0fylED9kYGiuEAeoQZaDQ2eICDcHPiaLzh+6cc pkVTB0sXkWHUsPamtPum6/PgWLE9vGI5s+FaqBaqBYDKyvtJfLK4BdZng0Uc3ijycPs3bpbQ bOnK9LD8TYmYaeTenoNILQ7Ut54CCEXkP446skUMKrEo/HabvkykyWqWiIE/UlAYAx9+Ckho TT1d2QsmsAiYYWwjU8igXBecIbC0uRtF/cTfelNGrQwbICUT6kJjcOTpQDaVyIgRSlUMrlNZ XPVEQ6Zq3/aENA8ObhFxE5PLJPizJH6SC89BMKF3zg6SKx0qzQARAQABzSZOaWtvbGF5IEJv cmlzb3YgPG5pay5ib3Jpc292QHN1c2UuY29tPsLBkQQTAQoAOxYhBDuWB8EJLBUZCPjT3SRn XZEnyhfsBQJnK6byAhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJECRnXZEnyhfs XbIQAJxuUnelGdXbSbtovBNm+HF3LtT0XnZ0+DoR0DemUGuA1bZAlaOXGr5mvVbTgaoGUQIJ 3Ejx3UBEG7ZSJcfJobB34w1qHEDO0pN9orGIFT9Bic3lqhawD2r85QMcWwjsZH5FhyRx7P2o DTuUClLMO95GuHYQngBF2rHHl8QMJPVKsR18w4IWAhALpEApxa3luyV7pAAqKllfCNt7tmed uKmclf/Sz6qoP75CvEtRbfAOqYgG1Uk9A62C51iAPe35neMre3WGLsdgyMj4/15jPYi+tOUX Tc7AAWgc95LXyPJo8069MOU73htZmgH4OYy+S7f+ArXD7h8lTLT1niff2bCPi6eiAQq6b5CJ Ka4/27IiZo8tm1XjLYmoBmaCovqx5y5Xt2koibIWG3ZGD2I+qRwZ0UohKRH6kKVHGcrmCv0J YO8yIprxgoYmA7gq21BpTqw3D4+8xujn/6LgndLKmGESM1FuY3ymXgj5983eqaxicKpT9iq8 /a1j31tms4azR7+6Dt8H4SagfN6VbJ0luPzobrrNFxUgpjR4ZyQQ++G7oSRdwjfIh1wuCF6/ mDUNcb6/kA0JS9otiC3omfht47yQnvod+MxFk1lTNUu3hePJUwg1vT1te3vO5oln8lkUo9BU knlYpQ7QA2rDEKs+YWqUstr4pDtHzwQ6mo0rqP+zzsFNBGcrpvIBEADGYTFkNVttZkt6e7yA LNkv3Q39zQCt8qe7qkPdlj3CqygVXfw+h7GlcT9fuc4kd7YxFys4/Wd9icj9ZatGMwffONmi LnUotIq2N7+xvc4Xu76wv+QJpiuGEfCDB+VdZOmOzUPlmMkcJc/EDSH4qGogIYRu72uweKEq VfBI43PZIGpGJ7TjS3THX5WVI2YNSmuwqxnQF/iVqDtD2N72ObkBwIf9GnrOgxEyJ/SQq2R0 g7hd6IYk7SOKt1a8ZGCN6hXXKzmM6gHRC8fyWeTqJcK4BKSdX8PzEuYmAJjSfx4w6DoxdK5/ 9sVrNzaVgDHS0ThH/5kNkZ65KNR7K2nk45LT5Crjbg7w5/kKDY6/XiXDx7v/BOR/a+Ryo+lM MffN3XSnAex8cmIhNINl5Z8CAvDLUtItLcbDOv7hdXt6DSyb65CdyY8JwOt6CWno1tdjyDEG 5ANwVPYY878IFkOJLRTJuUd5ltybaSWjKIwjYJfIXuoyzE7OL63856MC/Os8PcLfY7vYY2LB cvKH1qOcs+an86DWX17+dkcKD/YLrpzwvRMur5+kTgVfXcC0TAl39N4YtaCKM/3ugAaVS1Mw MrbyGnGqVMqlCpjnpYREzapSk8XxbO2kYRsZQd8J9ei98OSqgPf8xM7NCULd/xaZLJUydql1 JdSREId2C15jut21aQARAQABwsF2BBgBCgAgFiEEO5YHwQksFRkI+NPdJGddkSfKF+wFAmcr pvICGwwACgkQJGddkSfKF+xuuxAA4F9iQc61wvAOAidktv4Rztn4QKy8TAyGN3M8zYf/A5Zx VcGgX4J4MhRUoPQNrzmVlrrtE2KILHxQZx5eQyPgixPXri42oG5ePEXZoLU5GFRYSPjjTYmP ypyTPN7uoWLfw4TxJqWCGRLsjnkwvyN3R4161Dty4Uhzqp1IkNhl3ifTDYEvbnmHaNvlvvna 7+9jjEBDEFYDMuO/CA8UtoVQXjy5gtOhZZkEsptfwQYc+E9U99yxGofDul7xH41VdXGpIhUj 4wjd3IbgaCiHxxj/M9eM99ybu5asvHyMo3EFPkyWxZsBlUN/riFXGspG4sT0cwOUhG2ZnExv XXhOGKs/y3VGhjZeCDWZ+0ZQHPCL3HUebLxW49wwLxvXU6sLNfYnTJxdqn58Aq4sBXW5Un0Q vfbd9VFV/bKFfvUscYk2UKPi9vgn1hY38IfmsnoS8b0uwDq75IBvup9pYFyNyPf5SutxhFfP JDjakbdjBoYDWVoaPbp5KAQ2VQRiR54lir/inyqGX+dwzPX/F4OHfB5RTiAFLJliCxniKFsM d8eHe88jWjm6/ilx4IlLl9/MdVUGjLpBi18X7ejLz3U2quYD8DBAGzCjy49wJ4Di4qQjblb2 pTXoEyM2L6E604NbDu0VDvHg7EXh1WwmijEu28c/hEB6DwtzslLpBSsJV0s1/jE= In-Reply-To: <20250917192652.GA1610597@yaz-khff2.amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/17/25 22:26, Yazen Ghannam wrote: > Right, so it seems we have bogus data logged in these registers. And > this is unrelated to the recent patches. > > We have some combination of bits set in MCA_DESTAT registers. The > deferred error interrupt hasn't fired (at least from the latest > example). > > There does seem to be some combination of bits that are always set and > others flip between examples. > > I'll highlight this to our hardware folks. But I don't think there's > much we can do other than filter these out somehow. > > I can add two checks to the patch to make it more like the current > behavior. > > 1) Check for 'Deferred' status bit when logging from the MCA_DESTAT. > This was in the debug patch I shared. According to AMD APM 9.3.3.4: "If the error being logged is a deferred error, then the error will be logged to MCA_DESTAT." So this means that when Valid is set in DESTAT then the error MUST BE deferred. I.e I think it's in valid to have valid && !deferred in DESTAT, no ? Additionally nowhere in the APM is ti mentioned what's the default value of MCA_CONFIG.LogDeferredEn so as it stands you are now working with the assumption that it's 1 and DESTAT is always a redundant copy of STATUS. Btw looking at the output that Bert has provided it seems that indeed MCA_CONFIG.LogDeferredEn is 0 by default: " LogDeferredEn—Bit 34. Enable logging of deferred errors in MCA_STATUS. 0=Log deferred errors only in MCA_DESTAT and MCA_DEADDR. 1=Log deferred errors in MCA_STATUS and MCA_ADDR in addition to MCA_DESTAT and MCA_DEADDR. This bit does not affect logging of deferred errors in MCA_SYND or MCA_MISCx. " I think the polling code is slightly broken now for AMD. The order of operation per poll cycle should be: 1. Check MCA_STATUS -> report if there is anything, clear it the bank 2. (In the same cycle) -> Check DEFERRED and report if there is anything, clear the deferred. > 2) Only check MCA_DESTAT when we are notified by the deferred error > interrupt. > > Technically, both of these shouldn't be necessary based on the > architecture. > > So there's a third option: add this error signature to our filter_mce() > function. > > As I write this out, I feel more inclined to option #3. I think it would > be better to stick to the architecture. We may get error reports like > this. But that may be preferable so that any potential hardware issues > can be investigated sooner. If there's a real problem, better to get it > fixed in future products rather than implicitly mask it by our code > flow. > > Any thoughts from others? > > Thanks, > Yazen