From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B67C61FEB for ; Sat, 31 Aug 2024 06:27:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.255 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725085628; cv=none; b=gslzJlz+OKhZm8No8qCx20VImSubwHQpDOnPKmMmwpkvvyBmxk0LCzsL/kpWmC6zWfwWGo9CQpOJKYz7TJ4GROztQIwxPbfJwS+ezipQ7A39rcpyloClzF2mIh5juyVgfAg5uvaMxaYUtGHxEAEInrrhUMAxoyXWfvVuLJ7HNKE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725085628; c=relaxed/simple; bh=TySkDDoGqdODDLoNnQz6oXCTOin8IPkow01cthvqL1o=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=ULenr3RWtzi7BRF9uoKDnpNS29eSp/MHlO9R6HuNqYtN4CHGpPq+7KN2qmJ3g7R2/3Dwy/Q8ITyQt9iMVK+059pOhi/JHdsik72fQ6vu7+k0QdrMEpxW/rtytGHKjdYaJGqpc+vY0wEvtgT8zk8eaLii78k1hRpmNVmKaJQwPp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.255 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4WwlQT41JKz18MxP; Sat, 31 Aug 2024 14:26:09 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 6DDD41800CF; Sat, 31 Aug 2024 14:27:01 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 31 Aug 2024 14:27:00 +0800 Message-ID: <5ba9c21f-acfa-7c89-a358-b52aa9ecedd3@huawei.com> Date: Sat, 31 Aug 2024 14:27:00 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH -next v2 2/4] soc: ti: knav_dma: Use dev_err_probe() to simplfy code Content-Language: en-US To: Krzysztof Kozlowski , Nishanth Menon CC: , , , References: <20240830063228.3519385-1-ruanjinjie@huawei.com> <20240830063228.3519385-3-ruanjinjie@huawei.com> <20240830103155.5vs2hdokw6yysq47@finance> <29edea69-92ce-2ac9-2aa8-bb9a4674ca01@huawei.com> <8a02ecd3-4e3d-4332-85da-8a0bdf4b9ed2@kernel.org> From: Jinjie Ruan In-Reply-To: <8a02ecd3-4e3d-4332-85da-8a0bdf4b9ed2@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh500013.china.huawei.com (7.202.181.146) On 2024/8/31 13:21, Krzysztof Kozlowski wrote: > On 31/08/2024 03:59, Jinjie Ruan wrote: >> >> >> On 2024/8/30 18:31, Nishanth Menon wrote: >>> On 14:32-20240830, Jinjie Ruan wrote: >>>> Use the dev_err_probe() helper to simplify error handling >>>> during probe. >>>> >>>> Signed-off-by: Jinjie Ruan >>>> --- >>>> v2: >>>> - Split into 2 patches. >>>> --- >>>> drivers/soc/ti/knav_dma.c | 12 ++++-------- >>>> 1 file changed, 4 insertions(+), 8 deletions(-) >>>> >>>> diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c >>>> index 15e41d3a5e22..eeec422a46f0 100644 >>>> --- a/drivers/soc/ti/knav_dma.c >>>> +++ b/drivers/soc/ti/knav_dma.c >>>> @@ -708,17 +708,13 @@ static int knav_dma_probe(struct platform_device *pdev) >>>> struct device_node *node = pdev->dev.of_node; >>>> int ret = 0; >>>> >>>> - if (!node) { >>>> - dev_err(&pdev->dev, "could not find device info\n"); >>>> - return -EINVAL; >>>> - } >>>> + if (!node) >>>> + return dev_err_probe(&pdev->dev, -EINVAL, "could not find device info\n"); >>>> >>>> kdev = devm_kzalloc(dev, >>>> sizeof(struct knav_dma_pool_device), GFP_KERNEL); >>>> - if (!kdev) { >>>> - dev_err(dev, "could not allocate driver mem\n"); >>>> - return -ENOMEM; >>>> - } >>>> + if (!kdev) >>>> + return dev_err_probe(dev, -ENOMEM, "could not allocate driver mem\n"); >>> >>> These make no sense to me :( -> just using dev_err_probe when there is >>> no chance of -EPROBE_DEFER ? >> >> I noticed a change in dev_err_probe() this year, which is described in >> this patch: >> >> For an out-of-memory error there should be no additional output. Adapt >> dev_err_probe() to not emit the error message when err is -ENOMEM. >> This simplifies handling errors that might among others be -ENOMEM. >> >> >> And the comment of dev_err_probe() said below: >> >> * Using this helper in your probe function is totally fine even if @err > > Fine but not much useful and at the same time huge churn from @vivo.com. I see, it is fine with these dev_err_probe() dropped, the main is the scoped child iterate. > > Best regards, > Krzysztof >