From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751572AbdJ0OVG (ORCPT ); Fri, 27 Oct 2017 10:21:06 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:55359 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029AbdJ0OVC (ORCPT ); Fri, 27 Oct 2017 10:21:02 -0400 X-Google-Smtp-Source: ABhQp+Ry1pB8szy30IZhBl43k1vSjbXigQKaDznVu37jpkPpCQq5XirMUKDuskyIw1M/Fk6RASGdTA== Subject: Re: [PATCH v9 3/7] mailbox: qcom: Move the apcs struct into a separate header To: Bjorn Andersson , sboyd@codeaurora.org Cc: jassisinghbrar@gmail.com, robh+dt@kernel.org, mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20170921164940.20343-1-georgi.djakov@linaro.org> <20170921164940.20343-4-georgi.djakov@linaro.org> <20171026042811.GL1575@tuxbook> From: Georgi Djakov Message-ID: <5bad4c4b-362b-ba9f-3072-1cced7a004dd@linaro.org> Date: Fri, 27 Oct 2017 17:20:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171026042811.GL1575@tuxbook> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, Thanks for reviewing! On 10/26/2017 07:28 AM, Bjorn Andersson wrote: > On Thu 21 Sep 09:49 PDT 2017, Georgi Djakov wrote: > >> Move the structure shared by the APCS IPC device and its subdevices >> into a separate header file. >> > > As you're creating the apcs regmap with devm_regmap_init_mmio() you can > just call dev_get_regmap(dev->parent) in your child to get the handle. Ok, thanks! > > But I would prefer that you just add the clock code to the existing > driver. This will require an ack from Stephen, and i got the impression that he prefers a separate clk driver [1]. Stephen, are you ok with registering the clocks from the apcs mailbox driver? [1] https://lkml.org/lkml/2017/6/26/750