mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Dustin Howett <dustin@howett.net>
Cc: Benson Leung <bleung@chromium.org>,
	 Guenter Roeck <groeck@chromium.org>,
	Sebastian Reichel <sre@kernel.org>, Lee Jones <lee@kernel.org>,
	 chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org,
	 Mario Limonciello <mario.limonciello@amd.com>,
	Stephen Horvath <s.horvath@outlook.com.au>,
	 Rajas Paranjpe <paranjperajas@gmail.com>
Subject: Re: [PATCH v2 0/3] ChromeOS Embedded Controller charge control driver
Date: Mon, 3 Jun 2024 22:59:52 +0200	[thread overview]
Message-ID: <5baf3caf-dc09-4829-96db-2666fc902710@t-8ch.de> (raw)
In-Reply-To: <CA+BfgNJByawxkZukaCXYcmOo_K9aQ0W1x8B6Y+Hyg_fZaJ4axw@mail.gmail.com>

On 2024-06-02 18:40:18+0000, Dustin Howett wrote:
> On Tue, May 28, 2024 at 3:05 PM Thomas Weißschuh <linux@weissschuh.net> wrote:
> >
> > Add a power supply driver that supports charge thresholds and behaviour
> > configuration.
> >
> > This is a complete rework of
> > "platform/chrome: cros_ec_framework_laptop: new driver" [0], which used
> > Framework specific EC commands.
> >
> > The driver propsed in this series only uses upstream CrOS functionality.
> >
> > Tested on a Framework 13 AMD, Firmware 3.05.
> >
> 
> I've tested this out on the Framework Laptop 13, 11th gen intel core
> and AMD Ryzen 7040 editions.

Thanks!

> The problem is that the AMD framework laptop *reports* support for the
> CrOS charge controller, but it does not truly support it.
> As with the 11th Gen Intel Core (and by proxy the 12th, 13th) it still
> does require the OEM-specific command.

This is surpising, it works on my machine, which is also a AMD 7040.

> This is evinced by a mismatch between the firmware-configured value
> and the value reported by the charge control subsystem through this
> driver.
> 
> $ cat /sys/class/power_supply/BAT1/charge_control_end_threshold
> 100
> 
> $ ectool raw 0x3E03 b8 # OEM command 0x3E03 with BIT(3) in the payload
> is Framework's charge limit query host command
> Read 2 bytes
>  50 00                                           |P.              |
> (in my case, 80 in decimal)
> 
> The charge limit is managed at [1], and it does not appear to
> integrate with the standard charge control machinery.
> 
> I'll pursue getting this board not to report support for CrOS charge
> control. This driver is still entirely fit for purpose, just not for
> this board.

Can you try disabling all of the Framework-specific charge control
settings and test again?
Probably the different, disparate logics in the Framework ECs are
conflicting with each other.

Thomas

  reply	other threads:[~2024-06-03 20:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 20:04 Thomas Weißschuh
2024-05-28 20:04 ` [PATCH v2 1/3] platform/chrome: Update binary interface for EC-based charge control Thomas Weißschuh
2024-06-03  1:38   ` Tzung-Bi Shih
2024-05-28 20:04 ` [PATCH v2 2/3] power: supply: add ChromeOS EC based charge control driver Thomas Weißschuh
2024-06-05 22:14   ` Sebastian Reichel
2024-05-28 20:04 ` [PATCH v2 3/3] mfd: cros_ec: Register charge control subdevice Thomas Weißschuh
2024-05-31 15:50   ` (subset) " Lee Jones
2024-06-14  9:03   ` Lee Jones
2024-06-02 23:40 ` [PATCH v2 0/3] ChromeOS Embedded Controller charge control driver Dustin Howett
2024-06-03 20:59   ` Thomas Weißschuh [this message]
2024-06-05  1:27     ` Dustin Howett
2024-06-05  9:33       ` Thomas Weißschuh
2024-06-05 20:32         ` Mario Limonciello
2024-06-06  6:25           ` Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5baf3caf-dc09-4829-96db-2666fc902710@t-8ch.de \
    --to=linux@weissschuh.net \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=dustin@howett.net \
    --cc=groeck@chromium.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=paranjperajas@gmail.com \
    --cc=s.horvath@outlook.com.au \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®