mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Tanju Brunostar <tanjubrunostar0@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH v2 4/6] staging: vt6655: refactor long lines of code in s_vGenerateTxParameter
Date: Sat, 22 Oct 2022 06:39:39 +0200	[thread overview]
Message-ID: <5bb36c2c-c0a8-905d-3e6d-f42cd8e9f9c7@gmail.com> (raw)
In-Reply-To: <CAHJEyKUGJ+E13-oLTHr4PS6za==gyCPWm6siGZaasUw6dJxGmQ@mail.gmail.com>

On 10/21/22 20:14, Tanju Brunostar wrote:
>>> Error during compiliation in next line
>>>
>>>> +                     struct vnt_rrv_time_ab *buf = pvRrvT
>>>> +                             ime;
>>> make: Entering directory '/home/kernel/Documents/git/kernels/staging'
>>>     CC [M]  drivers/staging/vt6655/rxtx.o
>>> drivers/staging/vt6655/rxtx.c: In function ‘s_vGenerateTxParameter’:
>>> drivers/staging/vt6655/rxtx.c:1014:34: error: ‘pvRrvT’ undeclared (first
>>> use in this function)
>>>    1014 |    struct vnt_rrv_time_ab *buf = pvRrvT
>>>         |                                  ^~~~~~
>>> drivers/staging/vt6655/rxtx.c:1014:34: note: each undeclared identifier
>>> is reported only once for each function it appears in
>>> drivers/staging/vt6655/rxtx.c:1015:5: error: expected ‘,’ or ‘;’ before
>>> ‘ime’
>>>    1015 |     ime;
>>>         |     ^~~
>>> make[1]: *** [scripts/Makefile.build:250: drivers/staging/vt6655/rxtx.o]
>>> Error 1
>>> make: *** [Makefile:1992: drivers/staging/vt6655] Error 2
>>> make: Leaving directory '/home/kernel/Documents/git/kernels/staging'
>>>
>> This error occured on the first version of this patch. I corrected it,
>> compiled the code and the error was gone before I sent this version.
>> please check again. You may have seen this error on the first version
>> and not this one.
>> thanks
>>
>> Tanju
> On the first patch, this error was detected by the kernel bot. This
> time around, the kernel bot did not detect it, meaning it was fixed.

Please check the outbox of your email account and have a look. This is 
the v2 Patch and it contains this two lines:
 >>>> +                     struct vnt_rrv_time_ab *buf = pvRrvT
 >>>> +                             ime;
which do not compile.

Bye Philipp

  reply	other threads:[~2022-10-22  4:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21 10:33 [PATCH v2 0/6] a series of checkpatch fixes on the file: rxtx.c Tanjuate Brunostar
2022-10-21 10:33 ` [PATCH v2 1/6] staging: vt6655: fix lines ending in a '(' Tanjuate Brunostar
2022-10-21 10:33 ` [PATCH v2 2/6] staging: vt6655: refactor long lines of code in s_uGetRTSCTSDuration Tanjuate Brunostar
2022-10-21 10:33 ` [PATCH v2 3/6] staging: vt6655: refactor long lines of code in s_uFillDataHead Tanjuate Brunostar
2022-10-21 10:33 ` [PATCH v2 4/6] staging: vt6655: refactor long lines of code in s_vGenerateTxParameter Tanjuate Brunostar
2022-10-21 16:52   ` Philipp Hortmann
2022-10-21 18:08     ` Tanju Brunostar
2022-10-21 18:14       ` Tanju Brunostar
2022-10-22  4:39         ` Philipp Hortmann [this message]
2022-10-22  5:49           ` Tanju Brunostar
2022-10-21 10:33 ` [PATCH v2 5/6] staging: vt6655: refactor long lines of code in the rest of the file Tanjuate Brunostar
2022-10-21 10:33 ` [PATCH v2 6/6] staging: vt6655: refactor code to avoid a line ending in '(' Tanjuate Brunostar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bb36c2c-c0a8-905d-3e6d-f42cd8e9f9c7@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    --cc=tanjubrunostar0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®