From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C9BC433F5 for ; Mon, 11 Apr 2022 16:38:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244947AbiDKQkm (ORCPT ); Mon, 11 Apr 2022 12:40:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239661AbiDKQkh (ORCPT ); Mon, 11 Apr 2022 12:40:37 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66D6236E03 for ; Mon, 11 Apr 2022 09:38:21 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 49DF1210ED; Mon, 11 Apr 2022 16:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1649695100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y9/arbXIOBmMDyyrN2Av4t9DefV8dvs2koOjBKbR16o=; b=aYxxcUNMYUZgIStXQpMXpRQuihq2c7AV46HILo5L/me3KwIxobXG0UXTdrgm8JSitDiE2T XiIG135Z2kQFDiqz5DMASSf9zcqSPWCuir/RE+P/niLQ2yGUUjCdnNpxjbw6ekcg2eZcNd 2uzHZ2Iai0A6vPyfpCMUbRvQTvwR6pI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1649695100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y9/arbXIOBmMDyyrN2Av4t9DefV8dvs2koOjBKbR16o=; b=gvCHtWB3YEZKCWAi6tPJA5issC5sJtS5VTmxBPxgz+Ar+KtXHHVTgmyPFbPnVD0YcZm+Et vC2vL4vTF+7cemCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D3C6F13A93; Mon, 11 Apr 2022 16:38:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6tb4MntZVGJ6fQAAMHmgww (envelope-from ); Mon, 11 Apr 2022 16:38:19 +0000 Message-ID: <5bbf024d-225f-0aac-9abb-788e076f271a@suse.cz> Date: Mon, 11 Apr 2022 18:38:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 03/16] mm/memory: slightly simplify copy_present_pte() Content-Language: en-US To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: Andrew Morton , Hugh Dickins , Linus Torvalds , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Christoph Hellwig , Oleg Nesterov , Jan Kara , Liang Zhang , Pedro Gomes , Oded Gabbay , linux-mm@kvack.org References: <20220329160440.193848-1-david@redhat.com> <20220329160440.193848-4-david@redhat.com> From: Vlastimil Babka In-Reply-To: <20220329160440.193848-4-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/29/22 18:04, David Hildenbrand wrote: > Let's move the pinning check into the caller, to simplify return code > logic and prepare for further changes: relocating the > page_needs_cow_for_dma() into rmap handling code. > > While at it, remove the unused pte parameter and simplify the comments a > bit. > > No functional change intended. > > Signed-off-by: David Hildenbrand Yeah, much better. Acked-by: Vlastimil Babka