From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754218AbdEHBy1 (ORCPT ); Sun, 7 May 2017 21:54:27 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:42204 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbdEHByZ (ORCPT ); Sun, 7 May 2017 21:54:25 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=fb.com; Subject: Re: [PATCH] lightnvm: remove unused rq parameter of nvme_nvm_rqtocmd() to kill warning To: Geert Uytterhoeven , =?UTF-8?Q?Javier_Gonz=c3=a1lez?= , =?UTF-8?Q?Matias_Bj=c3=b8rling?= , Keith Busch , Christoph Hellwig , Sagi Grimberg References: <1494166484-11363-1-git-send-email-geert@linux-m68k.org> CC: , Arnd Bergmann , From: Jens Axboe Message-ID: <5bc0bd5f-4eb5-5975-4700-071b78047917@fb.com> Date: Sun, 7 May 2017 19:53:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1494166484-11363-1-git-send-email-geert@linux-m68k.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: BN6PR18CA0017.namprd18.prod.outlook.com (10.175.188.27) To BN6PR15MB1185.namprd15.prod.outlook.com (10.172.205.139) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4cbf903c-d50d-4cd8-1e18-08d495b50ccf X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:BN6PR15MB1185; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;3:GT+9pJ+5Yw81I39uSVmSapSiqZMi1fM59YIu10K2XpflBea6v/kuGgLEZpxdUhbS1+/ZaZrl1tH3a3M9oYBV1JOp1IhKU4oJ4O0d02pWjir4bA2s/c2cmrVzdQxrznv5Xcpqd6rlGdAJEjgCGbiVcr9jLWKjTzKDv3KnKQwc3MVfRLf+EnyYi6sNKoOGuHUeC1/r13VIofTygYVjYVuahKMOy8oQuoZ8wCOirtnMq4GKenXcJ0Y7TzJ8Wuov5xRF1Tq+DqpLXAhICSmfOECaZAKoXjmU/F2eb/8FBMk1WRWVId/Najexnt5sLHU726pfvgYaLtyW2+3aoU/uQfo01Q==;25:BRw1UGpI7Rcu6yNRIzROLo/uOHOHxY1WqvSlVgjOwradHn8M6Izuq53IJHaex6VlhxrO/F25NsnCi9bfUnKRhdTE0fpCuJnW105x0F1ngWwxNaZplP90Z9BLRGj7VDIUVd6F2jPDRuADwiinwdYC7HfYFujGNNlXzwtGftSZcQFSa0ckTtJGXHAVr8ukO6Vmn/t8OeOBG3UmtuiYmVPPfSZKR3kiycTSJ4igmlUI0dCHuGXOudMh5vBrgiMGlW1eU8wPEFC37pBHPPwc2RQ/VvQ+HXV6XVJvEt0nDr73k0LN5GMHkQBR/+G7KRu6Heh/Ua02XFNDR1X5anGeVBkP2Rf7oQFJKZwpGs/QYFQ9TxbOAiSRXTcJ0goMotUXYiiHbUqPgAeB4WkeodzCxY6ok83MR+fTKNpurETTGNG8z/eHCnovgC5KBHWXrOw8zUbpwAo6+XgQEJnAy7WCfmDCTm092rCBw708ucRp4Hfmm3k= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;31:cE9u5TR4PkagINV5mMeI8aity5zKrb9Mb07sPD/O8n9tdigRg3nzLeyw536ywNXaeIElrMMXf35mWsVReBiXdqQzEN6qKBIkng5eIO1PcQp5JzeugfMbxkVKB3SDXSUCdOJSCgFUm4NPo3YiQdEvYDCENiR/r6GjNuwIAjCO2k1qDXpk44Bn8Z96iNNzE5oeiKoZU2NT7lnFcSfkTo/UWsp5M5IE+XVRcF2OxS0kDKFLnwWO22lOJ9+cYfxBRmIb0G55B1sx5sEHM2+SSX78pg==;20:5mkLzXGy6J8PFAcvhsbNecmchLTHfm1xYEBQdv0XVhGhH5npzjcgGHo6pfpWAUV7TiONUJlTEOkG0C+Kybm2JNxWoplgwOYYYAe3BBr6Y82nIXYkMVCqZomqIFzTrSmdRsyqBTzCVqW5g8W1gVcQpGrg6XNpsIcTiuBXk9roUM5u6dZ+9GXqmGcm9TcdQDAvIEnKwj4e/P0JfRhDdLvNmsU9DltkRxYN/us9uIWRACLZg/5q3u496DLDD7rjxEpB2BKLaxfxO0IE6o03YrcwDTWlLvjfI4CmH9cBQcox2idil1JOcML/cb+pqP112ZJIU1Coa9eRmeEq5aVKJU5nI7M3CV2gxZgd/QctHB+aHblCqgDsOSjrCtrE3/a0FE3iCc64SPZi1tVM0K2HvJnaH8XH77UXulad+vDQQ19nQbyouvGIdYM1zJ2CWJWptM/0NHpyzcTi1uFz3fc473MlcTQTP1khqzkQOHlesgdlG5281Y0dHilUSDXJo2b/+5fS X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(6072148);SRVR:BN6PR15MB1185;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1185; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;4:8kBH+b+f6wyaRVIYORbBTdvr5ewGy1ML4Lvw17WgetOhBxYxuNB9K89dbihxsifV2sktDle5clTedfBW0mBZAZupN1XgCE6NEh85cCETG8N0yVwCWUvpYsj4X9mr54MfRikNUXn0UYwWlklEgKucB+VMECPDy879UpXUByQN8z4kljCWkCM895dbP7ryJVpHELDvGFF55hnfiwgt6TEfTCS10lE3il+m20Sxl9QCHJF3R1gbBIaytX3Hw+SC54wbotTurUxPE7G+1ONw4AOhNYcgB7kg7qpLQZh4k+TaH7TkYE2nV7qltrzKxzZM7nVOXf5cSf/6thfUZ0R0VUOdAz3CmB73tdIsd5OWTrV3cmkGivwrvAGf6v7+J/K52GtkDhmjsA+8mmd5JsPPud/8OEUEUB7G8yYULQ/rDgvo+mQItXbkrvnmQRmsD0lBgRM24pu8/VmC5LU4E/8sknUP/s/+6Uw9nsNmemmJxx413JS0l+4ILgQFDkY+TSQ1q3dnOl/AjSm7csUTSnHNr3E2SVHYV2J8tsqsa5CjcNieyDcetNN7E3c4rTtMxwCYXj5fkSaUcEGlCFZ+5hYxx0bUz8PVpsjD2m4a0YbYdoGV5S8hm3zGTsllgCGqQ7K+DxY6XtXBzkSuCQniZPG4zBaEkkyvZcZK3/YE3WFxvsi0uAZ4tm2NSJak/DKKtJ42t6sSO5oockSL1ZNJvFiad4L7j+Xb8Ci8gMyoQIv9detB/EUpqZCZ72PmgmnwAxJ5f3FxUbv+k+JKiER2uhjK0XppTmraQXC8CaT4e38AknIguco= X-Forefront-PRVS: 0301360BF5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39850400002)(39410400002)(39400400002)(39450400003)(24454002)(377454003)(64126003)(50466002)(83506001)(36756003)(4001350100001)(117156002)(189998001)(86362001)(6666003)(31696002)(3846002)(6116002)(478600001)(47776003)(6486002)(77096006)(54906002)(2950100002)(53546009)(4326008)(23676002)(5660300001)(38730400002)(7736002)(2870700001)(81166006)(50986999)(76176999)(53936002)(66066001)(54356999)(33646002)(25786009)(2906002)(229853002)(8676002)(31686004)(42186005)(305945005);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1185;H:[192.168.1.176];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjE1TUIxMTg1OzIzOkI4QzU4b2c1Smxma29xQ1hlUnlYWmVBeWxM?= =?utf-8?B?UU1pRkpzdVhKQ1R6NDgrS00vRXNyYTRSTzJQQW1HWUZLL3NxbU1Nc2JPMjRo?= =?utf-8?B?OVJMZWJlOFJubjNMK29Rb0pwMFA4NmV1ZXkxVlBEcjZsS2tlTkNsWEwrcEkx?= =?utf-8?B?ZFhGZ25ReFpwMTd1MHp6NHhtNEhyRGtJTGFvNitZN1pKQ01rUTllZVZGb2d1?= =?utf-8?B?cEhuMDFrakxORTNkYTlPNng1ZkNUUzE5cDRRV3AxVTI3dVJHc0ZpT2prdW1U?= =?utf-8?B?Q3haYndCajdlT1I0ZVVCOTkyaXVZSmhtZ3NGL1owZ0VQQ2dveHdnYlY3RTMv?= =?utf-8?B?c0JMSVpwT3J2dlNITUo0amo4VVk1eU9VUVYrOFhOQ3dsUVJNaDJyajJyeFlC?= =?utf-8?B?RDBXeldZZzc2VkJsNHREU2l6NUNXU2RUaXIwOG9TWFRxTklnWmNpOXFoRC9q?= =?utf-8?B?eXg2RUxVK2cvdEhiajhrOHRxRjk5U3VXT1F4RXVBcVRFQWs4YU4wRks2dmpH?= =?utf-8?B?NkNzaWhyRDArRXlGc1Ric3Mrckp0dTFLMlNvYVgzeUg0Z1JraHF1Y1RWV2dC?= =?utf-8?B?aFFjNVlHeUFKQmVBOUl2NFNkQzhXQW1Id0E1QS93Qll4K3hINmg3bjJHWm1X?= =?utf-8?B?eXZFU0JHVkdRdWxQZWJRN2tWVnQ4VmRPYWYrM05jUmNmL3JkV1JBaFBLYVZ5?= =?utf-8?B?cU50azNtK1p4THRDelpVWEJFbjhwU05Ma2w1VlNaMHRQbEtHdlp3WTlXZkc1?= =?utf-8?B?TTkzRG41eUFzVHc4V0tQY2RiSFdtQU83RWVEUmZqbGtkWldLWmoxYkRRUVF0?= =?utf-8?B?eUlNdVVZdGk4eVQ1amVqeVdDL2M1R1h4YTloaUYrMkdVSGx4N2ZtOEhZZG5l?= =?utf-8?B?NDgrV3lKbkdHK2xub3lDeDUrNTg4MThLa1pReXNnWWIvN3pOeUp3a0tEbXA2?= =?utf-8?B?UkZrV2NBZmd6QVQ4SHMyN0VzQU41cEd2eWNoaVd2bUJ2R1ZOc1VNQ05kNk9i?= =?utf-8?B?YUNuL2dlc0VKblpSVVBXaE5LOVQ4VmEzcUF0MjcwMnd2OVB1R21qUHdWMnpt?= =?utf-8?B?TUE4RGxpcWhyRDBjTWYwYmt4ck1SbVFxOGZ0MGtrNHVWdVpvTkVaSEhiRDRK?= =?utf-8?B?YWFOa1lNNVVSaHJPWUkvRXA5RHJUNHMwNEtJVDdlc2JIVmFWWm8zTnZpbmZ4?= =?utf-8?B?RVduRUtRbzhzYU1IbzNTdXl3U3d1VE54elphMzBrY2xZOUFsVzI2T3ZpMWUv?= =?utf-8?B?NGc5QW9ITlZRM3dzMEZmNEZNQnBteWN3RTFzYTh3ZFExd2xSYmtiNzV0OHN0?= =?utf-8?B?akQxdHFCdUxrS3dMajA0b2NzbzEwd0xWM1QzOWNPN1JYenNsRE1EVWdDOGV2?= =?utf-8?B?T2tYb0dISU90UTMzeUpLK2Y1cko5aXh2T0thblV4a256aHV6QUFNK0ZSQlJ5?= =?utf-8?B?VHdOUUhScFdvTHQvSHFSNVgwV245QW9Fa0NmWHdaUFVnMFBLOUFqZ0E1cis1?= =?utf-8?B?Z3pTemY5alpER0g2OE5mZXhOY0l2VU5HQS9yb1VFUjlFako5eHg0UFBVRVV0?= =?utf-8?B?RWIraEVYTzYxb1VEUHVjKzFCUUNVVm9IRkRpVDY1SnFkYysvazhUV3FJK2Ev?= =?utf-8?Q?B6Osgkqu3x2if0RrFz6p?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;6:uScwJgtjAncn2IlsSfKdFF5sf7Os1kphRFezHRsi3SXws9Ex4YtKcFZ2/Qvgu1WfLg8o0ZMI87MVIpYvUExjfZWwEg1WWqS0LqKNiRPIIsTKqt5iUQnwYB1iUJUsmu1Qahn+PxbYPtcbdJyh+4WNI70FMwQH5kWBvZX2DZPIuS7anfEJx5b+qBeK18Knkig02jLHe7Ao9J738ttPdqE0FXv7jZ1OLh0gQfW/jeHghDd7L/ji+C7sicY97cZomGwbQs4/d1h+dmM947VaDhhYei4VT9PSMndkx8DKvjzaABy2C0tvb0oAGsuJkN0AiV7YW1Qoep067I/qhg630e/p0nTI5xQfnBFGWlXGSNBqqU0Rcvh/b809OnyjiRCYrtLX28QMDQPxyjck1ixRpA55uINeRHhuPwFn3Vlncx0Hyc184zBmFP7I/FEcSs9z/qD5pOYTheyhkIOEiY6NmTIRwUY37l/eUbogZlj/fQVW72GZKf/tyPbw25Ym3myrWZFRsFwZodBEVGOi2sFJj14NsQ==;5:Yk8oCVR1zuUyCjCl0ZNmqeaFhLeDnWVLLADgdor78eQpeCW8a4fvEasHyBoC4P5+T/nVS8CMb0MvpymL/oJH4bIiBay57h//FJcfIA3KC0kc4GtbEdeP4TCExTZfGKKht08x/j4hGLbFa04Y8sUnhw==;24:/FPUsZtnakywrKsw5feeKf2lCehgLg4xIS9CpeRQSzRyvY0c651F5K+zEhxK2ekZ7ZBFqDoFu2bmFWPf0vTAwvDXe3UO36vjS74IB6r5mNw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;7:G5XgNXkl2xxOAlG9Mne8JfxAtgzAYhMoF+7B9mg7dUmQKszoyHfwNWsMzbrZh5a16+hwLZ+KtKsarO3iwpYyiWR7uspVUcwsVWu58Lq7U6bL+Fiw4tMOSayThIYliJYw5ZyigT0uc0tXd1G2RA2b2iNBXZc7LsQQWNn7PrMonswBUP7MVijoXoTKScSEWhXv2ISjh9NvrJegDu4pyzq5u5mk82aKzT9hntyAhWWe6Qm00tHcmuUIuStWnd4wat61zQ/huhrRymF8yB2MgJ6kCQSYaa1z42Da0T3qh1i6Ny/lB+k95uSNHtgEsaA1nA3uR4qiUntZSUdkRnEf1bb3sQ==;20:hWWqKaRkG6irh+NU+gT0CbeLa2HKkUwOtht9J1k5JoFZcGvw7IS7YkmJra7jY07MrukbbrQahuiW9USstdwRxRxXL/uznXHqz7b03DHwVWBInvW8O89bO30r6O2qsGs5W3YCnzLwPfPbdoEgxGQdd+Z7Ipdj87bQJdXQISkC1DM= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2017 01:53:38.2757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1185 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-08_01:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/2017 08:14 AM, Geert Uytterhoeven wrote: > With gcc 4.1.2: Wow, that's ancient. > drivers/nvme/host/lightnvm.c: In function ‘nvme_nvm_submit_io’: > drivers/nvme/host/lightnvm.c:498: warning: ‘rq’ is used uninitialized in this function > > Indeed, since commit 2e13f33a2464fc3a ("lightnvm: create cmd before > allocating request"), the request is passed to nvme_nvm_rqtocmd() before > it is allocated. > > Fortunately, as of commit 91276162de9476b8 ("lightnvm: refactor end_io > functions for sync"), nvme_nvm_rqtocmd () no longer uses the passed > request, so this warning is a false positive. > > Drop the unused parameter to clean up the code and kill the warning. Thanks, applied. -- Jens Axboe