From: Peter Rosin <peda@axentia.se>
To: Luis Oliveira <Luis.Oliveira@synopsys.com>,
wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com,
jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com,
CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes.
Date: Fri, 9 Jun 2017 07:12:30 +0200 [thread overview]
Message-ID: <5bc3077b-2e4c-eb27-bca1-b7cbfc2dec01@axentia.se> (raw)
In-Reply-To: <4fb5f66dafc24e3213aaa8fc93fa12fecb6d6aa1.1496942505.git.lolivei@synopsys.com>
On 2017-06-08 19:36, Luis Oliveira wrote:
> complicated to review. The work here won't bring any additional work to
> backported fixes because is just style and reordering.
I challenge that. If there is an old bug that existed before this patch
that is fixed in the future after this patch has been applied, it might
very well be hard_er_ to backport that fix to a point before this patch
has been applied. So, what do you mean?
> @@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
> }
>
> i2c_dw_disable_int(dev);
> - r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags,
> + ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags,
> dev_name(dev->dev), dev);
Two extra spaces needed to align with the opening bracket.
Cheers,
peda
next prev parent reply other threads:[~2017-06-09 5:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 17:36 [PATCH v10 0/6] i2c: designware: add I2C SLAVE support Luis Oliveira
2017-06-08 17:36 ` [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes Luis Oliveira
2017-06-09 5:12 ` Peter Rosin [this message]
2017-06-09 7:57 ` Luis Oliveira
2017-06-09 8:38 ` Andy Shevchenko
2017-06-09 8:57 ` Peter Rosin
2017-06-08 17:36 ` [PATCH v10 2/6] i2c: designware: refactoring of the i2c-designware Luis Oliveira
2017-06-08 17:36 ` [PATCH v10 3/6] i2c: designware: MASTER mode as separated driver Luis Oliveira
2017-06-08 17:36 ` [PATCH v10 4/6] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira
2017-06-08 17:36 ` [PATCH v10 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira
2017-06-09 6:57 ` kbuild test robot
2017-06-09 8:53 ` Andy Shevchenko
2017-06-09 8:52 ` Andy Shevchenko
2017-06-08 17:36 ` [PATCH v10 6/6] i2c: designware: enable SLAVE in platform module Luis Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bc3077b-2e4c-eb27-bca1-b7cbfc2dec01@axentia.se \
--to=peda@axentia.se \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Luis.Oliveira@synopsys.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®