From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932988AbcFHLjO (ORCPT ); Wed, 8 Jun 2016 07:39:14 -0400 Received: from mail-lf0-f48.google.com ([209.85.215.48]:34369 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932604AbcFHLjL (ORCPT ); Wed, 8 Jun 2016 07:39:11 -0400 Subject: Re: [PATCH v9 03/14] usb: hcd.h: Add OTG to HCD interface To: Roger Quadros , peter.chen@freescale.com References: <1465376626-30122-1-git-send-email-rogerq@ti.com> <1465376626-30122-4-git-send-email-rogerq@ti.com> Cc: balbi@kernel.org, tony@atomide.com, gregkh@linuxfoundation.org, dan.j.williams@intel.com, mathias.nyman@linux.intel.com, Joao.Pinto@synopsys.com, jun.li@freescale.com, grygorii.strashko@ti.com, yoshihiro.shimoda.uh@renesas.com, robh@kernel.org, nsekhar@ti.com, b-liu@ti.com, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Sergei Shtylyov Message-ID: <5bc321c0-fb36-7a4a-d054-ee73b12822d4@cogentembedded.com> Date: Wed, 8 Jun 2016 14:39:07 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1465376626-30122-4-git-send-email-rogerq@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 6/8/2016 12:03 PM, Roger Quadros wrote: > The OTG core will use struct otg_hcd_ops to interface > with the HCD controller. Host controller driver (HCD) controller? Maybe just HC? :-) > The main purpose of this interface is to avoid directly > calling HCD APIs from the OTG core as they > wouldn't be defined in the built-in symbol table if > CONFIG_USB is m. > > Signed-off-by: Roger Quadros > Acked-by: Peter Chen > --- > include/linux/usb/hcd.h | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h > index 66fc137..7914bed 100644 > --- a/include/linux/usb/hcd.h > +++ b/include/linux/usb/hcd.h > @@ -400,6 +400,30 @@ struct hc_driver { > > }; > > +/** > + * struct otg_hcd_ops - Interface between OTG core and HCD > + * > + * Provided by the HCD core to allow the OTG core to interface with the HCD > + * > + * @add: function to add the HCD > + * @remove: function to remove the HCD > + * @usb_bus_start_enum: function to immediately start bus enumeration > + * @usb_control_msg: function to build and send of a control urb That "of" is not needed. And it's URB. [...] MBR, Sergei