From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13907C00140 for ; Fri, 19 Aug 2022 01:57:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243039AbiHSB5B (ORCPT ); Thu, 18 Aug 2022 21:57:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236015AbiHSB46 (ORCPT ); Thu, 18 Aug 2022 21:56:58 -0400 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2FA4DEB7D for ; Thu, 18 Aug 2022 18:56:56 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VMdxZUX_1660874213; Received: from 30.240.99.21(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0VMdxZUX_1660874213) by smtp.aliyun-inc.com; Fri, 19 Aug 2022 09:56:54 +0800 Message-ID: <5bc7f671-ad41-6a0c-535e-861b130992d9@linux.alibaba.com> Date: Fri, 19 Aug 2022 09:56:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: [PATCH V2 2/2] mm/damon/lru_sort: Remove struct of damon_lru_sort_ram_walk_arg To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220818172322.51705-1-sj@kernel.org> From: haoxin In-Reply-To: <20220818172322.51705-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/8/19 上午1:23, SeongJae Park 写道: > Hi Xin, > > On Thu, 18 Aug 2022 18:57:32 +0800 Xin Hao wrote: > >> The struct of 'damon_lru_sort_ram_walk_arg' is the same with struct of >> 'damon_addr_range', so, there no need to redefine it, just use struct of >> 'damon_addr_range' instead. > Reducing code is always good, thanks. However, I think the type of the 'start' > and 'end' fields of 'struct damon_addr_range' might be changed in a future. OK,  get it. > It's very unlikely, though. Also, we might add some more fields to the struct > in a future. After all, the purpose of 'struct damon_addr_range' is not saving > the 'start' and 'end' fields of 'struct resource'. I'd like to avoid making > any possible dependency here, sorry. > > > Thanks, > SJ > > [...]