From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1FAAC433F5 for ; Fri, 18 Mar 2022 12:53:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236446AbiCRMzC (ORCPT ); Fri, 18 Mar 2022 08:55:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236439AbiCRMzB (ORCPT ); Fri, 18 Mar 2022 08:55:01 -0400 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A79131DF8 for ; Fri, 18 Mar 2022 05:53:42 -0700 (PDT) Received: by mail-lj1-f181.google.com with SMTP id u3so11260574ljd.0 for ; Fri, 18 Mar 2022 05:53:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=4mu2OuGaPzAlSckILaZwyPu3lEiEzcu9CZya493fP8E=; b=saaQzXzI8UZ8u3oHra1CyTZxJexrxjlIHuyPiJtMquAD2IkiBiDVh0KPi+dAwg4AHl khBC1TmwAkGNDajrpUC4kuCLTvbcrROVQqMyrBfjPT5YqDxqXDZGKLejmeZ/EHaReuNx SyubnqRsp4fB4tWdml/3kP9T3xzG2yHK9msCynJo2xopijVga8h1lDGFgW78pxOGvkHf 3tiCEcJ+3swyJjoP3huJz7oZWtbG4IlkzbzyzFRH0X1mtYzykUn9Y+wa/AoU/aWk/D0m wvaefjbRhlOxrjT7SvSRBeDy9TABNesmU9otDxW0mV/BtHB69KkahbuziaGZbQaJSLKU ozWw== X-Gm-Message-State: AOAM533bcbjOGEqwbUNmUTf6UDA+NH65spKqf07yHd7r43CwNQ5Htxe/ nk2pl/C5+IGCE5vxxGCYKq4= X-Google-Smtp-Source: ABdhPJxQ9uko5et6u+LegwREFDr5bEBIZhwzLZ4c47FNelbGTzZYJD439JkB+S5faUXXtgm0Yi7G1A== X-Received: by 2002:a05:651c:1209:b0:244:b99d:8902 with SMTP id i9-20020a05651c120900b00244b99d8902mr5872302lja.185.1647608020684; Fri, 18 Mar 2022 05:53:40 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id c7-20020a2e9d87000000b00247ebe11990sm954625ljj.10.2022.03.18.05.53.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Mar 2022 05:53:40 -0700 (PDT) Message-ID: <5bc9ebe3-5c0b-2d72-4574-1630056c883e@kernel.org> Date: Fri, 18 Mar 2022 13:53:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] memory: atmel-ebi: Fix missing of_node_put in atmel_ebi_probe Content-Language: en-US To: Miaoqian Lin , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Boris Brezillon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220309110144.22412-1-linmq006@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220309110144.22412-1-linmq006@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/03/2022 12:01, Miaoqian Lin wrote: > The device_node pointer is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. > > Fixes: 87108dc78eb8 ("memory: atmel-ebi: Enable the SMC clock if specified") > Signed-off-by: Miaoqian Lin > --- > drivers/memory/atmel-ebi.c | 23 +++++++++++++++++------ > 1 file changed, 17 insertions(+), 6 deletions(-) > It's too late for upcoming cycle, so I will pick it up after the merge window. Best regards, Krzysztof