From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 227F23A1691 for ; Tue, 15 Sep 2026 09:06:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.86 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789463179; cv=none; b=VLl825UYK/eY8WdpEmJkhgQKANb+hN64vSdfOTPEiM8nj0H/VM4dESMwA1tV/XF30O6kX8xsYQ+duNOKyvLV1f/JypedGLwH7GIPBUHMh4qrAs3Jw092oh75KQGRFjKT9T5n4dI1dUV0nhAzwcxQQ5AVgAsUmDwbOXHlWodCFMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789463179; c=relaxed/simple; bh=AAeRbd8/IqpFm6esZWZu13YVaMo85dzXrzHDtM0reQw=; h=Message-ID:Subject:From:To:CC:Date:In-Reply-To:References: Content-Type:MIME-Version; b=FuvVudUab8v92u1RGlC30UYI62EncgvipJePX6c9HX3YJg0YbEL0qr0JzfBfOq4f1hVt3ks1dPH813vPi0EuDn5d/Ua86TnJSAvaJLhYvywOUVrfizVboNLrhSVL9rCVe4jWcjSkoZszuyujXmg1jx3M+Q2d0IZHlfpng5282AA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=lHN4KzQF; arc=none smtp.client-ip=91.207.212.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="lHN4KzQF" Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F6ZoVY3169079; Tue, 15 Sep 2026 10:05:50 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=dk201812; bh=h PNRl497t/azmGKn/enFzCLTDMlMuJ5aKmUdUCKZW30=; b=lHN4KzQFbCKYUCvJ6 Jc7g2ikX0jdvVlxc9rPRDwY2iCNBkw066qJ5VWw0ruBoEc3Yc3DMFLAPfG2881Wp p6VdcwBrogEsQ+N/6Nem/hxQ1m6TEVen2EPfBBbOhBd/2B7HntYXUprXh0XTiSF/ nuMcdXCP60MVoRbZe/yfFqQL9vP3e3HK8J8WxKw56soS2BXB7VEFRu5fjfImkwzo vojs8AGM1v38dps4G2fzdAZGILj3sx0gQF7P5VccQgJKi+pW+GmlIp+lCysmHy4d kzq20Yf5yu5sJAL4WOvf6QOApa/scSgONJCFqVGm5JsAJbmR5C9M7Tgg8/FBkTl8 paQBA== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 4gmw0q25mu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 10:05:49 +0100 (BST) Received: from np-m-daniel1.kl.imgtec.org (172.25.4.227) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Tue, 15 Sep 2026 10:05:48 +0100 Message-ID: <5bcbcbc46c1076f0e4c3b6e249ef2ce61db848a2.camel@imgtec.com> Subject: Re: [PATCH] drm/imagination: Fix PowerVR UAPI constant references in kernel-doc From: Luigi Santivetti To: Karl Mehltretter , Alessio Belle , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann CC: Faith Ekstrand , Frank Binns , , , Date: Tue, 15 Sep 2026 10:05:48 +0100 In-Reply-To: <16d56cee0036a41f411df0efab03bbcc8e964da2.camel@imgtec.com> References: <20260912063021.43076-1-kmehltretter@gmail.com> <16d56cee0036a41f411df0efab03bbcc8e964da2.camel@imgtec.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3-0ubuntu1.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDEzMCBTYWx0ZWRfX8Lt1CWJwq333 jsKmaLtUENBiPkvba/ipYkcp2NaU/A6Kfk1E6aw5PlF8DGOb2hUoBn8tmizeyu5I076Nzkj1N6+ 50CvwhGF2yva//Z0n+mn9q3TmbY7zim62VY0pBok+a/zSuIHfMSBygN+puyk6dUReOvgS19HozO N7Z80XyBx4ruAPF/IMttgwAkBp3640KuZI3lRiNEZpHgBWgzLsmbvvVLZkVYfrxGsB1d2QvszHr 8mAbHfqTCCcB2dF0mRqUxDt6z0UEXrRfHDdc5gfMMZ4j0YPZwudDFEUv2R9Wh8zCu9O0Gh/Zz3u I1mm7jwE+jo9WWLLlcmxKzOJD5++CEklAzBbOoFlydy/fhoxyTbuLq4ldzIGbRncKktCNBXP2PV YBbVQbYSzeaq0S/I/YDciff1YMkX3xjmyIbPcIIBlX1BQ0WVasQz9XYG0u+ktSGUs5t9PZsykIv YAqPOjkkq29Olo5HkuQ== X-Authority-Analysis: v=2.4 cv=c8M+0h9l c=1 sm=1 tr=0 ts=6aa90a6d cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=eoBRZU4O7WcA:10 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=qZQ2PDNLMSdLoqI-hfl9:22 a=pGLkceISAAAA:8 a=r_1tXGB3AAAA:8 a=oA8mNzHvY-ziBNhvJ5YA:9 a=QEXdDO2ut3YA:10 a=t8nPyN_e6usw4ciXM-Pk:22 X-Proofpoint-ORIG-GUID: 2a7FiZcwJkODQtcoD55aq0AF8gqX9GUm X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDEzMCBTYWx0ZWRfXx+LolqKGQxOi wOi/0V9s7cxHXQzBf4GIv03l2XYWiSEDLIxDkZTLZva/hicuaGblaG9d7JxL+rwMxaYXRv9sBXC VkX5pPZFfbapEAleTSa0Ue+MKdN+QnU= X-Proofpoint-GUID: 2a7FiZcwJkODQtcoD55aq0AF8gqX9GUm On Tue, 2026-09-15 at 09:51 +0100, Luigi Santivetti wrote: > On Sat, 2026-09-12 at 08:30 +0200, Karl Mehltretter wrote: > > The PowerVR UAPI comments contain misspellings of the enhancement query > > selector, two buffer object flags, and the job submission ioctl. The > > correct names were already present in the UAPI definitions when these > > comments were introduced. > >=20 > > Use DRM_PVR_DEV_QUERY_ENHANCEMENTS_GET, DRM_PVR_BO_PM_FW_PROTECT, > > DRM_PVR_BO_ALLOW_CPU_USERSPACE_ACCESS, and DRM_IOCTL_PVR_SUBMIT_JOBS in > > the corresponding comments. > >=20 > > Fixes: 1088d89e5515 ("drm/imagination/uapi: Add PowerVR driver UAPI") > > Assisted-by: LLM > > Signed-off-by: Karl Mehltretter >=20 > Reviewed-by: Luigi Santivetti >=20 > Thank you! > Luigi Would you mind propagating your fix driver-wise? $ grep -wnrE "DRM_IOCTL_PVR_SUBMIT_JOB|DRM_PVR_DEV_ENHANCEMENTS_GET|DRM_PVR_BO_DEVICE_PM= _FW_P ROTECT|DRM_PVR_BO_CPU_ALLOW_USERSPACE_ACCESS" drivers/gpu/drm/imagination/ drivers/gpu/drm/imagination/pvr_fw.c:1841: * %DRM_PVR_BO_DEVICE_PM_FW_PROTE= CT is implied for all FW objects. Consequently, drivers/gpu/drm/imagination/pvr_fw.c:1842: * this function will fail if @fl= ags has %DRM_PVR_BO_CPU_ALLOW_USERSPACE_ACCESS drivers/gpu/drm/imagination/pvr_fw.c:1923: * %DRM_PVR_BO_DEVICE_PM_FW_PROTE= CT is implied for all FW objects. Consequently, drivers/gpu/drm/imagination/pvr_fw.c:1924: * this function will fail if @fl= ags has %DRM_PVR_BO_CPU_ALLOW_USERSPACE_ACCESS drivers/gpu/drm/imagination/pvr_fw.c:1961: * %DRM_PVR_BO_DEVICE_PM_FW_PROTE= CT is implied for all FW objects. Consequently, drivers/gpu/drm/imagination/pvr_fw.c:1962: * this function will fail if @fl= ags has %DRM_PVR_BO_CPU_ALLOW_USERSPACE_ACCESS drivers/gpu/drm/imagination/pvr_fw.c:1998: * %DRM_PVR_BO_DEVICE_PM_FW_PROTE= CT is implied for all FW objects. Consequently, drivers/gpu/drm/imagination/pvr_fw.c:1999: * this function will fail if @fl= ags has %DRM_PVR_BO_CPU_ALLOW_USERSPACE_ACCESS drivers/gpu/drm/imagination/pvr_drv.c:1183: * Called from userspace with %DRM_IOCTL_PVR_SUBMIT_JOB. >=20 > --- > > =C2=A0include/uapi/drm/pvr_drm.h | 8 ++++---- > > =C2=A01 file changed, 4 insertions(+), 4 deletions(-) > >=20 > > diff --git a/include/uapi/drm/pvr_drm.h b/include/uapi/drm/pvr_drm.h > > index > > ccf6c2112468f3f53b093bc298dac2bbbfd35e6e..d97a69b83cc59338b7aae306e4dfa= 1320f > > 07 > > 1a2d 100644 > > --- a/include/uapi/drm/pvr_drm.h > > +++ b/include/uapi/drm/pvr_drm.h > > @@ -231,7 +231,7 @@ struct drm_pvr_dev_query_quirks { > > =C2=A0 * the user mode driver. > > =C2=A0 * > > =C2=A0 * When fetching this type &struct drm_pvr_ioctl_dev_query_args.t= ype must > > be > > set > > - * to %DRM_PVR_DEV_ENHANCEMENTS_GET. > > + * to %DRM_PVR_DEV_QUERY_ENHANCEMENTS_GET. > > =C2=A0 */ > > =C2=A0struct drm_pvr_dev_query_enhancements { > > =C2=A0 /** > > @@ -848,8 +848,8 @@ struct drm_pvr_ioctl_create_free_list_args { > > =C2=A0 * @max_num_pages * ``sizeof(__u32)``. > > =C2=A0 * > > =C2=A0 * The buffer object must have been created with > > - * %DRM_PVR_BO_DEVICE_PM_FW_PROTECT set and > > - * %DRM_PVR_BO_CPU_ALLOW_USERSPACE_ACCESS not set. > > + * %DRM_PVR_BO_PM_FW_PROTECT set and > > + * %DRM_PVR_BO_ALLOW_CPU_USERSPACE_ACCESS not set. > > =C2=A0 */ > > =C2=A0 __u64 free_list_gpu_addr; > > =C2=A0 > > @@ -1277,7 +1277,7 @@ struct drm_pvr_job { > > =C2=A0}; > > =C2=A0 > > =C2=A0/** > > - * struct drm_pvr_ioctl_submit_jobs_args - Arguments for > > %DRM_IOCTL_PVR_SUBMIT_JOB > > + * struct drm_pvr_ioctl_submit_jobs_args - Arguments for > > %DRM_IOCTL_PVR_SUBMIT_JOBS > > =C2=A0 * > > =C2=A0 * If the syscall returns an error it is important to check the v= alue of > > =C2=A0 * @jobs.count. This indicates the index into @jobs.array where t= he >=20