From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 948F63093A5 for ; Tue, 16 Dec 2025 07:35:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765870563; cv=none; b=cffNPshLYWskTXo/9vjY55y4hsBIjyssSrewallbOWarcUWbQ2wlHHgQ1DhHq8VQeAalIC4hziY0MRUbJ9Kj5xSjMoAGAFdmxG6gzjJIkHxHPkoMEKD1hLND3K9qEWaG6wCpAXgtpribnkFcZwYSa4nXlVVe1w2fJ7xMIx5PZtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765870563; c=relaxed/simple; bh=TSTZH3ha7P3zf07UuAzzCe0DuOTPhq7Iu4ok3zeXQDI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RslbAHh0RPaecKS2/gmXDwaEcQlOPr1aSnqW3fXzVzh9O9BCpmG7ESwfe8bCucNdCpheHveC6fDfkgzbcwLUu4Ekh7GtH0mfv4RxJqk4Tu/EgIciDf3SD5oKmnJwfP3I9dZ8uLwKlYHhfHLwfsPps0jnyoRs++vaitFrcRyBLCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MKcJHQ7d; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MKcJHQ7d" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-37fda2853c0so3875991fa.2 for ; Mon, 15 Dec 2025 23:35:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765870558; x=1766475358; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=n16XrMflW8K8mCPPIig2n79GG39zI0dw0k9fySATJAk=; b=MKcJHQ7dLs5AtE6b7YT3ZDf5h3PkL5su1lXUpP+J9VClf9fUGrUYX/MCeT25FVhJ59 ix5+KNe4tgJt9cMfVy97/AGeAN4oWklYOkb1haEjrQw7GQ2AirIl0auSmTAiOJdfs5qs EyTj9dpJL8XCkVyenr9nT9+wqYB8b5rSc5Wo8eHRXeeVG1bMCCRZpy8ya+H/egpEVxOo wVBusbwblb89K4aQbImL0/m08ndrZJetUbbzoYawmltU8hCUaKg5YMzjoBWW5tI8okVX h+pqLqKB9CKBQsOhBwDbK7tWFpWkGNah57K/MMfGDFXmsAP7QOORbzl07LHEavKzUJhd QjIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765870558; x=1766475358; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=n16XrMflW8K8mCPPIig2n79GG39zI0dw0k9fySATJAk=; b=eGjQWkgvrjqmjyPuVM7ytRrNmEJCmOBMlb8krEH1BMQ+4iuBWkofQ/rzfixNxfUZSu YNTberfZJaSnQSUo46BtTUZ2gJVt/bpihNcska3iPpimoERDD+C5UNB80v/lwfsjZQG6 6mBz8oEEq9Y8H3bavxDHmX71CTCCE5bnzfShciaCTB9jDVmO63y231QA3v3+Y+G1BWI+ Uw1R/WTNDEMYz1Wivj/RXzdlUgM5C+mG2AwQFuNLt41GNyaJssiRkvQowoQkfwdiVz47 7a7AauWgL+h/Miz5UiDEascEnPdTZdVIntuUiaF4cWwBxZeDXmsqDCNPZSlpQaj60KRG aPTw== X-Forwarded-Encrypted: i=1; AJvYcCV/HXDcAAmpfUCjZMoO6tJX4rXVXpJLBcbG5cClip895QpGDUhgnTEIRnAjG6SDj9fnxep1dt1tzamPRCQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyjVKpjUthOfeaE4JkXYMj3uCPxBAmhmYm+UHMVbDcftCV9JATV 3o3qpA2r9W9IsKKtmZv8SFKC7SIrFr8rwSH1MVeTfZbcUZd4KsguoskUEN/p2txAAZ4= X-Gm-Gg: AY/fxX5mPjqQ+vUIuC9sJeQ0aHw3pB9apAAexMHae7WPP45QzAQhherS+b/Bbeqkxum n9EpL7+9zVtcsAx3gtReSoVpmq2Xh/FACfhTCEpY6SzNBdJ/hPjuHyKYq9WtSLs76GL1jqQtSZN Bc+MdM0kOxxBnu0majuj2yiK9c415mlJKB1xcvap/vXeyFFTBixfTRgMzS50QQi902/hXhLi6y2 Mn4pcOJ+cgcoaW7bsyOWBF17TFRVPpZvImAsKr9xgQXeUCHxaMdVX0KVfZ9/3+kBWAYbMczgLxV Z7Ug2+c24cTZJjbODmC0RKqQ3oU0s1TMmy6dhtdJMZNDNQp/+VWV7169o7avbBW0ivz0sJWLsiQ t918T3I/uQzS09CzSFcQmREpsFp7S68lNPRqCYfSaXB5qZfdDEJfBfCkBkgrfmKk2vS0p00y1tL pxTFWU6w14zkSFpZExldHx0vsCWcY+dmH5tJ8BC4tD2L0CEURzyFArqu5iI/CWbxLhAA== X-Google-Smtp-Source: AGHT+IEA3Aizumvo2C29apLGRfL5f4cmKkJaCe7dpJMQ1br+YvsIHx4NhcZQQJWEH/cY0jbWIL6pIw== X-Received: by 2002:a05:6512:3e27:b0:598:e3ed:b43e with SMTP id 2adb3069b0e04-598faa98e36mr2872191e87.6.1765870557425; Mon, 15 Dec 2025 23:35:57 -0800 (PST) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5990da5040bsm639372e87.65.2025.12.15.23.35.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Dec 2025 23:35:56 -0800 (PST) Message-ID: <5bd29b5f-6fcf-428d-b451-698d92f0883e@linaro.org> Date: Tue, 16 Dec 2025 09:35:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 5/5] arm64: dts: qcom: monaco-evk-camera: Add DT overlay To: Nihal Kumar Gupta , bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, quic_svankada@quicinc.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ravi Shankar , Vishal Verma References: <20251216062223.2474216-1-quic_nihalkum@quicinc.com> <20251216062223.2474216-6-quic_nihalkum@quicinc.com> From: Vladimir Zapolskiy In-Reply-To: <20251216062223.2474216-6-quic_nihalkum@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/16/25 08:22, Nihal Kumar Gupta wrote: > Monaco EVK board does not include a camera sensor in its default hardware > configuration. Introducing a device tree overlay to support optional > integration of the IMX577 sensor via CSIPHY1. > > Camera reset is handled through an I2C expander, and power is enabled > via TLMM GPIO74. > > An example media-ctl pipeline for the imx577 is: > > media-ctl --reset > media-ctl -V '"imx577 3-001a":0[fmt:SRGGB10/4056x3040 field:none]' > media-ctl -V '"msm_csiphy1":0[fmt:SRGGB10/4056x3040]' > media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]' > media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]' > media-ctl -l '"msm_csiphy1":1->"msm_csid0":0[1]' > media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]' > yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video1 > > Signed-off-by: Nihal Kumar Gupta > Co-developed-by: Ravi Shankar > Signed-off-by: Ravi Shankar > Co-developed-by: Vishal Verma > Signed-off-by: Vishal Verma > Signed-off-by: Vikram Sharma > Reviewed-by: Vladimir Zapolskiy > Reviewed-by: Bryan O'Donoghue > --- > arch/arm64/boot/dts/qcom/Makefile | 4 ++ > .../dts/qcom/monaco-evk-camera-imx577.dtso | 67 +++++++++++++++++++ > 2 files changed, 71 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtso > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 6f34d5ed331c..b1ba182a0d8d 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -38,6 +38,10 @@ lemans-evk-camera-dtbs := lemans-evk.dtb lemans-evk-camera.dtbo > dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-camera-csi1-imx577.dtb > dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-camera.dtb > dtb-$(CONFIG_ARCH_QCOM) += monaco-evk.dtb > + > +monaco-evk-camera-imx577-dtbs := monaco-evk.dtb monaco-evk-camera-imx577.dtbo > +dtb-$(CONFIG_ARCH_QCOM) += monaco-evk-camera-imx577.dtb > + > dtb-$(CONFIG_ARCH_QCOM) += msm8216-samsung-fortuna3g.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-acer-a1-724.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-alcatel-idol347.dtb > diff --git a/arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtso b/arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtso > new file mode 100644 > index 000000000000..351eb5ee70ba > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/monaco-evk-camera-imx577.dtso > @@ -0,0 +1,67 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. Year is missing. > + */ > + > +/dts-v1/; > +/plugin/; > + > +#include > +#include > + > +&camss { > + vdda-phy-supply = <&vreg_l4a>; > + vdda-pll-supply = <&vreg_l5a>; > + > + status = "okay"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + reg = <1>; > + > + csiphy1_ep: endpoint { > + clock-lanes = <7>; Please remove 'clock-lanes' property here. > + data-lanes = <0 1 2 3>; > + remote-endpoint = <&imx577_ep1>; > + }; > + }; > + }; > +}; > + > +&cci1 { > + pinctrl-0 = <&cci1_0_default>; > + pinctrl-1 = <&cci1_0_sleep>; > + > + status = "okay"; > +}; > + > +&cci1_i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + camera@1a { > + compatible = "sony,imx577"; > + reg = <0x1a>; > + > + reset-gpios = <&expander2 1 GPIO_ACTIVE_LOW>; > + pinctrl-0 = <&cam1_default>; > + pinctrl-names = "default"; > + > + clocks = <&camcc CAM_CC_MCLK1_CLK>; > + assigned-clocks = <&camcc CAM_CC_MCLK1_CLK>; > + assigned-clock-rates = <24000000>; > + > + avdd-supply = <&vreg_cam1_2p8>; > + > + port { > + imx577_ep1: endpoint { > + link-frequencies = /bits/ 64 <600000000>; > + data-lanes = <0 1 2 3>; data-lanes property value should be '1 2 3 4>', 0 is for the clock lane. On CAMSS side this cannot be changed, unfortunately it's a lingering issue. > + remote-endpoint = <&csiphy1_ep>; > + }; > + }; > + }; > +}; If only one of 3 defined from 4/5 regulators is used, do you really wish to describle all 3 in advance? You may consider to remove 2 currently unused GPIO controlled regulator descriptions, and squash this change with 4/5. -- Best wishes, Vladimir