From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B48333D410E for ; Mon, 16 Mar 2026 17:20:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681653; cv=none; b=fyID/L5sB9gzBsdE0dNatLH3Vv3fkozOt065oJNLme+MRNCoXHDLuAGIg4mg8MpCnJ1+E5d7KKtZN8AYsWjX9RdTZi+uRgEwDvAxczGzPb5uApVOo9JiliT383AHgewc2fBOwZuCS186Y0UQtSVGl8lmjOF/LIf/Ce0Elluy3Kc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681653; c=relaxed/simple; bh=kJRbHz/Kmj9/f+jsu2tmX0LBtNG5gMiZTjc2ERT1T9w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ha46xwvwWcFd2+Jn1knLM2sa0zwZFZy8yQzuzkF16nHQODGwrovkhKdloav27sw56DoIBrT1ipX4I0rCOw6MuCOef0Gml+XCLNIXfpWKfDnUz8biR5RmmZSdUwGwAiIn3xI2twTVNa/AZKhr3RdGZUTILEQCQFy1km4hatqwoA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FbePiy9k; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZqMQmgIE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FbePiy9k"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZqMQmgIE" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GFN37k2315225 for ; Mon, 16 Mar 2026 17:20:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cVkiGJfb/hoYluJEhR6stCXpGS4CRK7PiadcKeGt7G8=; b=FbePiy9kJj9lOHrF XcW+/dz07xoPL/25KQtRiv41mhMvFbJ09Re4cNaR3ZlzE9wrpaXlOW+EpKs3Q8Yx PnvDp3FYknD0a9yXOrOEDFRyRWWcoTnmq1z10M1bRDmH5XrBoQ/8Ew5K5XYB+U4M FHaMBlyJaxB4J0VdqwD+CGY4VlQI1MoWUm6ov6yrOSOa0jJMt1SjzhlRw/hA659g FJz+diGbW14C2T00EezGx89qB2zdzeCD/6y7pe1QiGN5vptGWQZIEtm9Adh7sWNR i5uvKk3/9zb6t7hzCxHe33sf8QQkcGSaz22G6bpx+dcWmM6Ed1orcJWRQz45igde kmPakQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxmf28f41-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 17:20:50 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b051befbb8so20446715ad.2 for ; Mon, 16 Mar 2026 10:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773681650; x=1774286450; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cVkiGJfb/hoYluJEhR6stCXpGS4CRK7PiadcKeGt7G8=; b=ZqMQmgIEwdZYyjTmb3XYzf4cXyzC/ByQdKWccNOxxz3xOOhlAiSYDmJuTJEwpVnM1z Unary135iyizRs5HU7pixNX+mZdAbMRuHCzocHy0Ul5MdtXokSwu1OzgPfB7DIkd4BO7 xm66dTNNO+7D9LwPpwX3r9CXrgSgHSR1El8kMm8ijTzSJdl76qDF9AusLwxiY2HlvwyW 0JyoqxF3WGdqQDI+nNhFFljfS3DVTyKQMyNSzV1vcuJcAt7/I8R4lV+JxU0rsBJgCY7N gblftfGFe17Wu0r0/0PHOkVj3glIFidrZD3voRvThvk2DD2o8eaG09kkNtsTPFCYmKP0 VzkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773681650; x=1774286450; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cVkiGJfb/hoYluJEhR6stCXpGS4CRK7PiadcKeGt7G8=; b=MV7YqR4rFbVnK4Vg8Yuc/CCSljJo88p9DAZEmxcci7tVl+R/iKKWLwwdKIEyi/seEe AYhZ/TbNruaNPd/p6cSde9+d/xYzVnWbhCCdbD39wpW6CC8oDzUzADIIJabkD6bA4Xkj sbTLKQKj8BJmNOl1LL/YSlm6clTiR+Bi7EYuvMrDVN0g4IAUEqNSt/LjtdLR2Y7j8gSu 0OKJn0ox/AS6GCRyzJ44WpOPlfuUPaE8TWuPTWltBU8i5WlBUQ7GUiqnlGCuw+nahddP Re2MJj3q2e+FpPxZ277R7wPUCCn9tN5Bmle3qxJD3UsN1BTD4xHt8O9eyPBr5DNSKnFS u7jA== X-Forwarded-Encrypted: i=1; AJvYcCWj7w1Odnnvrprl/jwdyyUtXItZPd8BhJZN+jXf1cttBqmvaI2e/MriPDmJR0MLlQV4ZOaH3bhzt50TdMY=@vger.kernel.org X-Gm-Message-State: AOJu0YwkibsGkhaNsTBZiprnuFRlZBWBH1D66UVjKHUH/UL75M1Q1G0y j7Uquf2vsT4RtO0nfwiNf88qILa5CCdl6VdzEzqjWAvPNjVjLuSe/p/IjnqfPM95+3MUy0T9xR0 pwXcepSBLlNED6NnkTijTqX3pw94ACAMrG099zOOj0BeA8Pms1mrlUkX/Qv4lHne3LxM= X-Gm-Gg: ATEYQzzsxGhO1SqXfugI8kmjUQO7pCWqnu/zlkCRJ+yeOtZbwEnwVpguAKwLPGnPKer LgbJAkdHXO3JLW6nqp0hgG0PH0eCLTFYg8mxOrbSCDpsF30b+vOJh3eaNUlmE+G/RdkR5ZrV4qT q51QL/dHAK2jDc33T/2w9psvDTayWuB/3IeJ1/Y6+2k8nycOrd9qCCLTkm79hVpNCJ1DHkvPHvR SgN+lvwpdULUlmuNO5tnqSkkS7LLCSSMcDwf2hdu1/Goh7mCSHjudWAZVyTGZILlX7qqBAMOSFF AKqjG6EHs+KvPWg2c7qhrW+GunDLwa003Jw7nHQm8V4M6WatMWR2c1FqFJAv4GZsg5kgB7Z2r9b HHonqLcFGoFqw8TdrX5x2DnDBd1mV7ToYzg6D48Iw/A== X-Received: by 2002:a17:902:ea09:b0:2b0:4ec8:fb92 with SMTP id d9443c01a7336-2b04ec9004emr69176285ad.39.1773681649575; Mon, 16 Mar 2026 10:20:49 -0700 (PDT) X-Received: by 2002:a17:902:ea09:b0:2b0:4ec8:fb92 with SMTP id d9443c01a7336-2b04ec9004emr69175985ad.39.1773681649093; Mon, 16 Mar 2026 10:20:49 -0700 (PDT) Received: from [192.168.1.8] ([101.0.62.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece7ee6c6sm116230535ad.48.2026.03.16.10.20.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 10:20:48 -0700 (PDT) Message-ID: <5bd9b257-40dc-4ed4-88f7-b15b934fefa0@oss.qualcomm.com> Date: Mon, 16 Mar 2026 22:50:42 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/5] platform: arm64: Add driver for EC found on Qualcomm reference devices To: Konrad Dybcio , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Maya Matuszczyk References: <20260313-v04-add-driver-for-ec-v4-0-ca9d0efd62aa@oss.qualcomm.com> <20260313-v04-add-driver-for-ec-v4-2-ca9d0efd62aa@oss.qualcomm.com> Content-Language: en-US From: Anvesh Jain P In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: J1u3DubiYibc0d5YmQfNuEJmp475PQQu X-Proofpoint-GUID: J1u3DubiYibc0d5YmQfNuEJmp475PQQu X-Authority-Analysis: v=2.4 cv=FvcIPmrq c=1 sm=1 tr=0 ts=69b83bf2 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=+2ldRcY3HLWus9HqRSG52w==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=8WFAAEkrk-lUUCZj-DcA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDEzNCBTYWx0ZWRfXyVKIWcbekvxE 8ZyXiX304/Xsywmu25QOxyPR2CgQCnnG0Lnr+VDj5EIyqvj1TqwlCDsqT/hx2j2rFn1P4KxzK9b cCAsnGSqDKSP3T5eT61KCy4ANvaKcSAi1PqMyA/4N4HNiC3zyUYikYEmk5yMtbFvjXBIagTW+0H blGOm3Mm3NtyPBjwOrNjnaaWwo28ErC0j8RYUzI3nki/5/e1oHy5J1svDbxSh23qWsG8Pk21Cua Bput//SCHmoXBFpfveHfTs5evFUwx6o/wYzVUV9zYouwAbgLljeEfhX8Ih9vwdJc6p760iDP9bo GHacBRBI+n7lORpOusxx5Q52sfvnQKbiTRrDXBoVPJ+xWASGHM2jdw7N1+V9zQGmTJOdLE4tvzP TBBWJspesZei6pOHzkSX+xTsXbZ6bUq8IJcqnb88hCYqc3erE5jhRPz7ejEHAQ2MLRxR41mpBql f3RN1scbduOVJ0ZoBAA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 clxscore=1015 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160134 On 3/16/2026 3:59 PM, Konrad Dybcio wrote: >> + * | Offset | Name | Description | >> + * ------------------------------------------------------------------------------ >> + * | 0x00 | Byte count | Number of bytes in response | >> + * | | | (exluding byte count) | >> + * ------------------------------------------------------------------------------ >> + * | 0x02 (LSB) | EC Thermal | Bit 0-1: Number of fans | > qcom_ec_fan_debug_mode_off() documentation only mentions values 1/2 > to be correct - is that the case? > Yes, qcom_ec_fan_debug_mode_off() will only support values 1/2. The above documentation mentions about number of fans available, max being 2. >> + * | 0x3 | Capabilities | Bit 2-4: Type of fan | > What types are there? CPU/AUX or similar? > This is fan vendor identification byte. 0 being invalid/not present. -- Best Regards, Anvesh